Hi Daniel,
2011/12/1 Daniel K. d...@uw.no:
Yasuo Ohgaki wrote:
I've made the patch for trunk. I checked by using session module
tests using valgrind.
https://gist.github.com/1379668
As a general comment there seems to be lots of extra white space in the
'empty' lines of the patch.
On 12/01/2011 02:38 AM, Yasuo Ohgaki wrote:
Hi Daniel,
2011/12/1 Daniel K. d...@uw.no:
Yasuo Ohgaki wrote:
I've made the patch for trunk. I checked by using session module
tests using valgrind.
https://gist.github.com/1379668
As a general comment there seems to be lots of extra white
Hi,
2011/11/29 Daniel Convissor dani...@analysisandsolutions.com:
Hi Folks:
There's a minor difference between the output of configure --help
between PHP_5_3 and PHP_5_4. The change makes it hard to tell what the
default values are for some options.
The options impacted are those defined
I'll respond to all at once ;)
On 11/30/11 1:58 PM, Will Fitch wrote:
If that's the case, then why not just add whatever $options is as a
parameter to your constructor. I'm not totally against this concept,
but this use is moot.
I'm simply trying to find usefulness in the new feature of
To be honest, I'm not a fan of the proposal as written since it can't
accept arbitrary expressions inside the parenthesis. Now, if you
could do any expression inside, then I would +1 for completeness. But
since that's not really possible with the current parser (or language
specification), I'm
Hi Rasmus,
2011/12/1 Rasmus Lerdorf ras...@lerdorf.com:
Please just tell your diff to ignore whitespace when you create the
patch. It is annoying to have to sift through extra irrelevant lines.
I think Daniel mean there are extra spaces for indent.
I'll fix it.
Since Daniel mentioned that he
2011/12/2 Yasuo Ohgaki yohg...@ohgaki.net:
I think Daniel mean there are extra spaces for indent.
I'll fix it.
Done.
Since Daniel mentioned that he cannot disable strict session, I
compiled against current head. According to run-tests.php, it seems
there is something wrong that prevents
Hi,
Recent activity:
Alexey Shein dug through the failing symfony2 tests, and it turned out that
3 tests were bugged, he went ahead and fixed it (
https://github.com/symfony/symfony/pull/2750), one from the other two is a
sporadic test, it can fail randomly, the last one fails in our specific
Hi all,
According to comments, I updated the patch.
Test files are added.
Entry added to php.ini-*
https://gist.github.com/1379668
--
Yasuo Ohgaki
yohg...@ohgaki.net
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Yasuo Ohgaki wrote:
2011/12/2 Yasuo Ohgaki yohg...@ohgaki.net:
I think Daniel mean there are extra spaces for indent.
I'll fix it.
That's exactly it, however the updated patch still has problems.
Search for a + followed by only tabs or spaces. Empty lines should be
just that, empty.
Since
Yasuo Ohgaki wrote:
Hi all,
According to comments, I updated the patch.
Our emails crossed, however my comments still stand.
Test files are added.
Thanks for that.
Entry added to php.ini-*
Typo:
+session.usr_strict_mode = 1
Daniel K.
--
PHP Internals - PHP Runtime Development
2011/12/2 Daniel K. d...@uw.no:
Yasuo Ohgaki wrote:
2011/12/2 Yasuo Ohgaki yohg...@ohgaki.net:
I think Daniel mean there are extra spaces for indent.
I'll fix it.
That's exactly it, however the updated patch still has problems.
Search for a + followed by only tabs or spaces. Empty lines
Hi Daniel,
2011/12/2 Daniel K. d...@uw.no:
Yasuo Ohgaki wrote:
Hi all,
According to comments, I updated the patch.
Our emails crossed, however my comments still stand.
Test files are added.
Thanks for that.
Entry added to php.ini-*
Typo:
+session.usr_strict_mode = 1
Thank
Hi all,
2011/12/2 Yasuo Ohgaki yohg...@ohgaki.net:
With strict session, user cannot set session ID. If user can, it's not
a strict session, but adoptive.
If user would like to use adoptive session, user may set
session.use_strict_mode=0.
When user tried to use session_id() to set their on
Hi all,
2011/12/2 Yasuo Ohgaki yohg...@ohgaki.net:
Hi all,
2011/12/2 Yasuo Ohgaki yohg...@ohgaki.net:
With strict session, user cannot set session ID. If user can, it's not
a strict session, but adoptive.
If user would like to use adoptive session, user may set
session.use_strict_mode=0.
Yasuo Ohgaki wrote:
2011/12/2 Daniel K. d...@uw.no:
Yasuo Ohgaki wrote:
2011/12/2 Yasuo Ohgaki yohg...@ohgaki.net:
Search for a + followed by only tabs or spaces. Empty lines should be
just that, empty.
Does CODING_STANDARDS mention this?
I hope not, this should be obvious.
Since
16 matches
Mail list logo