Re: [PHP-DEV] Deprecate and remove case-insensitive constants?

2017-09-12 Thread Levi Morrison
On Tue, Sep 12, 2017 at 6:52 AM, François Laupretre wrote: > Hi, > > Le 12/09/2017 à 14:02, Christoph M. Becker a écrit : >> >> Hi everybody! >> >> Usually constant identifiers are treated case-sensitive in PHP. This is >> always the case for constants defined via a `const`

Re: [PHP-DEV] Deprecate and remove case-insensitive constants?

2017-09-12 Thread François Laupretre
Hi, Le 12/09/2017 à 14:02, Christoph M. Becker a écrit : Hi everybody! Usually constant identifiers are treated case-sensitive in PHP. This is always the case for constants defined via a `const` declaration. However, define() allows to pass TRUE as third argument to define a case-insensitive

Re: [PHP-DEV] Deprecate and remove case-insensitive constants?

2017-09-12 Thread Niklas Keller
2017-09-12 14:02 GMT+02:00 Christoph M. Becker : > Hi everybody! > > Usually constant identifiers are treated case-sensitive in PHP. This is > always the case for constants defined via a `const` declaration. > However, define() allows to pass TRUE as third argument to define a

Re: [PHP-DEV] Deprecate and remove case-insensitive constants?

2017-09-12 Thread Christoph M. Becker
On 12.09.2017 at 14:52, François Laupretre wrote: > What about making PHP 8 100% case-sensitive (except true/false) ? If we > announce it years in advance, it is possible, IMO. I don't think we can do that. Consider, for instance, ext/gd where all functions are actually in lower case, but I've

[PHP-DEV] Deprecate and remove case-insensitive constants?

2017-09-12 Thread Christoph M. Becker
Hi everybody! Usually constant identifiers are treated case-sensitive in PHP. This is always the case for constants defined via a `const` declaration. However, define() allows to pass TRUE as third argument to define a case-insensitive constant. This feature appears to potentially result in

Re: [PHP-DEV] Wiki karma request

2017-09-12 Thread Joe Watkins
Granted Cheers Joe On Sun, Sep 10, 2017 at 6:04 PM, Larry Garfield wrote: > Username: crell > > Access requested: Wiki edit > > Reason: Helping out Sara Golemon with logistics and paperwork for the > short-lambda RFC, and collaborating on another RFC regarding >

Re: [PHP-DEV] Deprecate and remove case-insensitive constants?

2017-09-12 Thread Rowan Collins
On 12 September 2017 17:45:46 BST, Levi Morrison wrote: >The rest of my message only makes sense once you understand I was >proposing unified case sensitivity for all symbols *and* merging them >into one table. Ah, OK, so I partially missed the point. I'm still not sure what

[PHP-DEV] Merging LDAP controls support

2017-09-12 Thread Côme Chilliet
Hello, I’m getting close to have something I can merge in master for my PR adding support for LDAP controls: https://github.com/php/php-src/pull/2640 In this case am I suppose to squash the changes in a single commit? This was suggested to me for a previous PR but there is so much changes here

Re: [PHP-DEV] Deprecate and remove case-insensitive constants?

2017-09-12 Thread Levi Morrison
> Apologies if I've completely missed the point here. Oh well, it happens. > Are you saying that without case sensitivity, the language could deduce that > sum2 in that case was a function reference? That seems optimistic: not only > can you have a class, a constant, and a function all with

Re: [PHP-DEV] [RFC] [Discussion] JSON_THROW_ON_ERROR

2017-09-12 Thread Jakub Zelenka
On Sun, Sep 10, 2017 at 2:24 AM, Andrea Faulds wrote: > Hi everyone, > > Craig Duncan previously sparked discussion here about JSON's > error-handling behaviour. Unfortunately, his attempt to change it seems not > to have gone anywhere, but I have his blessing to try this other

Re: [PHP-DEV] Deprecate and remove case-insensitive constants?

2017-09-12 Thread Christoph M. Becker
On 12.09.2017 at 21:55, Sara Golemon wrote: > On Tue, Sep 12, 2017 at 7:43 PM, Stanislav Malyshev > wrote: > >> I'm worried about TRUE vs. True vs. true though - I've see all of those used >> around the code (not tRuE though ;) and breaking that would add a ton of >>

Re: [PHP-DEV] Deprecate and remove case-insensitive constants?

2017-09-12 Thread Levi Morrison
On Tue, Sep 12, 2017 at 11:59 AM, Rowan Collins wrote: > On 12 September 2017 17:45:46 BST, Levi Morrison wrote: >>The rest of my message only makes sense once you understand I was >>proposing unified case sensitivity for all symbols *and* merging them

Re: [PHP-DEV] Deprecate and remove case-insensitive constants?

2017-09-12 Thread Stanislav Malyshev
Hi! > case-insensitive constant. This feature appears to potentially result > in confusion, and also causes bugs as shown in > . See an example created by Nikita to see > some probably unexpected behavior: . The latter case probably should be

Re: [PHP-DEV] Deprecate and remove case-insensitive constants?

2017-09-12 Thread Sara Golemon
On Tue, Sep 12, 2017 at 7:43 PM, Stanislav Malyshev wrote: > I don't think HHVM not supporting something can be an argument. > I agree there, though I will offer that part of the reason HHVM has never bothered to support case-insensitive constants is that it's simply never

Re: [PHP-DEV] Deprecate and remove case-insensitive constants?

2017-09-12 Thread Christoph M. Becker
On 12.09.2017 at 16:52, Levi Morrison wrote: > On Tue, Sep 12, 2017 at 6:52 AM, François Laupretre > wrote: >> >> Le 12/09/2017 à 14:02, Christoph M. Becker a écrit : >> >>> Even if these issues could be resolved, I still think allowing both >>> case-sensitive and

Re: [PHP-DEV] A validator module for PHP7

2017-09-12 Thread Yasuo Ohgaki
On Tue, Sep 12, 2017 at 1:04 PM, Stephen Reay wrote: > > On 12 Sep 2017, at 04:07, Yasuo Ohgaki wrote: > > Stephen, > > On Tue, Sep 12, 2017 at 12:22 AM, Stephen Reay > wrote: > >> >> On 11 Sep 2017, at 17:41, Yasuo Ohgaki

Re: [PHP-DEV] Deprecate and remove case-insensitive constants?

2017-09-12 Thread Dan Ackroyd
On 12 September 2017 at 14:04, Christoph M. Becker wrote: > > I don't think we can do that. Consider, for instance, ext/gd where all > functions are actually in lower case, but I've seen a lot of code > written in pascal or camel case to make the functions better readable,

Re: [PHP-DEV] Deprecate and remove case-insensitive constants?

2017-09-12 Thread Levi Morrison
> By itself this change provides little value. If it was done in > connection with other features such as merging symbol tables then we > can actually gain some significant improvements: > > array_map(sum2, $input1, $input2); > > Currently that requires `sum2` to be a constant. To get the

Re: [PHP-DEV] Deprecate and remove case-insensitive constants?

2017-09-12 Thread Rowan Collins
On 12 September 2017 15:52:38 BST, Levi Morrison wrote: >array_map(sum2, $input1, $input2); > >Currently that requires `sum2` to be a constant. I'm not clear what this has to do with case sensitivity; the problem here is that we don't have a type of "function reference" (nor

Re: [PHP-DEV] Deprecate and remove case-insensitive constants?

2017-09-12 Thread Sara Golemon
On Tue, Sep 12, 2017 at 5:02 AM, Christoph M. Becker wrote: > Even if these issues could be resolved, I still think allowing both > case-sensitive and case-insensitive constant identifiers does more harm > than good. > +0.1 to removing case-insensitive constants, though we'd