Re: [PHP-DEV] RFC: PHP JIT/arm64 port

2021-03-19 Thread Dmitry Stogov
Hi Hao, I'm the author of JIT for PHP. Please CC me next time, I read @internals only from time to time... I'll try to take a look into your implementation next week. I'm not sure how much time I'll be able to invest yet, I'll have to discuss this with my management. Thanks. Dmitry. On Wed,

Re: [PHP-DEV] [RFC] noreturn type

2021-03-19 Thread Nikita Popov
On Fri, Mar 19, 2021 at 3:45 PM Marco Pivetta wrote: > Hey Nikita, > > On Fri, Mar 19, 2021, 14:35 Nikita Popov wrote: > >> >> Is it allowed to declare a noreturn function that returns by reference? >> >> function (): noreturn {} >> > > Given that `noreturn` means it should throw, loop forever

Re: [PHP-DEV] [RFC] Namespaced in bundled extensions

2021-03-19 Thread Christoph M. Becker
On 19.03.2021 at 15:13, Nikita Popov wrote: > I'd love to have some more feedback on this RFC before opening voting. > There has been a lot of discussion beforehand, but only a couple responses > to this RFC... I very much like this pragmatic approach, which also matches most of the already

RE: [PHP-DEV] RFC: PHP JIT/arm64 port

2021-03-19 Thread Hao Sun
Hi Dmitry, Thanks for your reply. Yes. Sure. I will CC you next time. As I mentioned in the previous email, this is our (ARM) initial effort to enable JIT/arm64 port and there might exist some potential bugs in implementation or something we haven’t considered/designed soundly. Please let us

Re: [PHP-DEV] [RFC] noreturn type

2021-03-19 Thread Matthew Brown
On Fri, 19 Mar 2021 at 10:53, Nikita Popov wrote: > On Fri, Mar 19, 2021 at 3:45 PM Marco Pivetta wrote: > >> Hey Nikita, >> >> On Fri, Mar 19, 2021, 14:35 Nikita Popov wrote: >> >>> >>> Is it allowed to declare a noreturn function that returns by reference? >>> >>> function (): noreturn {}

[PHP-DEV] Re: Don't compare zero exponentials in strings as equal

2021-03-19 Thread Nikita Popov
On Wed, Mar 3, 2021 at 3:04 PM Nikita Popov wrote: > Hi internals, > > PHP's == comparison semantics for strings have a peculiar edge-case, where > comparisons of the form "0e123" == "0e456" return true, because they are > interpreted as floating point zero numbers. This is problematic, because

Re: [PHP-DEV] [RFC] Namespaced in bundled extensions

2021-03-19 Thread G. P. B.
On Thu, 25 Feb 2021 at 20:26, Nikita Popov wrote: > Hi internals, > > The question of namespaces in the stdlib has been coming up a lot recently, > so I'd like to present my own stab at resolving this question: > > https://wiki.php.net/rfc/namespaces_in_bundled_extensions > > Relative to a

Re: [PHP-DEV] RFC: PHP JIT/arm64 port

2021-03-19 Thread Dmitry Stogov
Yeah, I suppose this is going to be a big task and we will have to collaborate a lot. anyway, next week... It's already Friday evening. Thanks. Dmitry. On Fri, Mar 19, 2021 at 5:20 PM Hao Sun wrote: > Hi Dmitry, > > Thanks for your reply. > > > > Yes. Sure. I will CC you next time. > > > > As

Re: [PHP-DEV] [RFC] noreturn type

2021-03-19 Thread Nikita Popov
On Wed, Mar 10, 2021 at 7:07 PM Matthew Brown wrote: > Hey, > > Ondřej Mirtes and I present an RFC for the noreturn type: > https://wiki.php.net/rfc/noreturn_type > > The feature already exists in Hack (the primary inspiration) and is > currently supported by our static analysis tools inside

Re: [PHP-DEV] [RFC] Namespaced in bundled extensions

2021-03-19 Thread tyson andre
Hi Nikita Popov, > The question of namespaces in the stdlib has been coming up a lot recently, > so I'd like to present my own stab at resolving this question: > > https://wiki.php.net/rfc/namespaces_in_bundled_extensions > > Relative to a number of previous (declined) proposals, the main

Re: [PHP-DEV] [RFC] New in initializers

2021-03-19 Thread Nikita Popov
On Fri, Mar 19, 2021 at 12:57 PM Nikita Popov wrote: > On Fri, Mar 19, 2021 at 12:22 PM Nikita Popov > wrote: > >> On Wed, Mar 3, 2021 at 7:04 PM Alexandru Pătrănescu >> wrote: >> >>> >>> On Wed, Mar 3, 2021 at 5:49 PM Nikita Popov >>> wrote: >>> On Wed, Mar 3, 2021 at 4:28 PM Alexandru

Re: [PHP-DEV] [RFC] Namespaced in bundled extensions

2021-03-19 Thread Nikita Popov
On Fri, Mar 19, 2021 at 3:04 PM tyson andre wrote: > Hi Nikita Popov, > > > The question of namespaces in the stdlib has been coming up a lot > recently, > > so I'd like to present my own stab at resolving this question: > > > > https://wiki.php.net/rfc/namespaces_in_bundled_extensions > > > >

Re: [PHP-DEV] [RFC] Autoloader Classmap

2021-03-19 Thread Nikita Popov
On Mon, Mar 15, 2021 at 6:41 PM Mark Randall wrote: > Hi Internals, > > I would like to propose the addition of a new mechanism of autoloading > classes - a classmap that will be consulted prior to checking the > spl_autoload_register'd callbacks. > > https://wiki.php.net/rfc/autoload_classmap

Re: [PHP-DEV] [RFC] noreturn type

2021-03-19 Thread Marco Pivetta
Hey Nikita, On Fri, Mar 19, 2021, 14:35 Nikita Popov wrote: > > Is it allowed to declare a noreturn function that returns by reference? > > function (): noreturn {} > Given that `noreturn` means it should throw, loop forever or exit, how would a by-ref usage be applied/useful? Or is it a hint

Re: [PHP-DEV] [RFC] Namespaced in bundled extensions

2021-03-19 Thread Christoph M. Becker
On 19.03.2021 at 19:28, Mike Schinkel wrote: > The registration process would be as simple as submitting a PR that includes > the requested namespace added to both the README.md and the namespaces.json > file along with a link for more information. > > There would not be any approval process

Re: [PHP-DEV] PHP 7.4.17RC1 is available for testing

2021-03-19 Thread Helmut K. C. Tessarek
On 2021-03-19 14:41, Christoph M. Becker wrote: > All source code releases are supposed to contain the file NEWS, which is > the changelog. Argh, so I missed it. Stupid me. I was just so fixated on Changelog/CHANGELOG that my brain ignored NEWS (which was actually the original changelog file in

Re: [PHP-DEV] [VOTE] Fibers

2021-03-19 Thread Rowan Tommins
On 18/03/2021 09:20, Josh Di Fabio wrote: "If you want to enable fibers in your application, you must be confident about the implementation details of all of the code in your application, including that of your dependencies, which are written and maintained by other developers." I don't have

Re: [PHP-DEV] [RFC] Namespaced in bundled extensions

2021-03-19 Thread Mike Schinkel
> On Mar 19, 2021, at 2:44 PM, Christoph M. Becker wrote: > > On 19.03.2021 at 19:28, Mike Schinkel wrote: > >> The registration process would be as simple as submitting a PR that includes >> the requested namespace added to both the README.md and the namespaces.json >> file along with a link

Re: [PHP-DEV] [RFC] Autoloader Classmap

2021-03-19 Thread Ayesh Karunaratne
Please ignore my last message :( Hi Internals, I did a somewhat rough test to compare Composer's autoloader and the function proposed in the RFC. ## TL;DR: autoload_set_classmap over Composer with OPCache: 8.12% autoload_set_classmap over Composer without OPCache: 7.93% ## Long version:

Re: [PHP-DEV] PHP 7.4.17RC1 is available for testing

2021-03-19 Thread Christoph M. Becker
On 19.03.2021 at 19:21, Helmut K. C. Tessarek wrote: > On 2021-03-18 14:19, Derick Rethans wrote: >> PHP 7.4.17RC1 has just been released and can be downloaded from: >> >> >> >> Or use the git tag: php-7.4.17RC1 > > Maybe a dumb question, but is there a

Re: [PHP-DEV] [RFC] [Discussion] Adding return types to internal methods

2021-03-19 Thread Máté Kocsis
Hi Nicolas, > Oh, I didn't get this at first: you're telling that this native return > type would not be enforced when the attribute is declared? This should > answer my previous comment. > Yes, that's the case. On one hand, this solution IMO has the advantage that its syntax integrates into

Re: [PHP-DEV] PHP 7.4.17RC1 is available for testing

2021-03-19 Thread Helmut K. C. Tessarek
On 2021-03-18 14:19, Derick Rethans wrote: > PHP 7.4.17RC1 has just been released and can be downloaded from: > > > > Or use the git tag: php-7.4.17RC1 Maybe a dumb question, but is there a reason why there's no Changelog in the source tree? Or did I

Re: [PHP-DEV] [RFC] Autoloader Classmap

2021-03-19 Thread Mark Randall
On 19/03/2021 14:45, Nikita Popov wrote: Could you please update the RFC with some performance numbers, including the used methodology? The number of 5% has been floating around, but it's not clear what it refers to. I'm primarily interested in end-to-end effect, e.g. on the symfony demo

Re: [PHP-DEV] [RFC] Namespaced in bundled extensions

2021-03-19 Thread Mike Schinkel
> On Feb 25, 2021, at 3:26 PM, Nikita Popov wrote: > > Hi internals, > > The question of namespaces in the stdlib has been coming up a lot recently, > so I'd like to present my own stab at resolving this question: > > https://wiki.php.net/rfc/namespaces_in_bundled_extensions > > Relative to a

Re: [PHP-DEV] [RFC] Autoloader Classmap

2021-03-19 Thread Ayesh - PHP.Watch
Hi Internals, I did a somewhat rough test to compare Composer's autoloader and the function proposed in the RFC. ## TL;DR: Composer autoloader + Opcache: autoload_set_classmap + Opcache: ## Long version: Using symfony/framework-bundle , symfony/console, and phpunit/phpunit, in a new composer

Re: [PHP-DEV] [RFC] Autoloader Classmap

2021-03-19 Thread Mike Schinkel
> On Mar 19, 2021, at 2:40 PM, Mark Randall wrote: > > On 19/03/2021 14:45, Nikita Popov wrote: >> Could you please update the RFC with some performance numbers, including >> the used methodology? The number of 5% has been floating around, but it's >> not clear what it refers to. I'm primarily

Re: [PHP-DEV] [VOTE] Fibers

2021-03-19 Thread Mike Schinkel
> On Mar 19, 2021, at 3:55 PM, Rowan Tommins wrote: > > On 18/03/2021 09:20, Josh Di Fabio wrote: >> "If you want to enable fibers in your application, you must be >> confident about the implementation details of all of the code in your >> application, including that of your dependencies,

Re: [PHP-DEV] [VOTE] Fibers

2021-03-19 Thread Niklas Keller
Hey Levi, On Mon, Mar 8, 2021 at 12:40 PM Aaron Piotrowski wrote: > > > > Greetings everyone! > > > > The vote has started on the fiber RFC: https://wiki.php.net/rfc/fibers < > https://wiki.php.net/rfc/fibers> > > > > Voting will run through March 22nd. > > > > Cheers, > > Aaron Piotrowski > >

Re: [PHP-DEV] [VOTE] Fibers

2021-03-19 Thread Levi Morrison via internals
On Fri, Mar 19, 2021 at 3:54 PM Niklas Keller wrote: > > Hey Levi, > >> On Mon, Mar 8, 2021 at 12:40 PM Aaron Piotrowski wrote: >> > >> > Greetings everyone! >> > >> > The vote has started on the fiber RFC: https://wiki.php.net/rfc/fibers >> > >> > >> > Voting

Re: [PHP-DEV] [VOTE] Fibers

2021-03-19 Thread Levi Morrison via internals
On Mon, Mar 8, 2021 at 12:40 PM Aaron Piotrowski wrote: > > Greetings everyone! > > The vote has started on the fiber RFC: https://wiki.php.net/rfc/fibers > > > Voting will run through March 22nd. > > Cheers, > Aaron Piotrowski This is selfish, but I would like

Re: [PHP-DEV] [RFC] New in initializers

2021-03-19 Thread Nikita Popov
On Fri, Mar 19, 2021 at 12:22 PM Nikita Popov wrote: > On Wed, Mar 3, 2021 at 7:04 PM Alexandru Pătrănescu > wrote: > >> >> On Wed, Mar 3, 2021 at 5:49 PM Nikita Popov wrote: >> >>> On Wed, Mar 3, 2021 at 4:28 PM Alexandru Pătrănescu >>> wrote: >>> Hi, This looks very nice and

Re: [PHP-DEV] [RFC] New in initializers

2021-03-19 Thread Nikita Popov
On Wed, Mar 3, 2021 at 7:04 PM Alexandru Pătrănescu wrote: > > On Wed, Mar 3, 2021 at 5:49 PM Nikita Popov wrote: > >> On Wed, Mar 3, 2021 at 4:28 PM Alexandru Pătrănescu >> wrote: >> >>> Hi, >>> >>> This looks very nice and I'm interested in further steps where not only >>> new can be used