Re: [PHP-DEV] [VOTE] Choosing a distributed version control system for PHP

2011-08-24 Thread Lester Caine
Gwynne Raskind wrote: On Wed, Aug 24, 2011 at 19:03, David Soria Parra wrote: > Those wanting to use git and git workflows have a disadvantage when we stay with SVN. > Choosing a VCS happens from time to time and sometimes your favorit is not the winner. > I personally would love to see PH

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Aleksandr Galkin
For the record, I'd like to point out I do need the new behaviour. In 5.3.6 you need reflection to check if a class implements an interface. You also need to check is_subclass_of AND compare the lowercased classes. All that is about 5 times slower than is_a in 5.3.8. Probably it should be class_is

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread a...@akbkhome.com
It did not like my search for is_a ;) - I guess it's too short. On Thursday, August 25, 2011 11:59 AM, Ronald Chmara wrote: On Wed, Aug 24, 2011 at 6:51 PM, a...@akbkhome.com wrote: BTW. we could really do with a searchable archive of php.dev + internals... - It's pretty difficult to find out

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Ronald Chmara
On Wed, Aug 24, 2011 at 6:51 PM, a...@akbkhome.com wrote: > BTW. we could really do with a searchable archive of php.dev + internals... > - It's pretty difficult to find out if this was ever discussed before.. http://marc.info/?l=php-internals marc has a ton of the PHP lists. (Is this not what y

Re: [PHP-DEV] [VOTE] Choosing a distributed version control system for PHP

2011-08-24 Thread Gwynne Raskind
On Wed, Aug 24, 2011 at 19:03, David Soria Parra wrote: > Those wanting to use git and git workflows have a disadvantage when we stay > with SVN. > Choosing a VCS happens from time to time and sometimes your favorit is not > the winner. > I personally would love to see PHP moving to hg, but if m

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread a...@akbkhome.com
I'm not sure it's possible to get agreement on if this is a bug or not, you might see a bug, I just see this as a pointless change for consistency that pretty much nobody will ever need or use. I think I'll leave it as a) no bug was ever reported on the previous behaviour. b) intended "design"

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Stas Malyshev
Hi! On 8/24/11 4:38 PM, Alan Knowles wrote: Some real history for the young ones ;) I wonder who you are meaning... :) So the previous behavior was very likely the 'designed' behavior. Not an accidental side effect, or bug. Bugs can be very well intentional, but if they use the language wr

Re: [PHP-DEV] Why the autoconf <= 2.59 check?

2011-08-24 Thread Rasmus Lerdorf
On 08/24/2011 04:08 PM, Edwin van Vliet wrote: > In commit 09e803c it is unfortunately unclear exactly why support for > "newer" autoconf is somehow dropped. Since autoconf 2.60 was released > Mon, 26 Jun 2006, this means PHP 5.3.8 needs to be built with software > more than 5 years old. By itself

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Alan Knowles
Some real history for the young ones ;) If you go all the way back to when is_a() was introduced, it appears that it was done to simplify the code in PEAR::isError, which basically did stuff like if is_object() and is subclass() or get_classname() == ... So the previous behavior was very lik

[PHP-DEV] Why the autoconf <= 2.59 check?

2011-08-24 Thread Edwin van Vliet
In commit 09e803c it is unfortunately unclear exactly why support for "newer" autoconf is somehow dropped. Since autoconf 2.60 was released Mon, 26 Jun 2006, this means PHP 5.3.8 needs to be built with software more than 5 years old. By itself this is not necessarily a problem, but for example Cent

Re: [PHP-DEV] [VOTE] Choosing a distributed version control system for PHP

2011-08-24 Thread David Soria Parra
On 2011-08-24, Lester Caine wrote: > David Soria Parra wrote: >>> I'm not sure choosing DCVS by vote is actually a good way to go here. >>> > I think we need much more input from people that maintain all the >>> > infrastructure we're using now and would be doing the move. If we >>> > don't hav

Re: [PHP-DEV] [VOTE] Choosing a distributed version control system for PHP

2011-08-24 Thread Lester Caine
David Soria Parra wrote: I'm not sure choosing DCVS by vote is actually a good way to go here. > I think we need much more input from people that maintain all the > infrastructure we're using now and would be doing the move. If we > don't have people committed to making it happen majority-base

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Lester Caine
Pierre Joye wrote: I think you are confusing "worked for me" with "perfectly fine". Sorry, but as I agreed to adapt it in trunk/5.4, it cannot be changed in 5.3, period. The reasons have been explained enough times already, with examples of working codes out there. Now let vote on that instead o

Re: [PHP-DEV] [VOTE] Choosing a distributed version control system for PHP

2011-08-24 Thread Pierre Joye
On Wed, Aug 24, 2011 at 11:15 PM, Stas Malyshev wrote: > Hi! > > On 8/24/11 2:03 PM, David Soria Parra wrote: >> >> Hi Internals,, >> >> after 3 weeks of discussion, I think we are ready to start voting on >> the DVCS RFC.  If you think something is missing or should be explained >> in more detail

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Pierre Joye
On Wed, Aug 24, 2011 at 10:21 PM, Stas Malyshev wrote: > I think you are confusing "worked for me" with "perfectly fine". Sorry, but as I agreed to adapt it in trunk/5.4, it cannot be changed in 5.3, period. The reasons have been explained enough times already, with examples of working codes out

Re: [PHP-DEV] [VOTE] Choosing a distributed version control system for PHP

2011-08-24 Thread David Soria Parra
On 2011-08-24, Ferenc Kovacs wrote: > On Wed, Aug 24, 2011 at 11:15 PM, Stas Malyshev > wrote: >> Hi! >> >> On 8/24/11 2:03 PM, David Soria Parra wrote: >>> >>> Hi Internals,, >>> >>> after 3 weeks of discussion, I think we are ready to start voting on >>> the DVCS RFC. ??If you think something

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Ferenc Kovacs
On Wed, Aug 24, 2011 at 11:33 PM, Stas Malyshev wrote: > Hi! > > Thanks for providing the timeline. > > On 8/24/11 2:15 PM, Ferenc Kovacs wrote: >> >> 5, Helgi fixed Pear in the meanwhile >> >> http://svn.php.net/viewvc/pear/pear-core/tags/PEAR-1.9.5/PEAR.php?r1=313081&r2=313083&pathrev=313340 > >

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Stas Malyshev
Hi! Thanks for providing the timeline. On 8/24/11 2:15 PM, Ferenc Kovacs wrote: 5, Helgi fixed Pear in the meanwhile http://svn.php.net/viewvc/pear/pear-core/tags/PEAR-1.9.5/PEAR.php?r1=313081&r2=313083&pathrev=313340 This fix doesn't look good - it doesn't do what is was meant to do. 7, He

Re: [PHP-DEV] [VOTE] Choosing a distributed version control system for PHP

2011-08-24 Thread Ferenc Kovacs
On Wed, Aug 24, 2011 at 11:15 PM, Stas Malyshev wrote: > Hi! > > On 8/24/11 2:03 PM, David Soria Parra wrote: >> >> Hi Internals,, >> >> after 3 weeks of discussion, I think we are ready to start voting on >> the DVCS RFC.  If you think something is missing or should be explained >> in more detail

Re: [PHP-DEV] [VOTE] Choosing a distributed version control system for PHP

2011-08-24 Thread David Soria Parra
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/24/2011 11:15 PM, Stas Malyshev wrote: > Hi! > > On 8/24/11 2:03 PM, David Soria Parra wrote: >> Hi Internals,, >> >> after 3 weeks of discussion, I think we are ready to start voting >> on the DVCS RFC. If you think something is missing or sh

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Ferenc Kovacs
> If I am reading things right, is_a was only designed to handle an object, so > feeding it a mixed parameter in isError was always wrong? As far as I can > see, on the whole, the PEAR code only ever feeds an object and feeding it a > string would have to be a real error? So there are a number of a

Re: [PHP-DEV] [VOTE] Choosing a distributed version control system for PHP

2011-08-24 Thread Stas Malyshev
Hi! On 8/24/11 2:03 PM, David Soria Parra wrote: Hi Internals,, after 3 weeks of discussion, I think we are ready to start voting on the DVCS RFC. If you think something is missing or should be explained in more detail, let me know. I'm not sure choosing DCVS by vote is actually a good way t

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Stas Malyshev
Hi! On 8/24/11 1:45 PM, Lester Caine wrote: If I am reading things right, is_a was only designed to handle an object, so feeding it a mixed parameter in isError was always wrong? As far as I can see, on the whole, the PEAR code only ever feeds an object and feeding it a string would have to be a

[PHP-DEV] [VOTE] Choosing a distributed version control system for PHP

2011-08-24 Thread David Soria Parra
Hi Internals,, after 3 weeks of discussion, I think we are ready to start voting on the DVCS RFC. If you think something is missing or should be explained in more detail, let me know. Votes can be found here: https://wiki.php.net/rfc/dvcs/vote The RFC can be found here: https://wiki.p

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Lester Caine
Stas Malyshev wrote: mmh.. how much breakage did you want. PEAR::isError is basically is_a($input, 'PEAR_Error'); it's been like that for> 8 years So, PEAR has a bug, if it passes non-object argument to is_a, as previously is_a was only documented (and actually still is) as accepting obje

[PHP-DEV] Free iPad! How? Purchase Advertising in CelebrityAccess/Encore by September 1st!

2011-08-24 Thread CelebrityAccess
For a limited time, CelebrityAccess wants to thank our advertisers by providing these great Apple products absolutely free. Purchase advertising by September 1, 2011 and DOUBLE your advertising time. Here's the deal... Depending on the amount of advertising purchased, CelebrityAccess will se

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Stas Malyshev
Hi! On 8/24/11 11:05 AM, Pierre Joye wrote: As it was working perfectly fine until now, it was perfectly fine to use is_a only to valid possible instances of a given class, passing a non object returned false, which was totally correct (per se). I think you are confusing "worked for me" with "

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Pierre Joye
On Wed, Aug 24, 2011 at 8:02 PM, Stas Malyshev wrote: > Hi! > > On 8/24/11 10:56 AM, pierre@gmail.com wrote: >> >> What are you talking about? The change is exactly about that, change the >> behavior when a string is passed. > > Code relying on passing string to is_a is buggy, since it is clea

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Stas Malyshev
Hi! On 8/24/11 10:56 AM, pierre@gmail.com wrote: What are you talking about? The change is exactly about that, change the behavior when a string is passed. Code relying on passing string to is_a is buggy, since it is clearly documented as accepting object. That's what I am talking about.

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread pierre....@gmail.com
What are you talking about? The change is exactly about that, change the behavior when a string is passed. We are back to the discussion about undeprecating is_a, from scratch... It hurts codes and apps with 5.3, let do it in 5.4 only. - Reply message - From: "Stas Malyshev" Date: Wed

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Stas Malyshev
Hi! On 8/24/11 5:38 AM, a...@akbkhome.com wrote: " If it's a clear bug, which IMHO this is_a() issue was - then unless we're looking at code breakage at massive scale, it should be fixed. " mmh.. how much breakage did you want. PEAR::isError is basically is_a($input, 'PEAR_Error'); it's been l

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Johannes Schlüter
On Wed, 2011-08-24 at 07:47 -0700, Christopher Jones wrote: > > On 8/24/11 3:42 AM, Johannes Schlüter wrote: > > > We don't push them out as news on the php.net frontpage and we don't > > send it out to the announce list for reasons like not confusing users. > > Should we change that? > > Announ

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Christopher Jones
On 8/24/11 3:42 AM, Johannes Schlüter wrote: We don't push them out as news on the php.net frontpage and we don't send it out to the announce list for reasons like not confusing users. Should we change that? Announcements of RC X, Alpha X etc should be on the frontpage. Chris -- Email: chr

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread JJ
I think it's too late to do much of anything other than document the change in a way that makes it easier for people to recognize. I spoke to Philip about this offline and I think the two options along these lines are: 1) Add a WARNING box which specifies the change for the function, that a true t

[PHP-DEV] Debian 5.3.7-1 -> 5.3.8-1 test results

2011-08-24 Thread Ondřej Surý
Hi, here's the report for Debian build (amd64 build): I have already included Daniel's fixes for DateTime tests: -DateTime::diff() days -- spring type2 type2 [ext/date/tests/DateTime_days-spring-type2-type2.phpt] -DateTime::diff() days -- spring type2 type3 [ext/date/tests/DateTime_days-spring-t

[PHP-DEV] Re: [PATCH]#55493(Superglobal variable variables with ${expression} in non-global scope)

2011-08-24 Thread Laruence
PS: test result can be found at : http://pastebin.com/6pTuLEer no new test failed in there. thanks :-) 2011/8/24 Laruence : > Hi: >    since kalle think that issue make sense,  I made a patch for it. > >    and agian, sure we can fixed it(that is how I make this patch), > but that doesn't mean w

[PHP-DEV] [PATCH]#55493(Superglobal variable variables with ${expression} in non-global scope)

2011-08-24 Thread Laruence
Hi: since kalle think that issue make sense, I made a patch for it. and agian, sure we can fixed it(that is how I make this patch), but that doesn't mean we should fixed it :-) and if we will plan to do, hope the patch can help. thank plz refer to the bug report page: https://bu

RE: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Zeev Suraski
Well, I have to admit this is mighty convincing :) Wasn't aware of this use-case. Falls under the category of mass breakage I guess. Zeev > -Original Message- > From: a...@akbkhome.com [mailto:a...@akbkhome.com] > Sent: Wednesday, August 24, 2011 3:39 PM > To: Zeev Suraski; internals@

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Pierre Joye
Hi Alan, the breakage is about is_a with a string as 1st argument, not is_a as a whole. So yes, it breaks is_a alone is used as validation. On Wed, Aug 24, 2011 at 2:38 PM, a...@akbkhome.com wrote: > " If it's a clear bug, which IMHO this is_a() issue was - then unless we're > looking at code br

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread a...@akbkhome.com
" If it's a clear bug, which IMHO this is_a() issue was - then unless we're looking at code breakage at massive scale, it should be fixed. " mmh.. how much breakage did you want. PEAR::isError is basically is_a($input, 'PEAR_Error'); it's been like that for > 8 years google search for PE

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Ferenc Kovacs
On Wed, Aug 24, 2011 at 2:15 PM, Dirk Haun wrote: > Quoting Ferenc Kovacs : > >> On Wed, Aug 24, 2011 at 1:59 PM, Ryan McCue wrote: >>> >>> Ferenc Kovacs wrote: the aggregated report summaries are available at http://qa.php.net/reports/ thanks to Oliver Doucet who make this ha

RE: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Zeev Suraski
> by case basis. It is now very well known that when a fix requires a test > change, > then it often leads to bc breaks or similar issues. > > I do not think we have to argue about the semantics or general cases but how > to avoid such things and be sure that we break as less code as possible in

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Dirk Haun
Quoting Ferenc Kovacs : On Wed, Aug 24, 2011 at 1:59 PM, Ryan McCue wrote: Ferenc Kovacs wrote: the aggregated report summaries are available at http://qa.php.net/reports/ thanks to Oliver Doucet who make this happen. Which, incidentally, doesn't appear to be working at this point in time.

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Pierre Joye
On Wed, Aug 24, 2011 at 2:00 PM, Zeev Suraski wrote: >> > This wholesale statement doesn't get us anywhere. >> >> It does, we underestimate the situation and this fix/improvement/consistency >> change breaks apps and codes out there. >> And I do not consider it as acceptable at this stage in 5.3.x

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Ferenc Kovacs
On Wed, Aug 24, 2011 at 1:59 PM, Ryan McCue wrote: > Ferenc Kovacs wrote: >> the aggregated report summaries are available at >> http://qa.php.net/reports/ thanks to Oliver Doucet who make this >> happen. >> > > Which, incidentally, doesn't appear to be working at this point in time. it was worki

RE: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Zeev Suraski
> > This wholesale statement doesn't get us anywhere. > > It does, we underestimate the situation and this fix/improvement/consistency > change breaks apps and codes out there. > And I do not consider it as acceptable at this stage in 5.3.x. Let do it only > in > 5.4. How is it different from a

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Ryan McCue
Ferenc Kovacs wrote: > the aggregated report summaries are available at > http://qa.php.net/reports/ thanks to Oliver Doucet who make this > happen. > Which, incidentally, doesn't appear to be working at this point in time. -- Ryan McCue -- PHP Internals - PHP Runtime

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Pierre Joye
On Wed, Aug 24, 2011 at 1:40 PM, Zeev Suraski wrote: >> No matter what it is or how it is defined by us, it breaks existing code and >> that >> should be avoided in bug fixes releases like 5.3.7/8. > > Pierre, > > This wholesale statement doesn't get us anywhere. It does, we underestimate the si

RE: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Zeev Suraski
> No matter what it is or how it is defined by us, it breaks existing code and > that > should be avoided in bug fixes releases like 5.3.7/8. Pierre, This wholesale statement doesn't get us anywhere. Every bug fix can result in breaking existing code. If due to a logic error, under some circu

RE: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Zeev Suraski
Alan, I think this feature can certainly be useful, but either way, but again, unless I'm misunderstanding you - you're defining new functionality (support for new types of a first argument) as a BC break. I don't think it's realistic to look at it this way. And I do think that it's useful, a

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread a...@akbkhome.com
It's not really a bug fix, as the document for is_a() never said it would support 'mixed' first argument. (is_subclass_of is different, it currently says mixed as the first argument). If it needed fixing, then support for strings should have been removed, rather than added. The problem I have

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Alexey Shein
2011/8/24 Ferenc Kovacs : > 2011/8/24 Johannes Schlüter : >> On Wed, 2011-08-24 at 12:24 +0200, Ferenc Kovacs wrote: >>> we could have spotted this via two ways: >>> - those who participated in fixing >>> https://bugs.php.net/bug.php?id=53727 could have spotted this >>> - our tests should have star

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Pierre Joye
On Wed, Aug 24, 2011 at 12:43 PM, Zeev Suraski wrote: > I think there are two ways to look at it: > > - As a new feature.  If I understand you correctly, the fact that beforehand > is_a() was documented to only return TRUE in case the first argument was an > instance of the second argument, mean

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Ferenc Kovacs
On Wed, Aug 24, 2011 at 1:04 PM, Dirk Haun wrote: > Quoting Johannes Schlüter : > >> I have the impression that very few people actually test these. When >> creating an RC we inform the "primary testers" as well as qa and >> internals list members. From there I get one or two responses in >> gener

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Ferenc Kovacs
2011/8/24 Johannes Schlüter : > On Wed, 2011-08-24 at 12:24 +0200, Ferenc Kovacs wrote: >> we could have spotted this via two ways: >> - those who participated in fixing >> https://bugs.php.net/bug.php?id=53727 could have spotted this >> - our tests should have start failing after the change > > Th

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Dirk Haun
Quoting Johannes Schlüter : I have the impression that very few people actually test these. When creating an RC we inform the "primary testers" as well as qa and internals list members. From there I get one or two responses in general. What happens to the reports that "make test" sends back to

RE: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Zeev Suraski
I think there are two ways to look at it: - As a new feature. If I understand you correctly, the fact that beforehand is_a() was documented to only return TRUE in case the first argument was an instance of the second argument, means that if we do anything beyond that - e.g. support strings as

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Johannes Schlüter
On Wed, 2011-08-24 at 12:24 +0200, Ferenc Kovacs wrote: > we could have spotted this via two ways: > - those who participated in fixing > https://bugs.php.net/bug.php?id=53727 could have spotted this > - our tests should have start failing after the change Third option: - RC testers might have spo

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Pierre Joye
the problem is to change existing tests to match a "possible fix", that defeats the whole purpose of testing possible BC breaks using our test suites. We should definitively run x.y.0 tests during the whole x.y.0 life, and if something has to be changed, then it should be 1st be discussed, or RFC

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Ferenc Kovacs
On Wed, Aug 24, 2011 at 12:00 PM, Pierre Joye wrote: > agreed. > about this specific change: the real problem is that nobody spotted this change until we rolled out the stable release, after that we can only chose from bad options. we could have spotted this via two ways: - those who participated

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Pierre Joye
agreed. On Wed, Aug 24, 2011 at 11:36 AM, Derick Rethans wrote: > On Wed, 24 Aug 2011, Ferenc Kovacs wrote: > >> On Wed, Aug 24, 2011 at 3:57 AM, a...@akbkhome.com wrote: >> > It might have been better to have waited for the is_a() fix to get sorted >> > out.. - It's a very annoying BC break (c

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Ferenc Kovacs
On Wed, Aug 24, 2011 at 11:36 AM, Derick Rethans wrote: > On Wed, 24 Aug 2011, Ferenc Kovacs wrote: > >> On Wed, Aug 24, 2011 at 3:57 AM, a...@akbkhome.com wrote: >> > It might have been better to have waited for the is_a() fix to get sorted >> > out.. - It's a very annoying BC break (changes the

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread a...@akbkhome.com
Since when has changing documented behaviour and breaking a large number of applications been acceptable? (Well, happens occasionally by accident ..) This was a 'feature change' to is_a(), it was documented as _only_ returning 'TRUE' when an object was passed as the first object and it was an

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Derick Rethans
On Wed, 24 Aug 2011, Ferenc Kovacs wrote: > On Wed, Aug 24, 2011 at 3:57 AM, a...@akbkhome.com wrote: > > It might have been better to have waited for the is_a() fix to get sorted > > out.. - It's a very annoying BC break (changes the documented behaviour), > > and now it means we need 4.3.9 in a

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Reindl Harald
Am 24.08.2011 10:06, schrieb Sebastian Bergmann: > On 08/24/2011 03:57 AM, a...@akbkhome.com wrote: >> It might have been better to have waited for the is_a() fix to get sorted >> out. > > No, it would have been better if the only difference between PHP 5.3.7 > and PHP 5.3.8 would have been th

[PHP-DEV] Re: [BC]mysql_pconnect generate warning when link against mysqlnd

2011-08-24 Thread Laruence
Hi: hmm, but it really no sense for mysql_ping. the function used to identified a link whether valid, and if not valid, return a false is enough :) thanks 2011/8/24 Andrey Hristov : >  Hi, > in my opinion a warning in this case is better than no warning. Because this > shows a problem

Re: [PHP-DEV] 5.3.7 is breaking SSL

2011-08-24 Thread Andrey Hristov
Hi, it's pretty simple, once you have a MySQL server running with enabled SSL. You can use the following three files to set your MySQL http://hristov.com/mysql_certs/server-key.pem http://hristov.com/mysql_certs/server-cert.pem http://hristov.com/mysql_certs/cacert.pem [mysqld] ssl-capath=/path

Re: [PHP-DEV] Failing Autotests / Bugs

2011-08-24 Thread Lester Caine
Lester Caine wrote: Rasmus Lerdorf wrote: and visit it daily from now on? I'd like to see this go to 0 before we release the first 5.4 beta later this year. Probably by moving the bulk of these to XFAIL, but in some cases the tests themselves really are bogus and either need to be removed or fix

[PHP-DEV] Re: [BC]mysql_pconnect generate warning when link against mysqlnd

2011-08-24 Thread Andrey Hristov
Hi, in my opinion a warning in this case is better than no warning. Because this shows a problem and even if display_warnings is off the warnings can be logged for further inspection. Best, Andrey On 08/24/2011 09:35 AM, Laruence wrote: And the same warnings will be throw while call mysql_p

Re: [PHP-DEV] SVN Downtime

2011-08-24 Thread Lester Caine
Keloran wrote: lester you dont work for this company do you http://thedailywtf.com/Articles/Supporting-The-Twenty-Year-Server-Plan,-The-Ice-Machine,-and-The-Split-Monitor.aspx hehe No but I recognise the customer ... The server sits in the bottom of a cupboard behind the counter area ;) The

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Sebastian Bergmann
On 08/24/2011 03:57 AM, a...@akbkhome.com wrote: It might have been better to have waited for the is_a() fix to get sorted out. No, it would have been better if the only difference between PHP 5.3.7 and PHP 5.3.8 would have been the fix for the crypt() issue. -- Sebastian Bergmann

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-08-24 Thread Ferenc Kovacs
On Wed, Aug 24, 2011 at 3:57 AM, a...@akbkhome.com wrote: > It might have been better to have waited for the is_a() fix to get sorted > out.. - It's a very annoying BC break (changes the documented behaviour), > and now it means we need 4.3.9 in a few more days. > > Let me know if you need help te

Re: [PHP-DEV] SVN Downtime

2011-08-24 Thread Keloran
lester you dont work for this company do you http://thedailywtf.com/Articles/Supporting-The-Twenty-Year-Server-Plan,-The-Ice-Machine,-and-The-Split-Monitor.aspx hehe On Wed, Aug 24, 2011 at 8:35 AM, Lester Caine wrote: > Rasmus Lerdorf wrote: > >> We still have new hardware coming in the next

[PHP-DEV] Re: [BC]mysql_pconnect generate warning when link against mysqlnd

2011-08-24 Thread Laruence
And the same warnings will be throw while call mysql_ping too. $plink = mysql_pconnect(); sleep(*); //a long time wait the mysql server timeout if (!mysql_ping($plink)) {} // warning genereated thanks 2011/8/24 Laruence : > Hi: >    when linke mysql against mysqlnd, > >    call to mysql_pco

Re: [PHP-DEV] SVN Downtime

2011-08-24 Thread Lester Caine
Rasmus Lerdorf wrote: We still have new hardware coming in the next week or two for both svn and www (y1 and y2) and we will be migrating off these boxes that have served us well since 2005. I think this is the first hardware problem we have had with them. Same disks for 6 years? I've just had

[PHP-DEV] [BC]mysql_pconnect generate warning when link against mysqlnd

2011-08-24 Thread Laruence
Hi: when linke mysql against mysqlnd, call to mysql_pconnect after previous one timeout, can trigger a warnning: PHP Warning: mysql_pconnect(): MySQL server has gone away while linked against libmysql will not generate this warning. so maybe this should be a BC ? thanks

Re: [PHP-DEV] Failing Autotests / Bugs

2011-08-24 Thread Lester Caine
Reindl Harald wrote: Actually this is possibly another argument for a properly managed DVCS setup? On other projects I can pick > critical commits and apply them, and it flags when other bits need to be implemented as well. Almost does away > with the need to produce actual releases, but you