Re: [PHP-DEV] Asking for a review of crypt() allocation changes

2012-06-30 Thread Ángel González
On 29/06/12 14:43, Nikita Popov wrote: Hi internals! Anthony and me have been looking a lot at the crypt() code recently and noticed that there are some strange things going on in the buffer allocations for the sha algorithms. We did two commits to fix them up a bit:

Re: [PHP-DEV] concatenation operator

2012-06-30 Thread Adi Mutu
By initialization i mean the latest point possible where I can set a breakpoint, but right before my scripts starts executing it's emalloc's or efree's.  but even then you will see many things you're probably not interested in such as?..  Only thing that helps is learning the code 

Re: [PHP-DEV] RFC proposal - Syntactic sugar for cloning

2012-06-30 Thread Michael Morris
Uhm... = On Fri, Jun 29, 2012 at 6:09 PM, Paul Dragoonis dragoo...@gmail.com wrote: My input is that we should be focusing on features that PHP lacks, or fixing bugs rather than adding more sugar syntax just for the sake of adding it. On Fri, Jun 29, 2012 at 7:47 PM, Pierrick Charron

[PHP-DEV] JSON changes in 5.3/5.4

2012-06-30 Thread Stas Malyshev
Hi! I see that there were significant changes committed to JSON extension in 5.3 and 5.4 recently. These changes modify json_encode behavior, break tests (pass001.1_64bit.phpt does not work anymore for me), are not clearly documented and have no NEWS/UPGRADING entries describing what exactly

[PHP-DEV] Re: JSON changes in 5.3/5.4

2012-06-30 Thread Nikita Popov
On Sun, Jul 1, 2012 at 12:59 AM, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! I see that there were significant changes committed to JSON extension in 5.3 and 5.4 recently. These changes modify json_encode behavior, break tests (pass001.1_64bit.phpt does not work anymore for me), are not

[PHP-DEV] Re: JSON changes in 5.3/5.4

2012-06-30 Thread Johannes Schlüter
On Sun, 2012-07-01 at 01:14 +0200, Nikita Popov wrote: If you are okay with the changes in principle, I will fix the remaining issues asap. If you think that the changes are too intrusive for release branches, I'll gladly revert them for 5.3/5.4. I didn't quite expect that there will be so

[PHP-DEV] Re: JSON changes in 5.3/5.4

2012-06-30 Thread Nikita Popov
On Sun, Jul 1, 2012 at 1:27 AM, Johannes Schlüter johan...@schlueters.de wrote: I think in 5.3 we don't need changes. 5.3 is a stable stable stable branch. Fixing bugs, ok, changing behavior: No go. Agreed. One question: When I revert the changes to 5.3 should I also revert the original change

[PHP-DEV] Re: JSON changes in 5.3/5.4

2012-06-30 Thread Stas Malyshev
Hi! If you are okay with the changes in principle, I will fix the remaining issues asap. If you think that the changes are too intrusive for release branches, I'll gladly revert them for 5.3/5.4. I didn't quite expect that there will be so many changes. I think changes with adding new

Re: [PHP-DEV] concatenation operator

2012-06-30 Thread Johannes Schlüter
On Sat, 2012-06-30 at 03:53 -0700, Adi Mutu wrote: By initialization i mean the latest point possible where I can set a breakpoint, but right before my scripts starts executing it's emalloc's or efree's. Does executing include compilation? Does it include creating a stack frame etc. for