[PHP-DEV] VCS Account Request: rajivgadda

2013-04-12 Thread Rajiv Gadda
writing and editing php source code for optimization. such as facebook hiphop. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] OPcache optimizer improvement in PHP-5.5?

2013-04-12 Thread Dmitry Stogov
Good point. Thanks. Dmitry. On Fri, Apr 12, 2013 at 3:09 AM, Graham Kelly-Cohn sgkel...@gmail.comwrote: I don't think this is a safe optimization. In the following case it would output 'b' and not 'a' which is the correct result: a.php: ?php define('FOO', 'a'); include('b.php'); ?

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread Julien Pauli
On Fri, Apr 12, 2013 at 1:34 AM, Kalle Sommer Nielsen ka...@php.net wrote: Hi 2013/4/12 Pierre Joye pierre@gmail.com: On Thu, Apr 11, 2013 at 11:17 PM, Pierrick Charron pierr...@adoy.net wrote: Including 5.3 and 5.4 ?? If removed in 5.3 and 5.4, theres no need for the constant

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread Xinchen Hui
On Fri, Apr 12, 2013 at 4:00 PM, Julien Pauli jpa...@php.net wrote: On Fri, Apr 12, 2013 at 1:34 AM, Kalle Sommer Nielsen ka...@php.netwrote: Hi 2013/4/12 Pierre Joye pierre@gmail.com: On Thu, Apr 11, 2013 at 11:17 PM, Pierrick Charron pierr...@adoy.net wrote: Including 5.3 and 5.4

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread Johannes Schlüter
On Fri, 2013-04-12 at 10:00 +0200, Julien Pauli wrote: On Fri, Apr 12, 2013 at 1:34 AM, Kalle Sommer Nielsen ka...@php.net wrote: Hi 2013/4/12 Pierre Joye pierre@gmail.com: On Thu, Apr 11, 2013 at 11:17 PM, Pierrick Charron pierr...@adoy.net wrote: Including 5.3 and 5.4 ??

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread Pierre Joye
On Fri, Apr 12, 2013 at 10:07 AM, Johannes Schlüter johan...@schlueters.de wrote: On Fri, 2013-04-12 at 10:00 +0200, Julien Pauli wrote: On Fri, Apr 12, 2013 at 1:34 AM, Kalle Sommer Nielsen ka...@php.net wrote: Hi 2013/4/12 Pierre Joye pierre@gmail.com: On Thu, Apr 11, 2013 at

Re: [PHP-DEV] Extension loading improvements

2013-04-12 Thread Julien Pauli
On Wed, Apr 10, 2013 at 7:14 PM, Dmitry Stogov dmi...@zend.com wrote: Hi, 1) I didn't get why do we need fprintf(Loaded/Unloaded extension). It'll break all the tests in DEBUG mode 2) zend_error() may work through SAPI handler (e.g. for FastCGI sapi it may try to send error message to

Re: [PHP-DEV] Extension loading improvements

2013-04-12 Thread Ferenc Kovacs
On Fri, Apr 12, 2013 at 10:53 AM, Julien Pauli jpa...@php.net wrote: On Wed, Apr 10, 2013 at 7:14 PM, Dmitry Stogov dmi...@zend.com wrote: Hi, 1) I didn't get why do we need fprintf(Loaded/Unloaded extension). It'll break all the tests in DEBUG mode 2) zend_error() may work through

[PHP-DEV] opcache windows x64

2013-04-12 Thread Pierre Joye
hi Dmitry, Is there any reason for: http://lxr.php.net/xref/PHP_5_5/ext/opcache/shared_alloc_win32.c#260 Is it a mistake as it Should PROCESSOR_ARCHITECTURE_AMD64 or PROCESSOR_ARCHITECTURE_INTEL? Or is x64 actually not supported? If yes, what are the reasons? Thanks! Cheers, -- Pierre

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread Pierrick Charron
+1 On 12 April 2013 04:07, Johannes Schlüter johan...@schlueters.de wrote: On Fri, 2013-04-12 at 10:00 +0200, Julien Pauli wrote: On Fri, Apr 12, 2013 at 1:34 AM, Kalle Sommer Nielsen ka...@php.net wrote: Hi 2013/4/12 Pierre Joye pierre@gmail.com: On Thu, Apr 11, 2013 at

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread David Soria Parra
On 2013-04-12, Johannes Schl�ter johan...@schlueters.de wrote: 5.3 users might depend on some part of the behavior and have learned to live with bugs. We shouldn't kick features at this stage. curlwrappers should definatly stay in 5.3 and 5.4. I have no problem with having them removed in 5.5

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread Julien Pauli
On Fri, Apr 12, 2013 at 4:09 PM, David Soria Parra d...@php.net wrote: On 2013-04-12, Johannes Schlüter johan...@schlueters.de wrote: 5.3 users might depend on some part of the behavior and have learned to live with bugs. We shouldn't kick features at this stage. curlwrappers should

[PHP-DEV] Re: opcache windows x64

2013-04-12 Thread Jan Ehrhardt
Pierre Joye in php.internals (Fri, 12 Apr 2013 14:31:38 +0200): Is there any reason for: http://lxr.php.net/xref/PHP_5_5/ext/opcache/shared_alloc_win32.c#260 Is it a mistake as it Should PROCESSOR_ARCHITECTURE_AMD64 or PROCESSOR_ARCHITECTURE_INTEL? Or is x64 actually not supported? If yes, what

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread Stas Malyshev
Hi! 5.3 users might depend on some part of the behavior and have learned to live with bugs. We shouldn't kick features at this stage. I agree, for 5.4 too. We had it for a long time, and however buggy or broken it is, there might be people that use it, and stable version implies promise they

Re: [PHP-DEV] OPcache optimizer improvement in PHP-5.5?

2013-04-12 Thread Stas Malyshev
Hi! I don't think this is a safe optimization. In the following case it would output 'b' and not 'a' which is the correct result: a.php: ?php define('FOO', 'a'); include('b.php'); ? b.php: ?php define('FOO', 'b'); echo FOO; ? It is certainly not likely for a constant to be

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread Hannes Magnusson
On Fri, Apr 12, 2013 at 2:00 PM, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! 5.3 users might depend on some part of the behavior and have learned to live with bugs. We shouldn't kick features at this stage. I agree, for 5.4 too. We had it for a long time, and however buggy or broken it

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread Stas Malyshev
Hi! I don't know who suggested getting rid of it in 5.3 or 5.4, that is ofcourse seriously stupid thing to do. The original request was to kill it dead in 5.5, and remove the constant again from 5.3 and 5.4. OK, I agree with that. I think origination of this was Pierre's comment to apply

Re: [PHP-DEV] OPcache optimizer improvement in PHP-5.5?

2013-04-12 Thread Stas Malyshev
Hi! I may commit it into master and pecl, but it means that pecl branch is going to be ahead of PHP-5.5. In general, I think there's no harm in trying out new stuff on PECL - and marking those as alpha/beta initially - pecl has a mechanism to choose if you want only stable or also bleeding