Re: [PHP-DEV] DateInterval bug

2015-04-14 Thread Peter Lind
On 13 April 2015 at 22:20, Derick Rethans der...@php.net wrote: On Sun, 12 Apr 2015, Peter Lind wrote: Hi, I wanted to get into PHP code development so I grabbed a random bug from bugs.php.net. Which turned out to be https://bugs.php.net/bug.php?id=69378 The problem the bug report

Re: [PHP-DEV] JSON float number as string

2015-04-14 Thread Alexey Zakhlestin
On 14 Apr 2015, at 07:31, Alexey Zakhlestin indey...@gmail.com wrote: Feels a bit hackish I think it is possible to introduce an overall better solution We can expose result of json-tokenizing as a tree of objects: JSON\Object JSON\Array JSON\String JSON\Number JSON\False

Re: [PHP-DEV] DateInterval bug

2015-04-14 Thread Peter Lind
On 13 April 2015 at 22:20, Derick Rethans der...@php.net wrote: On Sun, 12 Apr 2015, Peter Lind wrote: Hi, I wanted to get into PHP code development so I grabbed a random bug from bugs.php.net. Which turned out to be https://bugs.php.net/bug.php?id=69378 The problem the bug report

Re: [PHP-DEV] DateInterval bug

2015-04-14 Thread Andreas Heigl
Hi All. Am 14.04.15 um 08:38 schrieb Peter Lind: On 13 April 2015 at 22:20, Derick Rethans der...@php.net wrote: On Sun, 12 Apr 2015, Peter Lind wrote: Hi, I wanted to get into PHP code development so I grabbed a random bug from bugs.php.net. Which turned out to be

Re: [PHP-DEV] New RFC draft static class constructor

2015-04-14 Thread Johannes Ott
Am 14.04.2015 um 00:16 schrieb Levi Morrison: - IMO, the method should be called when the class is created, just after every parent class and implemented interfaces are created. In general I think static class data and static class constructors are a sign of poorly designed code, which

Re: [PHP-DEV][RFC-DRAFT] New RFC draft static class constructor

2015-04-14 Thread Johannes Ott
As the RFC is still in draft status, I will stop for now answering any issues on the purpose of this RFC. I will now rewrite some things at the draft, and come back to the discussion in this threads after those changes I will focus on the following open issues I have identified during the last

Re: [PHP-DEV] New RFC draft static class constructor

2015-04-14 Thread Johannes Ott
Am 14.04.2015 um 16:33 schrieb Dan Ackroyd: Here is some feedback then: From the RFC: - Trigger for “magic” method call: First call to class, either first call to __construct(...) or first call to any public or protected static method or property of the class I don't think this

[PHP-DEV] PECL install no longer works out of the box

2015-04-14 Thread Hannes Magnusson
Hi Can someone with access to the new pecl box fix the package downloading? It is totally broken apparently. On vanilla FreeBSD 10: $ pecl install memcached No releases available for package pecl.php.net/memcached install failed $ pecl search memcached Connection to `ssl://pecl.php.net:443'

[PHP-DEV] Re: Potential binary search optimization or feature

2015-04-14 Thread Danylo Medinsky
Thanks for the feedback and apologies for the late response. Since my posting and your responses, I began implementing the binary search into array.c. After a couple days of coding and research, I managed to produce this code. HashTable *arr_hash; arr_hash = Z_ARRVAL_P(array); int

Re: [PHP-DEV] Potential binary search optimization or feature

2015-04-14 Thread Danylo Medinsky
Thanks for the feedback and apologies for the late response. Since my posting and your responses, I began implementing the binary search into array.c. After a couple days of coding and research, I managed to produce this code. HashTable *arr_hash; arr_hash = Z_ARRVAL_P(array); int

[PHP-DEV] Re: [PHP-CVS] com php-src: Partial revert of 1a7798c786466977ef8d2bc95b40a435c47c845a that introduced wrong memory access: ext/fileinfo/libmagic/softmagic.c

2015-04-14 Thread Dmitry Stogov
Hi Anatol, two new fileinfo tests provided by Stas reported valgrind errors. they work fine on 5.5 and 5.6. Thanks. Dmitry. On Tue, Apr 14, 2015 at 5:14 PM, Anatol Belski ana...@belski.net wrote: Hi Dmitry, Basically the merge was to upgrade to libmagic 5.22, also several other patches

Re: [PHP-DEV] New RFC draft static class constructor

2015-04-14 Thread Dan Ackroyd
Hi Johannes, On 13 April 2015 at 13:37, Johannes Ott m...@deroetzi.de wrote: Hi, finally I managed to do my first RFC draft. https://wiki.php.net/rfc/static_class_constructor I hope I have done everything correct so far and I'm looking forward to your feedback on it. Here is some

Re: [PHP-DEV] New RFC draft static class constructor

2015-04-14 Thread Jakub Kubíček
I would rather appreciate run-time class properties initialization. Best regards, Kubo2 2015-04-13 15:37 GMT+02:00 Johannes Ott m...@deroetzi.de: Hi, finally I managed to do my first RFC draft. https://wiki.php.net/rfc/static_class_constructor I hope I have done everything correct

Re: [PHP-DEV] Fixing bundled extension version mess

2015-04-14 Thread Kris Craig
On Tue, Apr 14, 2015 at 7:21 PM, Pierre Joye pierre@gmail.com wrote: hi, We tried that many times but we fail to handle the version of bundled extensions. Along with some installer work and other integration (projects dependencies management, composer or other), we need to find a way

Re: [PHP-DEV] Fixing bundled extension version mess

2015-04-14 Thread christopher jones
On 4/14/15 7:21 PM, Pierre Joye wrote: hi, We tried that many times but we fail to handle the version of bundled extensions. Along with some installer work and other integration (projects dependencies management, composer or other), we need to find a way to get rid of this problem. What do

[PHP-DEV] Fixing bundled extension version mess

2015-04-14 Thread Pierre Joye
hi, We tried that many times but we fail to handle the version of bundled extensions. Along with some installer work and other integration (projects dependencies management, composer or other), we need to find a way to get rid of this problem. What do you think to simply use the PHP version

Re: [PHP-DEV] Fixing bundled extension version mess

2015-04-14 Thread Xinchen Hui
Hey: Sent from my iPhone On Apr 15, 2015, at 10:21 AM, Pierre Joye pierre@gmail.com wrote: hi, We tried that many times but we fail to handle the version of bundled extensions. Along with some installer work and other integration (projects dependencies management, composer or

Re: [PHP-DEV] Fixing bundled extension version mess

2015-04-14 Thread Pierre Joye
On Wed, Apr 15, 2015 at 10:51 AM, christopher jones christopher.jo...@oracle.com wrote: On 4/14/15 7:21 PM, Pierre Joye wrote: hi, We tried that many times but we fail to handle the version of bundled extensions. Along with some installer work and other integration (projects

Re: [PHP-DEV] New RFC draft static class constructor

2015-04-14 Thread Dan Ackroyd
On 14 April 2015 at 17:39, Johannes Ott m...@deroetzi.de wrote: Am 14.04.2015 um 16:33 schrieb Dan Ackroyd: Here is some feedback then: Johannes Ott wrote: But in the new draft (v0.4) I'm preparing at the moment I'll try to formulate the trigger first call more common by comparing it to the

Re: [PHP-DEV] Re: Potential binary search optimization or feature

2015-04-14 Thread Yasuo Ohgaki
Hi Danylo, On Wed, Apr 15, 2015 at 3:23 AM, Danylo Medinsky medinsk...@gmail.com wrote: Thanks for the feedback and apologies for the late response. Since my posting and your responses, I began implementing the binary search into array.c. After a couple days of coding and research, I managed

Re: [PHP-DEV] New RFC draft static class constructor

2015-04-14 Thread Johannes Schlüter
On Tue, 2015-04-14 at 11:49 +0200, Johannes Ott wrote: Am 14.04.2015 um 00:16 schrieb Levi Morrison: - IMO, the method should be called when the class is created, just after every parent class and implemented interfaces are created. In general I think static class data and static class

Re: [PHP-DEV] Re: Potential binary search optimization or feature

2015-04-14 Thread Patrick Schaaf
Am 14.04.2015 20:24 schrieb Danylo Medinsky medinsk...@gmail.com: ... until I can determine how much performance will be compromised from the sorting. Sorting at least has to look at each array element once, and execute the comparison function once. Compare that to a searching scan, which can