Re: [PHP-DEV] Re: [RFC] [Concept] Class Constant visibility modifiers in PHP 7.1+

2015-09-07 Thread Sean DuBois
On Sun, Sep 06, 2015 at 06:47:56PM +0100, Andrea Faulds wrote: > Hi Sean, > > Sean DuBois wrote: > > > >I am starting this discussion to get peoples opinion on the overall feature, > >and find someone > >who would be interested in watching over my progress and making sure I > >do the right things

Re: [PHP-DEV] Re: [RFC] [Concept] Class Constant visibility modifiers in PHP 7.1+

2015-09-07 Thread Stanislav Malyshev
Hi! > Funny you should propose this now, I was wanting this feature just the > other day. This would be a useful addition, and clean up a strange > inconsistency: why can methods and properties have visibility modifiers, > but not constants? Private and protected methods and properties are

AW: [PHP-DEV] [RFC] [Discussion] Short Closures

2015-09-07 Thread Robert Stoll
Hi Bob > -Ursprüngliche Nachricht- > Von: Bob Weinand [mailto:bobw...@hotmail.com] > Gesendet: Montag, 31. August 2015 21:29 > An: PHP Internals > Betreff: [PHP-DEV] [RFC] [Discussion] Short Closures > > I had this RFC in draft since some time, but delayed it due to all the > ongoing

[PHP-DEV] Benchmark Results for PHP Master 2015-09-07

2015-09-07 Thread lp_benchmark_robot
Results for project php-src-nightly, build date 2015-09-07 05:00:00+03:00 commit: aa352a34fd1077995ec159ba30a6cf62c70e64c7 revision_date: 2015-09-07 04:55:08+09:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] Re: [RFC] [Discussion] Short Closures

2015-09-07 Thread Marco Pivetta
On 7 September 2015 at 06:33, Pavel Kouřil wrote: > Hello, > > these are all good points. > > Also, I realized it's definitely harder to write ~ than =. On my > keyboard layout (Czech Qwerty) I have to do "right alt + shift + (key > above Tab)". I'm not sure how it is with

Re: [PHP-DEV] Re: [RFC] [Concept] Class Constant visibility modifiers in PHP 7.1+

2015-09-07 Thread Joe Watkins
> However, I have hard time seeing how that would apply to constants I don't see what their not changing has to do with their visibility. It's not hard to see a legitimate use case for private constants, a case that springs to mind is where you use a public bitmask for some configuration option

AW: [PHP-DEV] Re: [RFC] [Concept] Class Constant visibility modifiers in PHP 7.1+

2015-09-07 Thread Robert Stoll
Hi Stas > -Ursprüngliche Nachricht- > Von: Joe Watkins [mailto:pthre...@pthreads.org] > Gesendet: Montag, 7. September 2015 09:15 > An: Stanislav Malyshev > Cc: PHP internals > Betreff: Re: [PHP-DEV] Re: [RFC] [Concept] Class Constant visibility > modifiers in PHP 7.1+ > > > However, I

Re: [PHP-DEV] Re: [RFC] [Concept] Class Constant visibility modifiers in PHP 7.1+

2015-09-07 Thread Ryan Pallas
On Mon, Sep 7, 2015 at 6:24 AM, Ryan Pallas wrote: > > > On Mon, Sep 7, 2015 at 1:02 AM, Stanislav Malyshev > wrote: > >> Hi! >> >> > Funny you should propose this now, I was wanting this feature just the >> > other day. This would be a useful

Re: [PHP-DEV] Generic classes and methods RFC

2015-09-07 Thread Ben Scholzen
Hi, I would love to see generics in PHP, but I have a few questions for your RFC. class Bazz Why did you use this syntax for forcing extending/implementation? I know this is the syntax C# uses, but it doesn't fit PHP. I think it should be "extends" or "implements", because in PHP : has a

Re: [PHP-DEV] Re: Generic classes and methods RFC

2015-09-07 Thread Ben Scholzen
Hello, Hi Ben! Generics are a feature I'd love to see in PHP. I think this RFC could do with a little elaboration, though. Something that's particularly important to me is if it be possible to have default values for type parameters? For example, could I make a class like this? {

Re: [PHP-DEV] Re: [RFC] [Concept] Class Constant visibility modifiers in PHP 7.1+

2015-09-07 Thread Ryan Pallas
On Mon, Sep 7, 2015 at 1:02 AM, Stanislav Malyshev wrote: > Hi! > > > Funny you should propose this now, I was wanting this feature just the > > other day. This would be a useful addition, and clean up a strange > > inconsistency: why can methods and properties have

Re: [PHP-DEV] Generic classes and methods RFC

2015-09-07 Thread Ben Scholzen
Hi, On 05.09.2015 21:48, John LeSueur wrote: Hi Ben, Now that I have substantive questions, including the list :) In the following: class SomeList { public static function fromArray(array $a): SomeList { $list = new SomeList(); $list2 = new SomeList(); return

Re: [PHP-DEV] Re: [RFC] [Discussion] Short Closures

2015-09-07 Thread Rowan Collins
Andrea Faulds wrote on 06/09/2015 22:54: Also, it would be nice if PHP and Hack don't diverge when implementing the same features, unless there's a particularly good reason... it's not very kind to people who use both languages. While I agree with the sentiment of them not diverging, the

Re: AW: [PHP-DEV] [RFC] [Discussion] Short Closures

2015-09-07 Thread S.A.N
I like many the developers of PHP, write JS lot code, very beg you, if you can do syntax in ECMAScript 6 (=>) Thank. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: AW: [PHP-DEV] [RFC] [Discussion] Short Closures

2015-09-07 Thread Nikita Nefedov
On Mon, 07 Sep 2015 11:46:18 +0300, Robert Stoll wrote: Hi Bob -Ursprüngliche Nachricht- Von: Bob Weinand [mailto:bobw...@hotmail.com] Gesendet: Montag, 31. August 2015 21:29 An: PHP Internals Betreff: [PHP-DEV] [RFC] [Discussion] Short Closures I had this RFC in

Re: [PHP-DEV] [RFC] [Discussion] Short Closures

2015-09-07 Thread Rowan Collins
Levi Morrison wrote on 04/09/2015 18:34: Hopefully I've been able to demonstrate that this style of coding is powerful and that the chaining of closures was helpful. Sort of - the chaining is far from self-explanatory, and some of it is still rather artificial. For instance, surely map would

Re: [PHP-DEV] Re: [RFC] [Discussion] Short Closures

2015-09-07 Thread Anthony Ferrara
Rowan On Mon, Sep 7, 2015 at 10:14 PM, Rowan Collins wrote: > Andrea Faulds wrote on 06/09/2015 22:54: >> >> Also, it would be nice if PHP and Hack don't diverge when implementing the >> same features, unless there's a particularly good reason... it's not very >> kind to

Re: [PHP-DEV] Re: [RFC] [Discussion] Short Closures

2015-09-07 Thread Rowan Collins
Anthony Ferrara wrote on 07/09/2015 11:23: Being completely fair, doesn't this actually make HackLang a great test-bed for PHP features? If they implement something, and people hate it/it sucks, boom. But if people love it, it's a no brainer for us to "steal". I don't think we should blindly

Re: [PHP-DEV] RFC Karma for Sean-Der

2015-09-07 Thread Ferenc Kovacs
On Mon, Sep 7, 2015 at 7:27 AM, Joe Watkins wrote: > +1 for Karma ... > > On Sat, Sep 5, 2015 at 6:43 AM, Sean DuBois wrote: > > > Hi, > > > > I am taking over the RFC class constant visibility rfc from Reeze, > > and need the permissions to update it. >

Re: [PHP-DEV] Re: [RFC] [Discussion] Short Closures

2015-09-07 Thread Pavel Kouřil
On Mon, Sep 7, 2015 at 8:24 AM, Marco Pivetta wrote: > > The same usually applies to ~, {, }, [ and ]. > I personally stopped buying non-en_US keyboards and that's it. > Basically, if you code you kinda want to use en_US layout anyway (or dvorak > if you had too much free

Re: [PHP-DEV] PHP 7.1 - Address PHPSadness #28?

2015-09-07 Thread Craig Francis
On 2 Sep 2015, at 13:31, Rowan Collins wrote: > In summary, I don't think any language change is needed here, but > documentation needs to be improved. I will have a go at drafting a new intro > for the isset() page when/if I get time. Maybe... personally I don't

Re: [PHP-DEV] Re: [RFC] [Discussion] Short Closures

2015-09-07 Thread Andrea Faulds
Hi Marco, Marco Pivetta wrote: On 7 September 2015 at 06:33, Pavel Kouřil wrote: Also, I realized it's definitely harder to write ~ than =. On my keyboard layout (Czech Qwerty) I have to do "right alt + shift + (key above Tab)". I'm not sure how it is with other non-US

Re: [PHP-DEV] Re: [RFC] [Discussion] Short Closures

2015-09-07 Thread Andrea Faulds
Hi Anthony, Anthony Ferrara wrote: Being completely fair, doesn't this actually make HackLang a great test-bed for PHP features? If they implement something, and people hate it/it sucks, boom. But if people love it, it's a no brainer for us to "steal". I don't think we should blindly accept

Re: [PHP-DEV] [RFC] [Discussion] Short Closures

2015-09-07 Thread Rowan Collins
Levi Morrison wrote on 07/09/2015 17:56: >Sort of - the chaining is far from self-explanatory, and some of it is still >rather artificial. For instance, surely map would in reality have been a >named function: > >function map($fn) { > return $input ~> { > foreach ($input

Re: [PHP-DEV] [RFC] [Discussion] Short Closures

2015-09-07 Thread Levi Morrison
On Mon, Sep 7, 2015 at 6:22 AM, Rowan Collins wrote: > Levi Morrison wrote on 04/09/2015 18:34: >> >> Hopefully I've been able to demonstrate that this style of coding is >> powerful and that the chaining of closures was helpful. > > > Sort of - the chaining is far from

Re: [PHP-DEV] Re: PDO: Disable emulated prepares by default?

2015-09-07 Thread Ferenc Kovacs
On Mon, Sep 7, 2015 at 1:23 AM, Johannes Schlüter wrote: > On Sun, 2015-09-06 at 18:25 +0100, Andrea Faulds wrote: > > Hi Scott, > > > > Scott Arciszewski wrote: > > > Inspired by http://stackoverflow.com/a/12202218/2224584 > > > > > > Can we (in either PHP 7.0 or in PHP

Re: [PHP-DEV] [RFC] [Discussion] Short Closures

2015-09-07 Thread Rowan Collins
Levi Morrison wrote on 07/09/2015 17:56: function reduce ($initial) ~> $fn ~> $input ~> { $accumulator = $initial; foreach ($input as $value) { $accumulator = $fn($accumulator, $value); } return $accumulator; } Hm, this is an

Re: [PHP-DEV] Re: [RFC] [Concept] Class Constant visibility modifiersin PHP 7.1+

2015-09-07 Thread Andrea Faulds
Hi Stas, Stanislav Malyshev wrote: Private and protected methods and properties are private for a reason - they may be radically changed or gone when the code is changing, and thus external code should not rely on them, and the way to ensure it is to deny that code access to them. However, I

[PHP-DEV] strict-api - Proposing a tool to check and enforce encapsulation

2015-09-07 Thread François Laupretre
Hi, I have written a follow-up to my previous 'zstrict' PR. It is now focused on a simple mechanism to detect API violations : https://github.com/php/php-src/pull/1508 This version just implements the mechanism and applies it to the zend_string val/len/h elements. More details in the PR.

[PHP-DEV] Invalid date/time handling - strtotime()

2015-09-07 Thread Yasuo Ohgaki
Hi Derick and all, strtotime() may be improved. $ php -r "echo date('Y-m-d',strtotime('00-00-00 00:00:00'));" 1999-11-30 because 00 is 2000, 00 month is -1(=12) and 00 date is -1(last date of previous month). This is unintuitive result at a glance. strtotime() handles date/time edge cases and

Re: [PHP-DEV] [RFC] [Discussion] Short Closures

2015-09-07 Thread Sara Golemon
On Sep 6, 2015, at 18:19, Bob Weinand wrote: > Oh, I thought that feature to be Hack-only. Looks like I'm wrong and hence > looked at the wrong place. [I always heard Hack has short Closures, but never > was told HHVM had them too...] Semantics semantics semantics. Short

Re: [PHP-DEV] Re: [RFC] [Concept] Class Constant visibility modifiersin PHP 7.1+

2015-09-07 Thread Xinchen Hui
Hey: On Tue, Sep 8, 2015 at 9:23 AM, Ryan Pallas wrote: > > On Mon, Sep 7, 2015 at 7:11 PM, Xinchen Hui wrote: >> >> >> >> Sent from my iPhone >> >> > On Sep 8, 2015, at 02:09, Andrea Faulds wrote: >> > >> > Hi Stas, >> > >> > Stanislav

Re: [PHP-DEV] Re: [RFC] [Concept] Class Constant visibility modifiersin PHP 7.1+

2015-09-07 Thread Ryan Pallas
On Mon, Sep 7, 2015 at 7:11 PM, Xinchen Hui wrote: > > > Sent from my iPhone > > > On Sep 8, 2015, at 02:09, Andrea Faulds wrote: > > > > Hi Stas, > > > > Stanislav Malyshev wrote: > >> > >> Private and protected methods and properties are private for a reason -

Re: [PHP-DEV] Re: [RFC] [Concept] Class Constant visibility modifiersin PHP 7.1+

2015-09-07 Thread Xinchen Hui
Sent from my iPhone > On Sep 8, 2015, at 02:09, Andrea Faulds wrote: > > Hi Stas, > > Stanislav Malyshev wrote: >> >> Private and protected methods and properties are private for a reason - >> they may be radically changed or gone when the code is changing, and >> thus external

AW: AW: [PHP-DEV] [RFC] [Discussion] Short Closures

2015-09-07 Thread Robert Stoll
> > I would like to see a short syntax for closures in PHP but would > > suggest to use different symbols for the operator. Why not use --> ? > > > > --> is a shift-reduce conflict. It's undecidable if this expression > --> should > return boolean or a closure: > `$foo-->$bar` (is it `$foo -->

Re: [PHP-DEV] [RFC] [Discussion] Short Closures

2015-09-07 Thread Andrea Faulds
Hi Levi, Levi Morrison wrote: If this RFC passes I'd like to see one that builds on it to remove the { return ;} boilerplate of the above definition: function reduce ($initial) ~> $fn ~> $input { $accumulator = $initial; foreach ($input as $value) {

Re: [PHP-DEV] Re: Generic classes and methods RFC

2015-09-07 Thread George Bond
On 7 September 2015 at 11:37, Ben Scholzen wrote: > Hello, > > Hi Ben! >> >> Generics are a feature I'd love to see in PHP. I think this RFC could do >> with a little elaboration, though. >> >> Something that's particularly important to me is if it be possible to >> have

Re: [PHP-DEV] [RFC] [Discussion] Short Closures

2015-09-07 Thread Levi Morrison
> I think a possible improvement might be a generalised syntax, similar to > that used for constants, that lets you use any \Closure object to define a > function or method. Thus: > > function reduce = $initial ~> $fn ~> $input ~> { > // ... > }; I like this but we're getting a

Re: [PHP-DEV] Re: [RFC] [Concept] Class Constant visibility modifiers in PHP 7.1+

2015-09-07 Thread Marc Bennewitz
On 09/07/2015 08:43 AM, Sean DuBois wrote: On Sun, Sep 06, 2015 at 06:47:56PM +0100, Andrea Faulds wrote: Hi Sean, Sean DuBois wrote: I am starting this discussion to get peoples opinion on the overall feature, and find someone who would be interested in watching over my progress and

Re: [PHP-DEV] Re: [RFC] [Discussion] Short Closures

2015-09-07 Thread Stanislav Malyshev
Hi! > Being completely fair, doesn't this actually make HackLang a great > test-bed for PHP features? If they implement something, and people I'm not sure how it can be a testbed for *PHP* features, if they develop them with next to no input from PHP community. At least as far as I know, maybe I