Re: [PHP-DEV] [VOTE] Void Return Type RFC

2015-10-30 Thread Chris Riley
Hi, I'm still not sure why we are using void as the return type and not null. Null matches behaviour, void just adds another keyword without value. ~C On 30 October 2015 at 04:33, Rasmus Lerdorf wrote: > On 10/29/2015 08:55 PM, Stanislav Malyshev wrote: > > Hi! > > > >>

[PHP-DEV] Benchmark Results for PHP Master 2015-10-30

2015-10-30 Thread lp_benchmark_robot
Results for project PHP master, build date 2015-10-30 16:09:08+02:00 commit: 3e89c883bbfc1c67ff356b547046f2d7f7325058 revision date: 2015-10-30 14:53:53+03:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] [VOTE] Void Return Type RFC

2015-10-30 Thread John Bafford
There are two particular semantic advantages of void functions I’m not sure have been brought up. A function that always throws an exception can’t have a return value (and checking for one is also semantically and logically incorrect). Since such a function won’t ever return by normal means,

Re: [PHP-DEV] [VOTE] Void Return Type RFC

2015-10-30 Thread Marcio Almada
Hi, > > That's what I am having issue with. I don't see the case where such > guarantee is useful. If you're not using the return value, why do you > care if it's always null or sometimes null and sometimes baloney > sandwich? If you need always null, you have it: null. You don't need to > use

Re: [PHP-DEV] Password_hash salt generation refactor

2015-10-30 Thread Anthony Ferrara
All, On Tue, Oct 20, 2015 at 11:35 PM, Anatol Belski wrote: > Hi Anthony, > >> -Original Message- >> From: Anthony Ferrara [mailto:ircmax...@gmail.com] >> Sent: Monday, October 19, 2015 1:00 AM >> To: internals@lists.php.net >> Subject: [PHP-DEV] Password_hash salt

RE: [PHP-DEV] Password_hash salt generation refactor

2015-10-30 Thread Anatol Belski
Hi Anthony, > -Original Message- > From: Anthony Ferrara [mailto:ircmax...@gmail.com] > Sent: Friday, October 30, 2015 11:58 AM > To: Anatol Belski > Cc: internals@lists.php.net; Kalle Sommer Nielsen > Subject: Re: [PHP-DEV] Password_hash salt

[PHP-DEV] Make sessions use php_random_bytes in 7.1

2015-10-30 Thread Leigh
Hi all, I would like to refactor session id generation to use our new php_random_bytes API as the single entropy source for session ids, targeting 7.1 Overall this would give a small performance increase to session generation, a large security increase to session generation, and remove some