Re: [PHP-DEV] [RFC] ArrayIterator improvements

2016-11-22 Thread Stephen Reay
Hi, Given that this new method seems closely related to ArrayIterator::seek, I (as a userland developer) would very much expect it to handle error conditions in the same way. In the case of ArrayIterator::seek - it throws an OutOfBoundsException. I don’t see how that isn’t appropriate for

Re: [PHP-DEV] [VOTE] ArrayIterator improvements

2016-11-22 Thread Joe Watkins
Morning Wes, I'm not sure that you justified the inconsistency in error management. Why shouldn't it throw InvalidArgumentException ? Cheers Joe On Tue, Nov 22, 2016 at 10:26 PM, Wes wrote: > Just wanted to save everybody's time. 4 weeks seemed an enormity for that. >

Re: [PHP-DEV] [RFC][DISCUSSION] Object type hint, now with added variance

2016-11-22 Thread Joe Watkins
Morning Dan, I took the liberty of removing the old voting doodle, updating the status on the RFC, and moving to appropriate place on /rfc index. Also, I corrected a typo. LGTM. Cheers Joe On Wed, Nov 23, 2016 at 1:42 AM, Marco Pivetta wrote: > This looks awesome to me:

Re: [PHP-DEV] [RFC][DISCUSSION] Object type hint, now with added variance

2016-11-22 Thread Marco Pivetta
This looks awesome to me: nicely cleaned up!  On 23 Nov 2016 01:52, "Dan Ackroyd" wrote: > Hi, > > This is the reintroduction of the Object Type RFC for discussion. > > There was previously strong feedback from people who would prefer that > the inheritance checks for

Re: [PHP-DEV] [RFC][DISCUSSION] Object type hint, now with added variance

2016-11-22 Thread Levi Morrison
On Tue, Nov 22, 2016 at 5:52 PM, Dan Ackroyd wrote: > Hi, > > This is the reintroduction of the Object Type RFC for discussion. > > There was previously strong feedback from people who would prefer that > the inheritance checks for methods that use object types should be >

[PHP-DEV] [RFC][DISCUSSION] Object type hint, now with added variance

2016-11-22 Thread Dan Ackroyd
Hi, This is the reintroduction of the Object Type RFC for discussion. There was previously strong feedback from people who would prefer that the inheritance checks for methods that use object types should be co/contravariant. This has been added to the RFC.

[PHP-DEV] Re: (New User) Self Introduction

2016-11-22 Thread Christoph M. Becker
Hi Ryan! On 22.11.2016 at 22:25, Ryan Yoosefi wrote: > Hello! I'm interested in joining the PHP RFC wiki so I can contribute to > discussions. There is no need for a Wiki account to join the discussion – just participate on this mailing list (you can subscribe via

Re: [PHP-DEV] [VOTE] ArrayIterator improvements

2016-11-22 Thread Wes
Just wanted to save everybody's time. 4 weeks seemed an enormity for that. But obviously there is no hurry. 2016-11-22 21:34 GMT+01:00 Rowan Collins : > On 22/11/2016 17:32, Wes wrote: > >> Okay. But just for the record, it's about very tiny additions... aren't 4 >>

Re: [PHP-DEV] [RFC] ArrayIterator improvements

2016-11-22 Thread Wes
I have decided to go with that because 1- I'm a fan of using Exceptions (mostly) for exceptional error conditions; between these two public seekKey($key):void throws WhateverException; public seekKey($key):bool; I (by far) prefer the latter. 2- I think it would require a new type of SPL

[PHP-DEV] (New User) Self Introduction

2016-11-22 Thread Ryan Yoosefi
Hello! I'm interested in joining the PHP RFC wiki so I can contribute to discussions. I've been coding with PHP since about 2002, so getting to somewhat participate in core development is really exciting to me :) Cheers Ryan

Re: [PHP-DEV] PHP 7.1.0 GA

2016-11-22 Thread Dennis Clarke
On 11/22/2016 01:36 PM, Joe Watkins wrote: Evening internals, I'm excited to announce that PHP 7.1.0 will be GA on December 1st. It has taken a lot of hard work from a lot of people, so stop whatever you are doing and give those people a round of applause. I am happy to stand up and yell

Re: [PHP-DEV] [RFC] ArrayIterator improvements

2016-11-22 Thread Nikita Popov
On Tue, Nov 22, 2016 at 6:47 PM, Wes wrote: > Greetings again PHPeople, > > I wanted to avoid the discussion for the small improvements I was proposing > thinking it would be acceptable to do so ( > http://news.php.net/php.internals/97118) but apparently I was wrong (sorry >

Re: [PHP-DEV] [VOTE] ArrayIterator improvements

2016-11-22 Thread Rowan Collins
On 22/11/2016 17:32, Wes wrote: Okay. But just for the record, it's about very tiny additions... aren't 4 weeks for that too much? If it's calendar time you're worried about, don't sweat it - the RFC rightly targets 7.2, which won't be released for almost exactly a year. So even if we

Re: [PHP-DEV] PHP 7.1.0 GA

2016-11-22 Thread Ryan Pallas
Great work everyone! Your users appreciate all you do! https://media.giphy.com/media/nEUsjV11iZCPS/giphy.gif On Tue, Nov 22, 2016 at 11:36 AM, Joe Watkins wrote: > Evening internals, > > I'm excited to announce that PHP 7.1.0 will be GA on December 1st. > > It has taken

Re: [PHP-DEV] Wiki Content License

2016-11-22 Thread Levi Morrison
Adding webmasters mailing list as well. On Tue, Nov 22, 2016 at 11:24 AM, Niklas Keller wrote: > Morning Internals, > > I couldn't find any license statement for our wiki content except for a > note on detail pages for media files, but those pages look broken and this >

[PHP-DEV] PHP 7.1.0 GA

2016-11-22 Thread Joe Watkins
Evening internals, I'm excited to announce that PHP 7.1.0 will be GA on December 1st. It has taken a lot of hard work from a lot of people, so stop whatever you are doing and give those people a round of applause. Cheers Joe

[PHP-DEV] Wiki Content License

2016-11-22 Thread Niklas Keller
Morning Internals, I couldn't find any license statement for our wiki content except for a note on detail pages for media files, but those pages look broken and this statement there might not be intended. https://wiki.php.net/_detail/wiki/dokuwiki-128.png?id=wiki%3Asyntax states: > Except where

[PHP-DEV] [RFC] ArrayIterator improvements

2016-11-22 Thread Wes
Greetings again PHPeople, I wanted to avoid the discussion for the small improvements I was proposing thinking it would be acceptable to do so ( http://news.php.net/php.internals/97118) but apparently I was wrong (sorry for that), so here's the discussion thread!

Re: [PHP-DEV] [VOTE] ArrayIterator improvements

2016-11-22 Thread Wes
Okay. But just for the record, it's about very tiny additions... aren't 4 weeks for that too much? Also, in my defense, I'm not the first doing that. I don't remember exactly but there was a RFC about ext/intl it was put straight to votes as it was about small additions. I'm not a internals

Re: [PHP-DEV] [VOTE] ArrayIterator improvements

2016-11-22 Thread Stanislav Malyshev
Hi! > I'm not a internals programmer myself but I have consulted some and they > said proposed features are ok and implementation would be trivial, so I > thought it was ok to do this. Sorry for that. If proposed features are so trivial that they do not warrant any discussion, then there's no

Re: [PHP-DEV] [VOTE] ArrayIterator improvements

2016-11-22 Thread Stanislav Malyshev
Hi! On 11/22/16 9:05 AM, Wes wrote: > Greetings PHPeople, > > I've just started the voting on the RFC at the URL... > > https://wiki.php.net/rfc/arrayiterator-improvements > > ...skipping the discussion period entirely as it's about small additions > and there's (hopefully) not much to discuss

Re: [PHP-DEV] [VOTE] ArrayIterator improvements

2016-11-22 Thread Levi Morrison
On Tue, Nov 22, 2016 at 10:05 AM, Wes wrote: > Greetings PHPeople, > > I've just started the voting on the RFC at the URL... > > https://wiki.php.net/rfc/arrayiterator-improvements > > ...skipping the discussion period entirely as it's about small additions > and there's

[PHP-DEV] [VOTE] ArrayIterator improvements

2016-11-22 Thread Wes
Greetings PHPeople, I've just started the voting on the RFC at the URL... https://wiki.php.net/rfc/arrayiterator-improvements ...skipping the discussion period entirely as it's about small additions and there's (hopefully) not much to discuss about. This is my first RFC, and I hope I'm not

[PHP-DEV] NEUTRAL Benchmark Results for PHP Master 2016-11-22

2016-11-22 Thread lp_benchmark_robot
Results for project PHP master, build date 2016-11-22 06:26:27+02:00 commit: f6e3241 previous commit:51f5973 revision date: 2016-11-22 03:00:44+01:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

RE: [PHP-DEV] [RFC] Abolish 50%+1 Votes

2016-11-22 Thread Zeev Suraski
From: Joe Watkins [mailto:pthre...@pthreads.org] Sent: Sunday, November 20, 2016 3:43 PM To: Zeev Suraski Cc: Kalle Sommer Nielsen ; PHP internals Subject: Re: [PHP-DEV] [RFC] Abolish 50%+1 Votes >Afternoon Zeev, >I am not sure how much