Re: [PHP-DEV] SHA3 is very slow

2017-03-31 Thread Sara Golemon
On Fri, Mar 31, 2017 at 10:12 PM, Yasuo Ohgaki wrote: > I noticed that our SHA-3 is inefficient. > Entirely possible. Feel free to improve it. :D -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] SHA3 is very slow

2017-03-31 Thread Yasuo Ohgaki
Hi all, I noticed that our SHA-3 is inefficient. === Ruby SHA3-256 === [yohgaki@dev ~]$ cat t2.rb #!/usr/bin/env ruby require 'digest/sha2' $i = 100 until $i do Digest::SHA3.hexdigest("abcdedf", 256) $i -= 1 end [yohgaki@dev ~]$ time ruby t2.rb real 0m0.438s user 0m0.216s sys 0m0.222s

Re: [PHP-DEV] [RFC][VOTE] Improve hash_hkdf() parameter

2017-03-31 Thread Yasuo Ohgaki
Hi all, - insecure signature (it ignores strong RFC 5689 recommendation) s/RFC 5689/RFC 5869/ On Sat, Apr 1, 2017 at 11:27 AM, Yasuo Ohgaki wrote: > > Given that the function is live in the wild, massively changing the order >> of things and defaults is an instant red

Re: [PHP-DEV] [RFC][VOTE] Improve hash_hkdf() parameter

2017-03-31 Thread Yasuo Ohgaki
Hi Stephen, On Mon, Mar 27, 2017 at 1:09 PM, Stephen Reay wrote: > > It sounds to me like it is *possible* to currently use hash_hkdf() in a > secure manner, but that you (and some others?) feel the arg order and > default args are not conducive to safe/secure usage. >

[PHP-DEV] UGLY Benchmark Results for PHP Master 2017-03-30

2017-03-31 Thread lp_benchmark_robot
Results for project PHP master, build date 2017-03-30 20:28:39-07:00 commit: e0f68ae previous commit:2b86a89 revision date: 2017-03-31 01:46:57+02:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] Directory separators on Windows

2017-03-31 Thread Fleshgrinder
On 3/31/2017 9:29 PM, Anatol Belski wrote: > I can only link to this  > > http://git.php.net/?p=php-src.git;a=commitdiff;h=ec78507bd46a05f77dbde3fa4091ab4c91e61cad > > the new implementation was consistent but had to be reverted in 7.1 > partially, because of BC, even the use is inappropriate.

[PHP-DEV] Fix for NumberFormatter did not work properly when restored from session

2017-03-31 Thread Andrew Nester
Hello everyone! I’ve been working on fix for following bug: https://bugs.php.net/bug.php?id=74063 As it became clear after discussion under proposed pull request here https://github.com/php/php-src/pull/2378

RE: [PHP-DEV] Directory separators on Windows

2017-03-31 Thread Anatol Belski
> -Original Message- > From: Fleshgrinder [mailto:p...@fleshgrinder.com] > Sent: Friday, March 31, 2017 8:32 PM > To: Anatol Belski ; internals@lists.php.net; Rasmus Schultz > > Subject: Re: [PHP-DEV] Directory separators on Windows > > > $ php71

Re: [PHP-DEV] Directory separators on Windows

2017-03-31 Thread Fleshgrinder
Hey :) On 3/31/2017 7:51 PM, Anatol Belski wrote: > Well, there was slightly more in your msg, thus the response  > Not really: On 3/30/2017 8:05 PM, Fleshgrinder wrote: > Windows and paths is a complicated and lengthy story. > > TL;DR all versions of Windows are able to deal with slashes,

RE: [PHP-DEV] Directory separators on Windows

2017-03-31 Thread Anatol Belski
> -Original Message- > From: Fleshgrinder [mailto:p...@fleshgrinder.com] > Sent: Friday, March 31, 2017 6:29 PM > To: Anatol Belski ; internals@lists.php.net; Rasmus Schultz > > Subject: Re: [PHP-DEV] Directory separators on Windows > > On 3/31/2017

Re: [PHP-DEV] Directory separators on Windows

2017-03-31 Thread Fleshgrinder
On 3/31/2017 12:33 PM, Anatol Belski wrote: > Regarding the path variants support - it's not quite that way. PHP > streams abstract many things, for both simplicity and security. The > current state has historically grown on these two factors. So far I > can tell, the only what we don't support is

Re: [PHP-DEV] PHP 7.2 Release Managers

2017-03-31 Thread Sebastian Bergmann
On 03/28/2017 05:11 PM, Sara Golemon wrote: I keep meaning to have a go at this, and with such inspiring mentors at the ready, there's really no better time than now. +1 :) -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Directory separators on Windows

2017-03-31 Thread S.A.N
> +1 > Can be used, for convert NAMESPACE to filepath in autoload ) > > > function __autoload($path) > { > include convert_seperators($path); > } > > > On Windows, it is what realpath does. > No, realpath() - is not used `include_path` -- PHP Internals - PHP Runtime Development Mailing

RE: [PHP-DEV] Directory separators on Windows

2017-03-31 Thread Anatol Belski
Hi, > -Original Message- > From: Fleshgrinder [mailto:p...@fleshgrinder.com] > Sent: Thursday, March 30, 2017 8:05 PM > To: Rasmus Schultz ; PHP internals > > Subject: Re: [PHP-DEV] Directory separators on Windows > > On 3/30/2017 3:25 PM,

Re: [PHP-DEV] Directory separators on Windows

2017-03-31 Thread Pierre Joye
On Fri, Mar 31, 2017 at 3:32 PM, Rasmus Schultz wrote: > Well, this is the opposite of what I'm asking for, and does not address the > case where paths have been persisted in a file or database and the data > gets accessed from different OS. > > I understand the reasons given

Re: [PHP-DEV] Directory separators on Windows

2017-03-31 Thread Rasmus Schultz
Well, this is the opposite of what I'm asking for, and does not address the case where paths have been persisted in a file or database and the data gets accessed from different OS. I understand the reasons given for not changing this behavior in PHP itself, so maybe we could have a standard