Re: [PHP-DEV] Improvements to openssl_crs_new. Need advice

2018-07-22 Thread Jakub Zelenka
On Thu, Jul 19, 2018 at 9:36 PM, Niklas Keller wrote: > Hey, > > I'd prefer a proper OO API in case we add new features in that area. > It would be nice but it's much more work as it would require quite a bit of changes in all csr functions and to make it consistent with other bits, we should

Re: [PHP-DEV] [VOTE] Same Site Cookie RFC

2018-07-22 Thread Andrey Andreev
Hi again, On Sun, Jul 22, 2018 at 6:47 PM, Pedro Magalhães wrote: > On Sun, Jul 22, 2018 at 1:16 PM Andrey Andreev wrote: >> >> But while I didn't quote that part of your >> message, you did also suggest to apply the same decision to other >> functions and so I am talking about all of them. >>

Re: [PHP-DEV] [VOTE] Same Site Cookie RFC

2018-07-22 Thread Niklas Keller
Am So., 22. Juli 2018 um 18:52 Uhr schrieb Christoph M. Becker : > > On 22.07.2018 at 18:40, Niklas Keller wrote: > > > Am So., 22. Juli 2018 um 18:11 Uhr schrieb Pedro Magalhães > > : > >> > >> On Sun, Jul 22, 2018 at 2:47 PM Niklas Keller wrote: > >> > >>> It'd be great to use an OO approach

Re: [PHP-DEV] [VOTE] Same Site Cookie RFC

2018-07-22 Thread Christoph M. Becker
On 22.07.2018 at 18:40, Niklas Keller wrote: > Am So., 22. Juli 2018 um 18:11 Uhr schrieb Pedro Magalhães : >> >> On Sun, Jul 22, 2018 at 2:47 PM Niklas Keller wrote: >> >>> It'd be great to use an OO approach instead of "magic" array keys, >>> e.g. like this: >>> >>>

Re: [PHP-DEV] [VOTE] Same Site Cookie RFC

2018-07-22 Thread Niklas Keller
Am So., 22. Juli 2018 um 18:11 Uhr schrieb Pedro Magalhães : > > On Sun, Jul 22, 2018 at 2:47 PM Niklas Keller wrote: > > > It'd be great to use an OO approach instead of "magic" array keys, > > e.g. like this: > > > >

Re: [PHP-DEV] [VOTE] Same Site Cookie RFC

2018-07-22 Thread Pedro Magalhães
On Sun, Jul 22, 2018 at 2:47 PM Niklas Keller wrote: > It'd be great to use an OO approach instead of "magic" array keys, > e.g. like this: > > https://github.com/amphp/http/blob/9c0ba2f2ebfae482b3ad7a0475eb3d1f74d87949/src/Cookie/CookieAttributes.php > > Regards, Niklas > Hi, While I do agree

Re: [PHP-DEV] [VOTE] Same Site Cookie RFC

2018-07-22 Thread Pedro Magalhães
On Sun, Jul 22, 2018 at 1:16 PM Andrey Andreev wrote: > Ok, I can see how it can be inconvenient for > session_set_cookie_params(), though calling it "extremely" unfriendly > is some exaggeration IMO. Hi, Right, I may have been a bit overly dramatic. :) > But while I didn't quote that part

Re: [PHP-DEV] [VOTE] Same Site Cookie RFC

2018-07-22 Thread Niklas Keller
Am So., 22. Juli 2018 um 14:16 Uhr schrieb Andrey Andreev : > > Hi, > > On Sun, Jul 22, 2018 at 2:21 AM, Pedro Magalhães wrote: > > On Sat, Jul 21, 2018 at 11:26 PM Andrey Andreev wrote: > >> > >> Yes. > >> > >> All other "options" are actual *cookie attribute* names, as defined by > >> the

Re: [PHP-DEV] Implementation ideas for adding early warning for mis-use of "parent"?

2018-07-22 Thread Levi Morrison
On Sun, Jul 22, 2018 at 2:36 AM Nikita Popov wrote: > > On Sun, Jul 22, 2018 at 2:05 AM, Levi Morrison wrote: >> >> This code the illustrates the issue; it has no errors or warnings: >> >> ```php >> class A { >> function m(): parent { >> return $this; >> } >> } >> ``` >> >> However, if

Re: [PHP-DEV] [VOTE] Same Site Cookie RFC

2018-07-22 Thread Andrey Andreev
Hi, On Sun, Jul 22, 2018 at 2:21 AM, Pedro Magalhães wrote: > On Sat, Jul 21, 2018 at 11:26 PM Andrey Andreev wrote: >> >> Yes. >> >> All other "options" are actual *cookie attribute* names, as defined by >> the various IETF RFCs, while "lifetime" is just a convenient name used >> by PHP. It

Re: [PHP-DEV] [VOTE] Same Site Cookie RFC

2018-07-22 Thread Nikita Popov
On Sun, Jul 22, 2018 at 1:21 AM, Pedro Magalhães wrote: > On Sat, Jul 21, 2018 at 11:26 PM Andrey Andreev wrote: > > > Yes. > > > > All other "options" are actual *cookie attribute* names, as defined by > > the various IETF RFCs, while "lifetime" is just a convenient name used > > by PHP. It

Re: [PHP-DEV] Implementation ideas for adding early warning for mis-use of "parent"?

2018-07-22 Thread Nikita Popov
On Sun, Jul 22, 2018 at 2:05 AM, Levi Morrison wrote: > This code the illustrates the issue; it has no errors or warnings: > > ```php > class A { > function m(): parent { > return $this; > } > } > ``` > > However, if you run the method you will get an error. I want to add a > light