Re: [PHP-DEV] Deprecation ideas for PHP 8

2019-01-30 Thread Peter Kokot
On Wed, 30 Jan 2019 at 20:51, Rowan Collins wrote: > > On 30/01/2019 17:28, Peter Kokot wrote: > > This now also means that PHP is making its inconsistency a fact > > > The inconsistency IS a fact, and has been for more than 20 years. This > isn't some new policy, banning something that used to be

Re: [PHP-DEV] Deprecation ideas for PHP 8

2019-01-30 Thread Rowan Collins
On 30/01/2019 17:28, Peter Kokot wrote: This now also means that PHP is making its inconsistency a fact The inconsistency IS a fact, and has been for more than 20 years. This isn't some new policy, banning something that used to be possible, it's a summary of something that's been discussed

Re: [PHP-DEV] Remove zpp variation tests

2019-01-30 Thread Stanislav Malyshev
Hi! > This test passes a certain set of input values of different types to a > function with a zpp string argument and observes the behavior. Of course, > there are also hundreds of other functions that accept strings through zpp > and the behavior is always going to be the same. This is true for

Re: [PHP-DEV] Deprecation ideas for PHP 8

2019-01-30 Thread Peter Kokot
Hello, On Tue, 22 Jan 2019 at 23:40, Rowan Collins wrote: > > On 22/01/2019 21:27, Midori Koçak wrote: > > Can we also add strange function names without any naming conventions to > > this list > > In short, no. I wish we had an FAQ where we could avoid recapping the > arguments around this, but

Re: [PHP-DEV] Old style constructors in PHP-8

2019-01-30 Thread Nikita Popov
On Wed, Jan 30, 2019 at 4:38 PM Andreas Heigl wrote: > > > Am Mittwoch, den 30.01.2019, 09:30 -0600 schrieb Larry Garfield: > > On Wednesday, January 30, 2019 5:41:45 AM CST Nikita Popov wrote: > > > On Wed, Jan 30, 2019 at 12:11 PM Dmitry Stogov > > > wrote: > > > > Hi, > > > > > > > > > > > >

Re: [PHP-DEV] Old style constructors in PHP-8

2019-01-30 Thread Andreas Heigl
Am Mittwoch, den 30.01.2019, 09:30 -0600 schrieb Larry Garfield: > On Wednesday, January 30, 2019 5:41:45 AM CST Nikita Popov wrote: > > On Wed, Jan 30, 2019 at 12:11 PM Dmitry Stogov > > wrote: > > > Hi, > > > > > > > > > I've just noticed that Wordpress-4.1 on PHP master started > > > silent

Re: [PHP-DEV] Old style constructors in PHP-8

2019-01-30 Thread Larry Garfield
On Wednesday, January 30, 2019 5:41:45 AM CST Nikita Popov wrote: > On Wed, Jan 30, 2019 at 12:11 PM Dmitry Stogov wrote: > > Hi, > > > > > > I've just noticed that Wordpress-4.1 on PHP master started silently > > produce different output. > > > > The problem that PHP master started to ignore o

RE: [PHP-DEV] Simplify license headers

2019-01-30 Thread Derick Rethans
On Mon, 28 Jan 2019, Zeev Suraski wrote: > > > I would like to make two changes to this header: > > > > 1. Change "PHP Version 7" line to just "PHP", to avoid the necessity of > > updating this for > > new major versions. I don't think the version information here is > > particularly useful to

Re: [PHP-DEV] Old style constructors in PHP-8

2019-01-30 Thread Pierre Joye
On Wed, Jan 30, 2019, 6:39 PM Sebastian Bergmann Am 30.01.2019 um 12:15 schrieb Pierre Joye: > > Once officially done, I am sure someone will write code converters as > well. > > The no_php4_constructor fixer of php-cs-fixer has been able to > automatically migrate old-style constructors for years

Re: [PHP-DEV] Old style constructors in PHP-8

2019-01-30 Thread Nikita Popov
On Wed, Jan 30, 2019 at 12:11 PM Dmitry Stogov wrote: > Hi, > > > I've just noticed that Wordpress-4.1 on PHP master started silently > produce different output. > > The problem that PHP master started to ignore old-style constructors. > > They were deprecated in PHP-7 and PHP produced the follow

Re: [PHP-DEV] Old style constructors in PHP-8

2019-01-30 Thread Sebastian Bergmann
Am 30.01.2019 um 12:15 schrieb Pierre Joye: Once officially done, I am sure someone will write code converters as well. The no_php4_constructor fixer of php-cs-fixer has been able to automatically migrate old-style constructors for years. -- PHP Internals - PHP Runtime Development Mailing Li

Re: [PHP-DEV] Remove zpp variation tests

2019-01-30 Thread Gabriel Caruso
Em qua, 30 de jan de 2019 às 07:46, Nikita Popov escreveu: > Hi internals, > > We currently have a large number of zpp "variation" tests, which > essentially only test the behavior of zend_parse_parameters plugged into > different functions. A random example of such a test: > > > https://github.c

[PHP-DEV] Re: Remove zpp variation tests

2019-01-30 Thread Christoph M. Becker
On 30.01.2019 at 10:45, Nikita Popov wrote: > Based on a quick grep I would estimate that we have around 700 of these > tests. We have a hard policy against adding new tests for zpp behavior, but > I would like to get rid of the existing ones as well. They provide > essentially no value, but are a

Re: [PHP-DEV] Old style constructors in PHP-8

2019-01-30 Thread Pierre Joye
On Wed, Jan 30, 2019, 6:11 PM Dmitry Stogov to PHP-8, > > May be, it makes sense to emit fatal error in case of old-style > constructor. > Absolutely yes. It will be painless then to find them and fix accordingly. Once officially done, I am sure someone will write code converters as well. > >

[PHP-DEV] Old style constructors in PHP-8

2019-01-30 Thread Dmitry Stogov
Hi, I've just noticed that Wordpress-4.1 on PHP master started silently produce different output. The problem that PHP master started to ignore old-style constructors. They were deprecated in PHP-7 and PHP produced the following warning Deprecated: Methods with the same name as their class w

[PHP-DEV] [VOTE] Reflection for references

2019-01-30 Thread Nikita Popov
Hi internals, I would like to start the vote on the ReflectionReference RFC: https://wiki.php.net/rfc/reference_reflection The vote ends 2019-02-13 and requires a 2/3 majority to pass. Please see https://externals.io/message/103738 for the discussion thread. Regards, Nikita

[PHP-DEV] Remove zpp variation tests

2019-01-30 Thread Nikita Popov
Hi internals, We currently have a large number of zpp "variation" tests, which essentially only test the behavior of zend_parse_parameters plugged into different functions. A random example of such a test: https://github.com/php/php-src/blob/master/ext/standard/tests/strings/addslashes_variation1

[PHP-DEV] Re: [RFC] New custom object serialization mechanism

2019-01-30 Thread Nikita Popov
On Wed, Jan 30, 2019 at 10:20 AM Nicolas Grekas < nicolas.grekas+...@gmail.com> wrote: > Hi Nikita, > > https://wiki.php.net/rfc/custom_object_serialization >> > > In the RFC, you mention that "Executing arbitrary code in the middle of > unserialization is dangerous and has led to numerous unseria

[PHP-DEV] Re: [RFC] New custom object serialization mechanism

2019-01-30 Thread Nicolas Grekas
Hi Nikita, https://wiki.php.net/rfc/custom_object_serialization > In the RFC, you mention that "Executing arbitrary code in the middle of unserialization is dangerous and has led to numerous unserialize() vulnerabilities in the past. For this reason __wakeup() calls are now delayed until the end

Re: [PHP-DEV] Simplify license headers

2019-01-30 Thread Nikita Popov
On Wed, Jan 30, 2019 at 10:05 AM Zeev Suraski wrote: > > Okay, let's change it to "(c) The PHP Group" then. While that doesn't > make it right, it does remove my main annoyance. > > > Done for master and the 7.4 branch. Thoughts on other versions? > > Zeev > Thanks! I think either way is fine t

RE: [PHP-DEV] Simplify license headers

2019-01-30 Thread Zeev Suraski
> Okay, let's change it to "(c) The PHP Group" then. While that doesn't make it > right, it does remove my main annoyance. Done for master and the 7.4 branch. Thoughts on other versions? Zeev