Re: [PHP-DEV] Revisiting proposal for addition of `get_class_constants()`

2020-06-11 Thread Troy McCabe
Aaand I sent that too hastily...Specifically for question 2 around `ReflectionConstant`, I just noticed `ReflectionClass::getReflectionConstants()` exists...Scratch that question! Sorry! On Thu, Jun 11, 2020 at 11:31 PM Troy McCabe wrote: > > Hey Nikita, > > Thanks for the thoughts. > > > Could

Re: [PHP-DEV] Revisiting proposal for addition of `get_class_constants()`

2020-06-11 Thread Troy McCabe
Hey Nikita, Thanks for the thoughts. > Could you please explain in more detail *why* we should duplicate existing > reflection functionality into free-standing functions? In terms of the *why*, there were three main reasons: 1. It aligns with the addition of the functions referenced in the

Re: [PHP-DEV] New functions `hash_serialize` and `hash_unserialize`?

2020-06-11 Thread Sara Golemon
On Thu, Jun 11, 2020 at 11:59 AM Eddie Kohler wrote: > Thanks for this suggestion. I've updated the implementation to make > HashContext implement Serializable. > > I'd still be grateful for more feedback, or perhaps I should just create > an RFC? > > Be careful what you ask for. :) Overall +1

Re: [PHP-DEV] New functions `hash_serialize` and `hash_unserialize`?

2020-06-11 Thread Christoph M. Becker
On 11.06.2020 at 18:58, Eddie Kohler wrote: > Thanks for this suggestion. I've updated the implementation to make > HashContext implement Serializable. > > I'd still be grateful for more feedback, or perhaps I should just create an > RFC? Not sure if that would need an RFC; maybe just start by

Re: [PHP-DEV][RFC] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2020-06-11 Thread Stanislav Malyshev
Hi! >> a) Character count (at line 456, character 23) >> >> b) Quote either the remainder or the parsed section on the line (MySQL >> quotes the remainder, for example) >> >> c) Quote the whole line with an indicator where the error occurred. I'm >> not sure what the best way to do this would be

Re: [PHP-DEV] Revisiting proposal for addition of `get_class_constants()`

2020-06-11 Thread Nikita Popov
On Wed, Jun 10, 2020 at 6:33 AM Troy McCabe wrote: > Hi All, > > With several functions (`str_contains()`, `str_[starts|ends]_with()`) added > for PHP8 to make things more clear, it feels like a good time to revisit > the multiple requests to add `get_class_constants(string $class): array`. >

Re: [PHP-DEV][RFC] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2020-06-11 Thread Rowan Tommins
On 10/06/2020 22:38, Rowan Tommins wrote: rather than renaming T_PAAMAYIM_NEKUDOTAYIM, we should simply ensure the user never needs to see it. I'd like to clarify this slightly: I should have said "beyond renaming ... we should ensure" - I have no particular objection to changing the

Re: [PHP-DEV] New functions `hash_serialize` and `hash_unserialize`?

2020-06-11 Thread Eddie Kohler
Thanks for this suggestion. I've updated the implementation to make HashContext implement Serializable. I'd still be grateful for more feedback, or perhaps I should just create an RFC? Eddie On Mon, Jun 8, 2020 at 9:28 AM Johannes Schlüter wrote: > On Mon, 2020-06-08 at 09:01 -0400, Eddie

Re: [PHP-DEV][RFC] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2020-06-11 Thread Ben Ramsey
> On Jun 11, 2020, at 04:09, Zeev Suraski wrote: > > > On 11 Jun 2020, at 12:07, Sebastian Bergmann wrote: > > Am 11.06.2020 um 00:13 schrieb Sara Golemon: > Token names shouldn't show up. Everyone is agreeing with that statement. > Universally. Let's fix that problem rather than create

Re: [PHP-DEV] PHP 7.4.7 Released!

2020-06-11 Thread Christoph M. Becker
On 11.06.2020 at 16:47, David Zuelke via internals wrote: > The 7.4.7 release post on php.net links to > http://www.php.net/ChangeLog-7.php#7.4.6 for the changelog. Thanks! That has already been fixed. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To

Re: [PHP-DEV] PHP 7.4.7 Released!

2020-06-11 Thread David Zuelke via internals
The 7.4.7 release post on php.net links to http://www.php.net/ChangeLog-7.php#7.4.6 for the changelog. On Thu, Jun 11, 2020 at 4:16 PM Derick Rethans wrote: > > The PHP development team announces the immediate availability of PHP > 7.4.7. This is a security bug fix release. > > All PHP 7.4 users

[PHP-DEV] PHP 7.4.7 Released!

2020-06-11 Thread Derick Rethans
The PHP development team announces the immediate availability of PHP 7.4.7. This is a security bug fix release. All PHP 7.4 users are encouraged to upgrade to this version. For source downloads of PHP 7.4.7 please visit our downloads page. Windows binaries can be found on the PHP for Windows

[PHP-DEV] Re: VCS Account Request: alexdowad

2020-06-11 Thread PHP Group
VCS Account Approved: alexdowad approved by cmb \o/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] PHP 7.3.19 Released

2020-06-11 Thread Christoph M. Becker
The PHP development team announces the immediate availability of PHP 7.3.19. This is a bug fix release. All PHP 7.3 users are encouraged to upgrade to this version. For source downloads of PHP 7.3.19 please visit our downloads page. Windows binaries can be found on the PHP for Windows site. The

Re: [PHP-DEV][RFC] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2020-06-11 Thread Zeev Suraski
On 11 Jun 2020, at 12:07, Sebastian Bergmann wrote: Am 11.06.2020 um 00:13 schrieb Sara Golemon: Token names shouldn't show up. Everyone is agreeing with that statement. Universally. Let's fix that problem rather than create new ones by not addressing the underlying issue. +1 +1 Zeev

Re: [PHP-DEV][RFC] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2020-06-11 Thread Sebastian Bergmann
Am 11.06.2020 um 00:13 schrieb Sara Golemon: Token names shouldn't show up. Everyone is agreeing with that statement. Universally. Let's fix that problem rather than create new ones by not addressing the underlying issue. +1 -- PHP Internals - PHP Runtime Development Mailing List To

Re: [PHP-DEV][RFC] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2020-06-11 Thread Lynn
On Thu, Jun 11, 2020 at 10:45 AM AllenJB wrote: > > This could be either as: > > a) Character count (at line 456, character 23) > > b) Quote either the remainder or the parsed section on the line (MySQL > quotes the remainder, for example) > > c) Quote the whole line with an indicator where the

Re: [PHP-DEV][RFC] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2020-06-11 Thread AllenJB
On 10/06/2020 16:13, G. P. B. wrote: Greetings PHP internals, Kalle Sommer Nielsen and myself are proposing to rename the T_PAAMAYIM_NEKUDOTAYIM token into the already existing T_DOUBLE_COLON alias, T_PAAMAYIM_NEKUDOTAYIM would then become an alias to T_DOUBLE_COLON. The RFC is located here:

[PHP-DEV] VCS Account Request: alexdowad

2020-06-11 Thread Alex Dowad
Edit/close tickets in the bug tracker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php