Re: [PHP-DEV] [VOTE] noreturn type

2021-03-30 Thread Peter Stalman
Aw, my `terminus` suggestion didn't make it. ☹️ Thanks, Peter

Re: [PHP-DEV] [VOTE] noreturn type

2021-03-30 Thread Matthew Brown
On Tue, 30 Mar 2021 at 12:55, Theodore Brown wrote: > On Tue, Mar 30, 2021 at 10:06 AM Matthew Brown > wrote: > > > Hey everyone! > > > > The vote for adding noreturn is now open: > > > > https://wiki.php.net/rfc/noreturn_type > > > > Voting will run through April 13th > > Hi Matt and Ondrej, >

Re: [PHP-DEV] [RFC] noreturn type

2021-03-30 Thread Ilija Tovilo
Hi Matthew > I like the proposal. I also support the covariance. > > One question though. > The RFC mentions possible future use of "nothing" as a bottom type for > parameters in generics. This makes a lot of sense to me. Even without > generics, it could be used for parameters in abstract methods

Re: [PHP-DEV] [VOTE] noreturn type

2021-03-30 Thread Theodore Brown
On Tue, Mar 30, 2021 at 10:06 AM Matthew Brown wrote: > Hey everyone! > > The vote for adding noreturn is now open: > > https://wiki.php.net/rfc/noreturn_type > > Voting will run through April 13th Hi Matt and Ondrej, Thanks for your work on this RFC. I voted for `never` as the type name bec

Re: [PHP-DEV] Changes to Git commit workflow

2021-03-30 Thread Sara Golemon
On Tue, Mar 30, 2021 at 10:13 AM Christoph M. Becker wrote: > > https://github.com/php/php-src/blob/master/NEWS which is a guaranteed > merge > > conflict between branches. > > Nope, see . :) > > GAME. CHANGED. This message constitutes your EFT

Re: [PHP-DEV] [RFC] noreturn type

2021-03-30 Thread Andreas Hennings
Hello, I like the proposal. I also support the covariance. One question though. The RFC mentions possible future use of "nothing" as a bottom type for parameters in generics. This makes a lot of sense to me. Even without generics, it could be used for parameters in abstract methods. So why not a

Re: [PHP-DEV] Changes to Git commit workflow

2021-03-30 Thread Christoph M. Becker
On 30.03.2021 at 15:50, Sara Golemon wrote: > On Tue, Mar 30, 2021 at 8:34 AM Mike Schinkel wrote: > >> When you speak of NEWS, do you mean this? >> https://github.com/php/web-news >> > Negative. NEWS in all caps invariably refers to > https://github.com/php/php-

[PHP-DEV] [VOTE] noreturn type

2021-03-30 Thread Matthew Brown
Hey everyone! The vote for adding noreturn is now open: https://wiki.php.net/rfc/noreturn_type Voting will run through April 13th Best wishes, Matt and Ondrej

Re: [PHP-DEV] Changes to Git commit workflow

2021-03-30 Thread Sara Golemon
On Tue, Mar 30, 2021 at 9:08 AM Mike Schinkel wrote: > On Mar 30, 2021, at 9:50 AM, Sara Golemon wrote: > > On Tue, Mar 30, 2021 at 8:34 AM Mike Schinkel wrote: > > When you speak of NEWS, do you mean this? > > https://github.com/php/web-news > > > Negative. NE

Re: [PHP-DEV] Changes to Git commit workflow

2021-03-30 Thread Mike Schinkel
> On Mar 30, 2021, at 9:50 AM, Sara Golemon wrote: > > On Tue, Mar 30, 2021 at 8:34 AM Mike Schinkel > wrote: > > When you speak of NEWS, do you mean this? > > https://github.com/php/web-news > >

Re: [PHP-DEV] Changes to Git commit workflow

2021-03-30 Thread G. P. B.
On Tue, 30 Mar 2021 at 14:34, Mike Schinkel wrote: > > > > On Mar 30, 2021, at 8:29 AM, Jakub Zelenka wrote: > > > > > > > > On Tue, Mar 30, 2021 at 1:21 PM Jakub Zelenka bu...@php.net>> wrote: > > > > > > On Tue, Mar 30, 2021 at 12:47 PM Mike Schinkel > wrote: > >

Re: [PHP-DEV] Changes to Git commit workflow

2021-03-30 Thread Sara Golemon
On Tue, Mar 30, 2021 at 8:34 AM Mike Schinkel wrote: > When you speak of NEWS, do you mean this? > https://github.com/php/web-news > Negative. NEWS in all caps invariably refers to https://github.com/php/php-src/blob/master/NEWS which is a guaranteed merge conflic

Re: [PHP-DEV] Changes to Git commit workflow

2021-03-30 Thread Mike Schinkel
> On Mar 30, 2021, at 8:29 AM, Jakub Zelenka wrote: > > > > On Tue, Mar 30, 2021 at 1:21 PM Jakub Zelenka > wrote: > > > On Tue, Mar 30, 2021 at 12:47 PM Mike Schinkel > wrote: > > > > On Mar 30, 2021, at 5:51 AM, Derick Rethans >

Re: [PHP-DEV] Changes to Git commit workflow

2021-03-30 Thread Jakub Zelenka
On Tue, Mar 30, 2021 at 1:21 PM Jakub Zelenka wrote: > > > On Tue, Mar 30, 2021 at 12:47 PM Mike Schinkel > wrote: > >> >> >> > On Mar 30, 2021, at 5:51 AM, Derick Rethans wrote: >> > >> > On 30 March 2021 10:43:41 BST, Max Semenik >> wrote: >> >> On Tue, Mar 30, 2021 at 3:29 AM Stanislav Maly

Re: [PHP-DEV] Changes to Git commit workflow

2021-03-30 Thread Jakub Zelenka
On Tue, Mar 30, 2021 at 12:47 PM Mike Schinkel wrote: > > > > On Mar 30, 2021, at 5:51 AM, Derick Rethans wrote: > > > > On 30 March 2021 10:43:41 BST, Max Semenik > wrote: > >> On Tue, Mar 30, 2021 at 3:29 AM Stanislav Malyshev > >> > >> wrote: > >> > >>> Hi! > >>> > >>> On 3/29/21 4:49 AM, M

Re: [PHP-DEV] Changes to Git commit workflow

2021-03-30 Thread Mike Schinkel
> On Mar 30, 2021, at 5:51 AM, Derick Rethans wrote: > > On 30 March 2021 10:43:41 BST, Max Semenik wrote: >> On Tue, Mar 30, 2021 at 3:29 AM Stanislav Malyshev >> >> wrote: >> >>> Hi! >>> >>> On 3/29/21 4:49 AM, Max Semenik wrote: Would it also make sense if direct pushes (bypassing t

Re: [PHP-DEV] Changes to Git commit workflow

2021-03-30 Thread Derick Rethans
On 30 March 2021 10:43:41 BST, Max Semenik wrote: >On Tue, Mar 30, 2021 at 3:29 AM Stanislav Malyshev > >wrote: > >> Hi! >> >> On 3/29/21 4:49 AM, Max Semenik wrote: >> > Would it also make sense if direct pushes (bypassing the pull >requests >> > system) were disallowed completely? I can see mult

Re: [PHP-DEV] Changes to Git commit workflow

2021-03-30 Thread Max Semenik
On Tue, Mar 30, 2021 at 3:29 AM Stanislav Malyshev wrote: > Hi! > > On 3/29/21 4:49 AM, Max Semenik wrote: > > Would it also make sense if direct pushes (bypassing the pull requests > > system) were disallowed completely? I can see multiple problems with > direct > > pushes: > > This is possible.