Re: [PHP-DEV] [RFC] [Draft] Add RNG extension and deprecate mt_srand()

2021-05-19 Thread Go Kudo
Thanks. Deprecation will be done only to prevent unintended MT state dependent code. We don't plan to go as far as removing the implementation for now. > Firstly, making these functions independent of mt_srand() is a breaking change, so cannot happen until PHP 9.0 at the earliest. To be honest,

Re: [PHP-DEV] [RFC] [Draft] Add RNG extension and deprecate mt_srand()

2021-05-19 Thread Go Kudo
> 1. I'm still not a fan of exposing the algorithms as separate classes in PHP. Their names are confusing and I don't see how exposing them gives any benefits. I would prefer that, like in password_hash, let the user chose the algorithm using a constant then ask for seed as a second argument to

Re: [PHP-DEV] Trait constants

2021-05-19 Thread Guilliam Xavier
On Wed, May 12, 2021 at 12:22 PM Stephen Reay wrote: > > Any thoughts on > https://github.com/stephenreay/php-rfcs/blob/master/trait-constants.md ? > Hi Stephen, I agree with what has already been said, i.e.: that's a desirable feature, but probably needs a proper RFC for more discussion.

Re: [PHP-DEV] [RFC] [Draft] Add RNG extension and deprecate mt_srand()

2021-05-19 Thread Guilliam Xavier
On Tue, May 18, 2021 at 6:19 PM Go Kudo wrote: > Hello internals. > > I have created a draft of the RFC. > > https://wiki.php.net/rfc/rng_extension > Hello Go Kudo, First of all, thank you for the (re)work. I think the API looks better, but I still have some remarks/questions (roughly in

[PHP-DEV] [RFC] [Vote] Final constants

2021-05-19 Thread Máté Kocsis
Hi Internals, 2 weeks of discussion period has passed, so I'm opening the vote. RFC link: https://wiki.php.net/rfc/final_class_const, previous threads: https://externals.io/message/114066, https://externals.io/message/114273 The vote will be closed on 2021-06-02. Regards: Máté