RE: [PHP-DEV] [RFC] <> Attribute

2020-05-08 Thread CHU Zhaowei
en the deprecated message will come up. But for the methods/functions this is missing. I think it would be better if you make it more clear. Thanks, CHU Zhaowei -Original Message- From: Benjamin Eberlei Sent: Thursday, May 7, 2020 3:22 PM To: PHP Internals Subject: [PHP-DEV] [RFC]

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Nicolas Grekas
> > https://wiki.php.net/rfc/deprecated_attribute Thanks for the RFC. Why didn't you mention support for deprecating classes/interfaces/traits themselves? If there is a reason, it should be in the RFC at least to me. > > It feels complicated to me, because there are so many entry points to a >

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Benjamin Eberlei
On Thu, May 7, 2020 at 12:43 PM Nicolas Grekas wrote: > Hi Benjamin, > > https://wiki.php.net/rfc/deprecated_attribute > > > Thanks for the RFC. > Why didn't you mention support for deprecating classes/interfaces/traits > themselves? > If there is a reason, it should be in the RFC at least to

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Nicolas Grekas
Hi Benjamin, https://wiki.php.net/rfc/deprecated_attribute Thanks for the RFC. Why didn't you mention support for deprecating classes/interfaces/traits themselves? If there is a reason, it should be in the RFC at least to me. - all other languages with Attributes/Annotations support have it as

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Benjamin Eberlei
On Thu, May 7, 2020 at 10:54 AM Marco Pivetta wrote: > Hey Benjamin, > > On Thu, May 7, 2020, 10:42 Benjamin Eberlei wrote: > >> >> This attribute is "reflected" by the engine during compilation, userland >> doesn't have to reflect it again itself. on a code level the engine >> "patches" each

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Côme Chilliet
This is a really good proposal. I did not participate in the attribute discussion/vote as I do not really understand what attributes are and what they are good for. Having this kind of examples in core will help a lot, and is useful too (I do have functions with only a trigger_error of

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Marco Pivetta
Hey Benjamin, On Thu, May 7, 2020, 10:42 Benjamin Eberlei wrote: > > This attribute is "reflected" by the engine during compilation, userland > doesn't have to reflect it again itself. on a code level the engine > "patches" each function automatically, this would do the following at > compile

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Benjamin Eberlei
On Thu, May 7, 2020 at 10:27 AM Davey Shafik wrote: > > > On Thu, May 7, 2020 at 01:18 Benjamin Eberlei wrote: > >> >> >> On Thu, May 7, 2020 at 10:10 AM Davey Shafik wrote: >> >>> >>> >>> On Thu, May 7, 2020 at 00:22 Benjamin Eberlei >>> wrote: >>> Hi everyone, The attributes

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Davey Shafik
On Thu, May 7, 2020 at 01:18 Benjamin Eberlei wrote: > > > On Thu, May 7, 2020 at 10:10 AM Davey Shafik wrote: > >> >> >> On Thu, May 7, 2020 at 00:22 Benjamin Eberlei >> wrote: >> >>> Hi everyone, >>> >>> The attributes RFC specifically looked into the use of attributes at the >>>

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Benjamin Eberlei
On Thu, May 7, 2020 at 10:10 AM Davey Shafik wrote: > > > On Thu, May 7, 2020 at 00:22 Benjamin Eberlei wrote: > >> Hi everyone, >> >> The attributes RFC specifically looked into the use of attributes at the >> engine/compiler level. >> >> To have a showcase of this with the 8.0 release I want

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Davey Shafik
On Thu, May 7, 2020 at 00:22 Benjamin Eberlei wrote: > Hi everyone, > > The attributes RFC specifically looked into the use of attributes at the > engine/compiler level. > > To have a showcase of this with the 8.0 release I want to propose this RFC > for a <> attribute: > >

[PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Benjamin Eberlei
Hi everyone, The attributes RFC specifically looked into the use of attributes at the engine/compiler level. To have a showcase of this with the 8.0 release I want to propose this RFC for a <> attribute: https://wiki.php.net/rfc/deprecated_attribute <> is the most obvious engine attribute to