Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

Hey: On Wed, Jan 20, 2016 at 7:05 PM, Michael Wallner wrote: > On 08/12/15 10:56, Dmitry Stogov wrote: > > Hi Sean, > > > > The PR has been merged into master. > > Please update the RFC accordingly. > > Thanks to Nikita and Xinchen for code review and suggestions. > > > > > This

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

On 21/01/16 06:36, Xinchen Hui wrote: > Hey: > > On Wed, Jan 20, 2016 at 7:05 PM, Michael Wallner > wrote: > > On 08/12/15 10:56, Dmitry Stogov wrote: > > Hi Sean, > > > > The PR has been merged into master. > > Please update the RFC

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

On 08/12/15 10:56, Dmitry Stogov wrote: > Hi Sean, > > The PR has been merged into master. > Please update the RFC accordingly. > Thanks to Nikita and Xinchen for code review and suggestions. > This patch seems to cause problems for me with registering constants on internal interfaces; see bug

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

Hi Sean, The PR has been merged into master. Please update the RFC accordingly. Thanks to Nikita and Xinchen for code review and suggestions. Thanks. Dmitry. On Mon, Dec 7, 2015 at 11:38 AM, Dmitry Stogov wrote: > Hi Nikita, > > Thanks for code review. > All the reported

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

Hi Nikita, Thanks for code review. All the reported issues should be fixed now. Thanks. Dmitry. On Sat, Dec 5, 2015 at 3:02 AM, Dmitry Stogov wrote: > I've reworked your patch https://github.com/php/php-src/pull/1662 > Actually, you patch was really good. I just re-factored

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

I've reworked your patch https://github.com/php/php-src/pull/1662 Actually, you patch was really good. I just re-factored one base data-structure "mistake" and fixed another obvious mistake in reflection. Anyway, this needs to be re-viewed by others. I'll do it myself on next week :) Thanks.

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

Hi Sean, Although the RFC is accepted, the patch has to be significantly reworked. Probably, it's going to be better and faster if I do it myself. Let me know, if you are agree (I'll do this when I have time, and show you PR before commit). Thanks. Dmitry. On Tue, Oct 20, 2015 at 8:36 PM, Sean

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

Hi Dmitry! Thanks for the quickly reply. That is a bummer that the patch isn't gonna work! But yes, please go ahead and take it on! You don't have to show me the PR (I am happy with what ever you choose to do). There are some tests so once every passes I will be excited to see it merge :) On

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

OK. thanks. I'll try to find time to do this on next week. In any case I'll give a chance to review the future patch. Somebody might get other good improvement ideas and we don't have to hurry now :) Thanks. Dmitry. On Thu, Dec 3, 2015 at 6:46 PM, Sean DuBois wrote: > Hi

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

Le 20/10/2015 19:36, Sean DuBois a écrit : Time for a simple RFC (in theory)! https://wiki.php.net/rfc/class_const_visibility thanks! Hi, After discussing this RFC with other people at AFUP, we are +1. Basically, being able to define constants inside a class, to represent magic-values or

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

Hi Sean, internals, While I support this RFC, it seems that the actual implementation is still under discussion. In particular, whether the RFC is going to allow protected constants in an interface is not clear. In the text of the RFC, on one line it says: "This RFC propose PHP support class

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

> Who decides if/when we should restart voting? I don't believe we've ever formalized that aspect. I know in the past sometimes RFC authors will notice something wrong and fix it, then restart voting themselves. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit:

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

On Wed, Oct 21, 2015 at 03:54:48PM +, Dan Ackroyd wrote: > Hi Sean, internals, > > While I support this RFC, it seems that the actual implementation is > still under discussion. > > In particular, whether the RFC is going to allow protected constants > in an interface is not clear. > > In the

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

On 21 October 2015 at 16:17, Sean DuBois wrote: > > I will update the RFC. Who decides if/when we should restart voting? "The PHP RFC rules is more what you'd call "guidelines" than actual rules" as there are no set decision makers or rules enforcers. The rules set down for

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

On Wed, Oct 21, 2015 at 12:31:58PM -0500, Aaron Piotrowski wrote: > Hi Sean, > > > On Oct 21, 2015, at 11:17 AM, Sean DuBois wrote: > > > > On Wed, Oct 21, 2015 at 03:54:48PM +, Dan Ackroyd wrote: > >> Hi Sean, internals, > >> > >> While I support this RFC, it seems that the

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

Hi Sean, > On Oct 21, 2015, at 11:17 AM, Sean DuBois wrote: > > On Wed, Oct 21, 2015 at 03:54:48PM +, Dan Ackroyd wrote: >> Hi Sean, internals, >> >> While I support this RFC, it seems that the actual implementation is >> still under discussion. >> >> In particular,

[PHP-DEV] [RFC] [VOTE] Class Constant Visibility

Hey list, Time for a simple RFC (in theory)! I would like to add visibility modifiers to class constants, and then as a nice added bonus give more info from the Reflection API (constants now are a dedicated class so nice things like doc comments) https://wiki.php.net/rfc/class_const_visibility