Re: [PHP-DEV] [VOTE] [RFC] Final anonymous classes
Am 03.12.23 um 19:34 schrieb Larry Garfield:
On Sun, Dec 3, 2023, at 10:34 AM, Derick Rethans wrote:
On 3 December 2023 14:49:12 GMT, Nikita Popov wrote:
On Sun, Dec 3, 2023, at 11:40, Daniil Gentili wrote:
Hi all,
I've just opened voting for the final anonymous classes RFC @
https://wiki.php.net/rfc/final_anonymous_classes.
Voting started now, and will run until December 18th 2023, 00:00 GMT.
For the record, I've voted against this proposal because I believe it should
have gone with option 2, that is to *always* make anonymous classes final.
It makes very little sense to me that everyone needs to explicitly mark their anonymous
classes as final just because there is a class_alias loophole that could, in theory, have
been used to extend anonymous classes in the past. Especially given that there is no
evidence of this "feature" being used in the wild (or if there is such
evidence, it was not presented in the proposal).
Regards,
Nikita
I agree with this, and would also say that this RFC is the most thin
one I've seen.
There is no reasoning, or examples, or pretty much anything else in it.
I have also voted no for the same reasons as above. A more fleshed out RFC
that goes default-final (which would then enable the engine optimizations
mentioned) I would probably vote yes for. Though one could debate if that
should be saved for 9.0 just to be safe. (Which I'd also be fine with.)
I also voted NO for the same reason.
But also because I am missing a few things in the RFC.
I am especially missing a reasoning as to why final for anonymous
classes is a thing in the first place. What pain is this RFC adressing?
(Apart from not being able to write `new final class{}`)
Also I'd expect all the relevant information from the discussion to be
in the RFC so that we can figure out what the main points were without
having to dig through Mailinglists or PRs.
Cheers
Andreas
--
,,,
(o o)
+-ooO-(_)-Ooo-+
| Andreas Heigl |
| mailto:andr...@heigl.org N 50°22'59.5" E 08°23'58" |
| https://andreas.heigl.org https://hei.gl/where |
|https://hei.gl/pubkeyandreas |
+-+
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php
Re: [PHP-DEV] [VOTE] [RFC] Final anonymous classes
On Sun, Dec 3, 2023, at 10:34 AM, Derick Rethans wrote: > On 3 December 2023 14:49:12 GMT, Nikita Popov wrote: >>On Sun, Dec 3, 2023, at 11:40, Daniil Gentili wrote: >>> Hi all, >>> >>> I've just opened voting for the final anonymous classes RFC @ >>> https://wiki.php.net/rfc/final_anonymous_classes. >>> >>> Voting started now, and will run until December 18th 2023, 00:00 GMT. >> >>For the record, I've voted against this proposal because I believe it should >>have gone with option 2, that is to *always* make anonymous classes final. >> >>It makes very little sense to me that everyone needs to explicitly mark their >>anonymous classes as final just because there is a class_alias loophole that >>could, in theory, have been used to extend anonymous classes in the past. >>Especially given that there is no evidence of this "feature" being used in >>the wild (or if there is such evidence, it was not presented in the proposal). >> >>Regards, >>Nikita > I agree with this, and would also say that this RFC is the most thin > one I've seen. > > There is no reasoning, or examples, or pretty much anything else in it. I have also voted no for the same reasons as above. A more fleshed out RFC that goes default-final (which would then enable the engine optimizations mentioned) I would probably vote yes for. Though one could debate if that should be saved for 9.0 just to be safe. (Which I'd also be fine with.) --Larry Garfield -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
Re: [PHP-DEV] [VOTE] [RFC] Final anonymous classes
Am 03.12.2023 um 15:49 schrieb Nikita Popov: For the record, I've voted against this proposal because I believe it should have gone with option 2, that is to *always* make anonymous classes final. I voted "no" for exactly the same reason. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
Re: [PHP-DEV] [VOTE] [RFC] Final anonymous classes
On 3 December 2023 14:49:12 GMT, Nikita Popov wrote: >On Sun, Dec 3, 2023, at 11:40, Daniil Gentili wrote: >> Hi all, >> >> I've just opened voting for the final anonymous classes RFC @ >> https://wiki.php.net/rfc/final_anonymous_classes. >> >> Voting started now, and will run until December 18th 2023, 00:00 GMT. > >For the record, I've voted against this proposal because I believe it should >have gone with option 2, that is to *always* make anonymous classes final. > >It makes very little sense to me that everyone needs to explicitly mark their >anonymous classes as final just because there is a class_alias loophole that >could, in theory, have been used to extend anonymous classes in the past. >Especially given that there is no evidence of this "feature" being used in the >wild (or if there is such evidence, it was not presented in the proposal). > >Regards, >Nikita I agree with this, and would also say that this RFC is the most thin one I've seen. There is no reasoning, or examples, or pretty much anything else in it. cheers Derick -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
Re: [PHP-DEV] [VOTE] [RFC] Final anonymous classes
On Sun, Dec 3, 2023, at 16:05, Nicolas Grekas wrote: > Hello Nikita, > >> > I've just opened voting for the final anonymous classes RFC @ >> > https://wiki.php.net/rfc/final_anonymous_classes. >> > >> > Voting started now, and will run until December 18th 2023, 00:00 GMT. >> >> For the record, I've voted against this proposal because I believe it should >> have gone with option 2, that is to *always* make anonymous classes final. >> >> It makes very little sense to me that everyone needs to explicitly mark >> their anonymous classes as final just because there is a class_alias >> loophole that could, in theory, have been used to extend anonymous classes >> in the past. Especially given that there is no evidence of this "feature" >> being used in the wild (or if there is such evidence, it was not presented >> in the proposal). > > You might have missed my message in the discussion thread, > > see https://externals.io/message/121685#121690 > > There is such evidence (not in the RFC though). Thanks, I did indeed miss this. However, I also don't think that a test-only use is particularly compelling. If this were something that Symfony had exposed as a public API promise, we might be caught between a rock and a hard place, but this thankfully doesn't seem to be the case. I think I can fairly confidently say that the ability to extend anonymous classes by abusing class_alias is a bug in the original implementation, rather than an intentional feature. Yes, people do start to depend on bugs if they exist for long enough, but I don't think this means we shouldn't fix them (within the bounds of pragmatism). Regards, Nikita
Re: [PHP-DEV] [VOTE] [RFC] Final anonymous classes
Hello Nikita, > > I've just opened voting for the final anonymous classes RFC @ > > https://wiki.php.net/rfc/final_anonymous_classes. > > > > Voting started now, and will run until December 18th 2023, 00:00 GMT. > > For the record, I've voted against this proposal because I believe it > should have gone with option 2, that is to *always* make anonymous classes > final. > > It makes very little sense to me that everyone needs to explicitly mark > their anonymous classes as final just because there is a class_alias > loophole that could, in theory, have been used to extend anonymous classes > in the past. Especially given that there is no evidence of this "feature" > being used in the wild (or if there is such evidence, it was not presented > in the proposal). > You might have missed my message in the discussion thread, see https://externals.io/message/121685#121690 There is such evidence (not in the RFC though). Nicolas
Re: [PHP-DEV] [VOTE] [RFC] Final anonymous classes
Hi Nikita, For the record, I've voted against this proposal because I believe it should have gone with option 2, that is to *always* make anonymous classes final. It makes very little sense to me that everyone needs to explicitly mark their anonymous classes as final just because there is a class_alias loophole that could, in theory, have been used to extend anonymous classes in the past. Especially given that there is no evidence of this "feature" being used in the wild (or if there is such evidence, it was not presented in the proposal). Should I amend the RFC, recreating the current poll with three mutually exclusive options (final anonymous classes, final by default without open, final by default with open) instead of just Yes/No (I personally share your PoV, but given the minor pushback received in the last discussion thread I initially decided against it), could that be done without restarting the discussion process? Regards, Daniil Gentili. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
Re: [PHP-DEV] [VOTE] [RFC] Final anonymous classes
On Sun, Dec 3, 2023, at 11:40, Daniil Gentili wrote: > Hi all, > > I've just opened voting for the final anonymous classes RFC @ > https://wiki.php.net/rfc/final_anonymous_classes. > > Voting started now, and will run until December 18th 2023, 00:00 GMT. For the record, I've voted against this proposal because I believe it should have gone with option 2, that is to *always* make anonymous classes final. It makes very little sense to me that everyone needs to explicitly mark their anonymous classes as final just because there is a class_alias loophole that could, in theory, have been used to extend anonymous classes in the past. Especially given that there is no evidence of this "feature" being used in the wild (or if there is such evidence, it was not presented in the proposal). Regards, Nikita
[PHP-DEV] [VOTE] [RFC] Final anonymous classes
Hi all, I've just opened voting for the final anonymous classes RFC @ https://wiki.php.net/rfc/final_anonymous_classes. Voting started now, and will run until December 18th 2023, 00:00 GMT. Regards, Daniil Gentili. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
