Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-26 Thread Larry Garfield
On Fri, Nov 26, 2021, at 3:56 AM, Peter Bowyer wrote: > --- > I get the impression a lot of comments on this mailing list are from people > who know other languages, would like to work with another language, and > since they (have to?) use PHP would like PHP to be another language. > > I find

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-26 Thread Peter Bowyer
On Thu, 25 Nov 2021 at 20:58, Dan Ackroyd wrote: > For the people who are currently voting 'no', I'd ask are you really > sure that the amount of work adding "#[AllowDynamicProperties]" to the > classes you want to keep having dynamic properties is really that much > time compared to the time

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-25 Thread Dan Ackroyd
On Fri, 12 Nov 2021 at 19:00, Matthew Weier O'Phinney wrote: > > Our IDEs, coding standards, and static analysis tools can already flag > these things for us, helping us catch them early. Hell, unit testing will > find these for us, when a test fails due to a value not being set in a > property

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-22 Thread Craig Francis
On Tue, 16 Nov 2021 at 22:21, Sara Golemon wrote: > 1. Do you have code you're responsible for which uses dynamic properties so > broadly that adding this attribute is a burden? > 2. Do you know of real code in widespread use which uses dynamic properties > so broadly that adding this attribute

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-17 Thread Nikita Popov
On Wed, Nov 17, 2021 at 5:35 AM Paul Crovella wrote: > On Fri, Nov 12, 2021 at 5:08 AM Nikita Popov wrote: > > > > Hi internals, > > > > I've opened the vote on > > https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will close > > 2021-11-26. > > > > Regards, > > Nikita > > In the

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-16 Thread Paul Crovella
On Fri, Nov 12, 2021 at 5:08 AM Nikita Popov wrote: > > Hi internals, > > I've opened the vote on > https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will close > 2021-11-26. > > Regards, > Nikita In the Motivation section when talking about static analysis the RFC makes the claim:

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-16 Thread Tobias Nyholm
Thank you Sara! I could not agree more with you. I think this answers to most tweets and messages that I’ve seen the past few weeks. // Tobias > On 16 Nov 2021, at 14:20, Sara Golemon wrote: > > Serious questions for all the folks worried that this is some kind of death > nail for PHP. > >

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-16 Thread Sara Golemon
Serious questions for all the folks worried that this is some kind of death nail for PHP. 1. Do you have code you're responsible for which uses dynamic properties so broadly that adding this attribute is a burden? 2. Do you know of real code in widespread use which uses dynamic properties so

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-16 Thread Larry Garfield
On Tue, Nov 16, 2021, at 7:18 AM, Lynn wrote: > On Tue, Nov 16, 2021 at 1:23 PM Pierre Joye wrote: > >> On Tue, Nov 16, 2021 at 4:11 PM Lynn wrote: >> > What is the point of this change if it's an opt-in? Projects that are >> still relying on dynamic properties today and "have no time" to fix

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-16 Thread Lynn
On Tue, Nov 16, 2021 at 1:23 PM Pierre Joye wrote: > On Tue, Nov 16, 2021 at 4:11 PM Lynn wrote: > > What is the point of this change if it's an opt-in? Projects that are > still relying on dynamic properties today and "have no time" to fix them > now, won't have time in 3 years either. Please

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-16 Thread Pierre Joye
On Tue, Nov 16, 2021 at 4:11 PM Lynn wrote: > > > > On Tue, Nov 16, 2021 at 4:52 AM Pierre Joye wrote: >> >> >> My vote will change to yes as soon as the change is an opt-in instead of an >> opt-out for the 8.x lifetime. >> > > What is the point of this change if it's an opt-in? Projects that

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-16 Thread Lynn
On Tue, Nov 16, 2021 at 4:52 AM Pierre Joye wrote: > > My vote will change to yes as soon as the change is an opt-in instead of an > opt-out for the 8.x lifetime. > > What is the point of this change if it's an opt-in? Projects that are still relying on dynamic properties today and "have no

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-15 Thread Pierre Joye
Hi, On Tue, Nov 16, 2021, 4:40 AM Matthew Brown wrote: > On Fri, 12 Nov 2021 at 08:08, Nikita Popov wrote: > > > Hi internals, > > > > I've opened the vote on > > https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will close > > 2021-11-26. > > > > Regards, > > Nikita > > > > > I

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-15 Thread Matthew Brown
On Mon, 15 Nov 2021 at 17:32, Chase Peeler wrote: > > > On Mon, Nov 15, 2021 at 4:40 PM Matthew Brown > wrote: > > >> I encourage people to vote "yes" on this, if you want PHP to be better at >> preventing people from shooting themselves in the foot. > > > What if I want a language where

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-15 Thread Chase Peeler
On Mon, Nov 15, 2021 at 4:40 PM Matthew Brown wrote: > On Fri, 12 Nov 2021 at 08:08, Nikita Popov wrote: > > > Hi internals, > > > > I've opened the vote on > > https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will close > > 2021-11-26. > > > > Regards, > > Nikita > > > > There are

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-15 Thread Matthew Brown
On Fri, 12 Nov 2021 at 08:08, Nikita Popov wrote: > Hi internals, > > I've opened the vote on > https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will close > 2021-11-26. > > Regards, > Nikita > There are two things developers think about when releasing code: 1. does it work for me

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-14 Thread Pierre Joye
On Sun, Nov 14, 2021, 11:42 PM Rowan Tommins wrote: > On 14/11/2021 11:48, Pierre Joye wrote: > > Also I do see it as a kind of strict mode addition and the depreciation > as > > well could be strict mode only. > > > A quick reminder that PHP has no "strict mode". It has a "strict_types" >

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-14 Thread Rowan Tommins
On 14/11/2021 11:48, Pierre Joye wrote: Also I do see it as a kind of strict mode addition and the depreciation as well could be strict mode only. A quick reminder that PHP has no "strict mode". It has a "strict_types" declaration, which is probably misnamed, and should be something like

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-14 Thread Pierre Joye
Hi Nikita, On Fri, Nov 12, 2021, 11:34 PM Nikita Popov wrote: FWIW I think we should always deprecate things as soon as possible, to give > people the maximum amount of awareness and time to address the issue before > the actual removal occurs. I voted no however I agree on this part, with a

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-13 Thread Claude Pache
> Le 12 nov. 2021 à 17:24, Ben Ramsey a écrit : > > I like this change, but the deprecation in 8.2 seems too disruptive. I’d > rather promote our intent to deprecate this with a statement in the > manual that says something like, “This feature will be deprecated in > PHP 8.3 and removed in

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-13 Thread Victor Bolshov
The way I see it, it might look similar to strict_types opt-in, but only on the surface. The amount of changes needed to make legacy code compliant with strict_types directive, would be tremendous, also there would be no simple one-size-fits-all solution like the #[AllowDynamicProperties]. In

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-13 Thread Peter Bowyer
On Sat, 13 Nov 2021, 00:14 Christoph M. Becker, wrote: > Offering an > opt-out of dynamic properties or some switch to disable the deprecation > would not help in that regard. > Given this is a big change to the way PHP has behaved for decades I did wonder why the RFC didn't propose an opt-out

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Christoph M. Becker
On 12.11.2021 at 23:34, Matthew Weier O'Phinney wrote: > On Fri, Nov 12, 2021, 3:41 PM Larry Garfield wrote: > >> The original version of the RFC would have (as of v9) allowed for the >> removal of some fugly code in property handling, resulting in engine >> improvements and some minor

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Matthew Weier O'Phinney
On Fri, Nov 12, 2021, 3:41 PM Larry Garfield wrote: > On Fri, Nov 12, 2021, at 12:59 PM, Matthew Weier O'Phinney wrote: > > I recognize it's a bit late to be commenting, now that voting has > > started... but this feels like a solution for which we already have > > workable solutions, and which

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Larry Garfield
On Fri, Nov 12, 2021, at 12:59 PM, Matthew Weier O'Phinney wrote: > I recognize it's a bit late to be commenting, now that voting has > started... but this feels like a solution for which we already have > workable solutions, and which will instead lead to a lot of > misunderstanding and breakage

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Matthew Weier O'Phinney
I recognize it's a bit late to be commenting, now that voting has started... but this feels like a solution for which we already have workable solutions, and which will instead lead to a lot of misunderstanding and breakage in the user ecosystem. Our IDEs, coding standards, and static analysis

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Deleu
On Fri, Nov 12, 2021 at 6:47 PM Chase Peeler wrote: > On Fri, Nov 12, 2021 at 12:44 PM Larry Garfield > wrote: > > > On Fri, Nov 12, 2021, at 10:56 AM, Nikita Popov wrote: > > > On Fri, Nov 12, 2021 at 5:34 PM Nikita Popov > > wrote: > > > > > >> On Fri, Nov 12, 2021 at 5:25 PM Ben Ramsey

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Chase Peeler
On Fri, Nov 12, 2021 at 12:44 PM Larry Garfield wrote: > On Fri, Nov 12, 2021, at 10:56 AM, Nikita Popov wrote: > > On Fri, Nov 12, 2021 at 5:34 PM Nikita Popov > wrote: > > > >> On Fri, Nov 12, 2021 at 5:25 PM Ben Ramsey wrote: > >> > >>> > On Nov 12, 2021, at 10:10, Derick Rethans wrote: >

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Larry Garfield
On Fri, Nov 12, 2021, at 10:56 AM, Nikita Popov wrote: > On Fri, Nov 12, 2021 at 5:34 PM Nikita Popov wrote: > >> On Fri, Nov 12, 2021 at 5:25 PM Ben Ramsey wrote: >> >>> > On Nov 12, 2021, at 10:10, Derick Rethans wrote: >>> > >>> > On 12 November 2021 13:07:42 GMT, Nikita Popov >>> wrote:

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Nikita Popov
On Fri, Nov 12, 2021 at 5:34 PM Nikita Popov wrote: > On Fri, Nov 12, 2021 at 5:25 PM Ben Ramsey wrote: > >> > On Nov 12, 2021, at 10:10, Derick Rethans wrote: >> > >> > On 12 November 2021 13:07:42 GMT, Nikita Popov >> wrote: >> >> Hi internals, >> >> >> >> I've opened the vote on >> >>

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Christoph M. Becker
On 12.11.2021 at 17:24, Ben Ramsey wrote: >> On Nov 12, 2021, at 10:10, Derick Rethans wrote: >> >> On 12 November 2021 13:07:42 GMT, Nikita Popov wrote: >>> Hi internals, >>> >>> I've opened the vote on >>> https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will close >>>

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Nikita Popov
On Fri, Nov 12, 2021 at 5:25 PM Ben Ramsey wrote: > > On Nov 12, 2021, at 10:10, Derick Rethans wrote: > > > > On 12 November 2021 13:07:42 GMT, Nikita Popov > wrote: > >> Hi internals, > >> > >> I've opened the vote on > >> https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will >

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Ben Ramsey
> On Nov 12, 2021, at 10:10, Derick Rethans wrote: > > On 12 November 2021 13:07:42 GMT, Nikita Popov wrote: >> Hi internals, >> >> I've opened the vote on >> https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will close >> 2021-11-26. > > I've voted no on this one. Not because I

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Derick Rethans
On 12 November 2021 13:07:42 GMT, Nikita Popov wrote: >Hi internals, > >I've opened the vote on >https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will close >2021-11-26. I've voted no on this one. Not because I don't like the idea, but because I think the timeline for deprecation

[PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Nikita Popov
Hi internals, I've opened the vote on https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will close 2021-11-26. Regards, Nikita