Re: [PHP-DEV] [VOTE] ImmutableIterable (immutable, rewindable, allows any key keys)

2021-06-17 Thread tyson andre
Hi Larry Garfield, Thanks for responding. > While I like the idea of an immutable collection, and the performance boost > seems useful, this proposal seems to go about it in a sloppy way. > > 1) Iterable doesn't seem like the right "family" for this. It is iterable, > but so are lots of

Re: [PHP-DEV] [VOTE] ImmutableIterable (immutable, rewindable, allows any key keys)

2021-06-17 Thread Larry Garfield
On Wed, Jun 16, 2021, at 12:09 PM, Levi Morrison via internals wrote: > > Over half of the objections are to functionality, over half to unspecified > > reasons, > > I support people choosing not to directly respond with their > unspecified reasons, but if anyone is open to sharing I would >

Re: [PHP-DEV] [VOTE] ImmutableIterable (immutable, rewindable, allows any key keys)

2021-06-16 Thread Levi Morrison via internals
> Over half of the objections are to functionality, over half to unspecified > reasons, I support people choosing not to directly respond with their unspecified reasons, but if anyone is open to sharing I would appreciate them doing so. I agree with Nikita that the concept is useful, and with

Re: [PHP-DEV] [VOTE] ImmutableIterable (immutable, rewindable, allows any key keys)

2021-06-16 Thread tyson andre
Hi Nikita, > I like the concept here. I think the naming choice is unfortunate, and > causing confusion for people. > > What you're really proposing here is a data structure: A sequence of > key-value-pairs. That generally seems like a sensible thing to have, in that > we can implement it

Re: [PHP-DEV] [VOTE] ImmutableIterable (immutable, rewindable, allows any key keys)

2021-06-16 Thread Nikita Popov
On Tue, Jun 15, 2021 at 4:01 PM tyson andre wrote: > Hi internals, > > Voting has started on the ImmutableIterable RFC > https://wiki.php.net/rfc/cachediterable > > Previous discussion can be found in https://externals.io/message/114834 > > Recent changes: > - The name was renamed to

Re: [PHP-DEV] [VOTE] ImmutableIterable (immutable, rewindable, allows any key keys)

2021-06-15 Thread Derick Rethans
On 16 June 2021 00:19:14 BST, tyson andre wrote: >> Maybe better use "IterableImmutable" to be more consistent with >"DateTimeImmutable"? > >1. Replies won't show up on list if they aren't sent to >internals@lists.php.net >2. I consider the name DateTimeImmutable a mistake (but one that isn't

Re: [PHP-DEV] [VOTE] ImmutableIterable (immutable, rewindable, allows any key keys)

2021-06-15 Thread tyson andre
Hi Thomas Bley, > Maybe better use "IterableImmutable" to be more consistent with > "DateTimeImmutable"? 1. Replies won't show up on list if they aren't sent to internals@lists.php.net 2. I consider the name DateTimeImmutable a mistake (but one that isn't worth fixing). If it was done from

Re: [PHP-DEV] [VOTE] ImmutableIterable (immutable, rewindable, allows any key keys)

2021-06-15 Thread tyson andre
Hi Marco Pivetta, > I see the RFC as valuable but: > > * `__serialize` and `__unserialize` are out of scope: this depends on the >contents of it, and there's no point in implementing them > * `__set_state` should also not be implemented: `var_export()` like any other >object and it should be

Re: [PHP-DEV] [VOTE] ImmutableIterable (immutable, rewindable, allows any key keys)

2021-06-15 Thread Marco Pivetta
Hey Tyson, On Tue, Jun 15, 2021 at 4:01 PM tyson andre wrote: > Hi internals, > > Voting has started on the ImmutableIterable RFC > https://wiki.php.net/rfc/cachediterable > > Previous discussion can be found in https://externals.io/message/114834 > > Recent

[PHP-DEV] [VOTE] ImmutableIterable (immutable, rewindable, allows any key keys)

2021-06-15 Thread tyson andre
Hi internals, Voting has started on the ImmutableIterable RFC https://wiki.php.net/rfc/cachediterable Previous discussion can be found in https://externals.io/message/114834 Recent changes: - The name was renamed to `ImmutableIterable` to indicate that it cannot be changed after being