Re: [PHP-DEV] [VOTE] Undefined Variable Error Promotion

2022-03-17 Thread Peter Bowyer
On Wed, 16 Mar 2022 at 13:27, Rowan Tommins wrote: > On 15/03/2022 23:02, Patrick ALLAERT wrote: > > This is not far from the reason why I voted "no". > > > > I am not against the fact this warning becomes an error per se. I am just > > not very fan of cherry-picking an individual kind of

Re: [PHP-DEV] [VOTE] Undefined Variable Error Promotion

2022-03-16 Thread Rowan Tommins
On 15/03/2022 23:02, Patrick ALLAERT wrote: This is not far from the reason why I voted "no". I am not against the fact this warning becomes an error per se. I am just not very fan of cherry-picking an individual kind of problem (read: notice/warning/error/...) and changing it without a more

Re: [PHP-DEV] [VOTE] Undefined Variable Error Promotion

2022-03-16 Thread Christian Schneider
Am 16.03.2022 um 11:39 schrieb Mark Randall : > On 16/03/2022 09:17, Christian Schneider wrote: >> Maybe we should ask ourselves the question: Why would the entire package be >> blocked? Just because it is too big or maybe there *are* subtleties which >> have not been properly resolved? > >

Re: [PHP-DEV] [VOTE] Undefined Variable Error Promotion

2022-03-16 Thread Mark Randall
On 16/03/2022 09:17, Christian Schneider wrote: Maybe we should ask ourselves the question: Why would the entire package be blocked? Just because it is too big or maybe there *are* subtleties which have not been properly resolved? It's politics and the practicalities of getting things done.

Re: [PHP-DEV] [VOTE] Undefined Variable Error Promotion

2022-03-16 Thread Christian Schneider
Am 16.03.2022 um 10:00 schrieb Mark Randall : > On 15/03/2022 23:02, Patrick ALLAERT wrote: >> I am not against the fact this warning becomes an error per se. I am just >> not very fan of cherry-picking an individual kind of problem (read: >> notice/warning/error/...) and changing it without a

Re: [PHP-DEV] [VOTE] Undefined Variable Error Promotion

2022-03-16 Thread Mark Randall
On 15/03/2022 23:02, Patrick ALLAERT wrote: I am not against the fact this warning becomes an error per se. I am just not very fan of cherry-picking an individual kind of problem (read: notice/warning/error/...) and changing it without a more global frame. I think we should try to hit all of

Re: [PHP-DEV] [VOTE] Undefined Variable Error Promotion

2022-03-16 Thread Christian Schneider
Am 15.03.2022 um 20:07 schrieb Miguel Rosales : > Christoph M. Becker wrote on 15/3/22 19:17: >> That explicitly excludes undefined array indexes, and apparently also >> excludes undefined properties (which raise "Warning: Undefined property:") >> > AFAIU error promotion for undefined properties

Re: [PHP-DEV] [VOTE] Undefined Variable Error Promotion

2022-03-15 Thread Patrick ALLAERT
Hello Mark and the list, Le mar. 15 mars 2022 à 21:36, Mark Randall a écrit : > Who knows, maybe PHP 9 can be the version that removes remove *all* > warnings from the zend engine. > This is not far from the reason why I voted "no". I am not against the fact this warning becomes an error per

Re: [PHP-DEV] [VOTE] Undefined Variable Error Promotion

2022-03-15 Thread Mark Randall
On 15/03/2022 19:32, Sara Golemon wrote: What I'm hearing is that we also need an RFC for promoting 'Undefined index...' warnings to Errors as well. We do. If it would pass or not is another matter, it would need someone braver than I to take it up. I think there's some other engine

Re: [PHP-DEV] [VOTE] Undefined Variable Error Promotion

2022-03-15 Thread Sara Golemon
On Tue, Mar 15, 2022 at 2:08 PM Miguel Rosales wrote: > > The RFC states: > > > > | If the code does not currently emit a “Warning: Undefined variable > > | $varname” then it is out of scope for this RFC. This RFC does NOT > > | apply to array indexes. > > > > That explicitly excludes undefined

Re: [PHP-DEV] [VOTE] Undefined Variable Error Promotion

2022-03-15 Thread Miguel Rosales
Christoph M. Becker wrote on 15/3/22 19:17: On 15.03.2022 at 17:54, Côme Chilliet wrote: Le lundi 14 mars 2022, 18:18:55 CET Mark Randall a écrit : I have started the vote for promoting undefined variable access to throw an Error exception. The vote will run for 2 weeks until March 28th

Re: [PHP-DEV] [VOTE] Undefined Variable Error Promotion

2022-03-15 Thread Christoph M. Becker
On 15.03.2022 at 17:54, Côme Chilliet wrote: > Le lundi 14 mars 2022, 18:18:55 CET Mark Randall a écrit : > >> I have started the vote for promoting undefined variable access to throw >> an Error exception. >> >> The vote will run for 2 weeks until March 28th 2022. >> >>

Re: [PHP-DEV] [VOTE] Undefined Variable Error Promotion

2022-03-15 Thread Côme Chilliet
Le lundi 14 mars 2022, 18:18:55 CET Mark Randall a écrit : > I have started the vote for promoting undefined variable access to throw > an Error exception. > > The vote will run for 2 weeks until March 28th 2022. > > https://wiki.php.net/rfc/undefined_variable_error_promotion This does not

[PHP-DEV] [VOTE] Undefined Variable Error Promotion

2022-03-14 Thread Mark Randall
I have started the vote for promoting undefined variable access to throw an Error exception. The vote will run for 2 weeks until March 28th 2022. https://wiki.php.net/rfc/undefined_variable_error_promotion Mark Randall -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe,