Re: [PHP-DEV] Consistent indentation for test files

2017-10-30 Thread Sara Golemon
On Sat, Oct 28, 2017 at 7:59 AM, Nikita Popov wrote: > Right now we do not have a consistent standard for the indentation of > PHPT files. > > I would like to propose that we establish a common standard > Not for nothin', but PSR-2 exists. If we adopt *any* standard, I

Re: [PHP-DEV] Consistent indentation for test files

2017-10-30 Thread Derick Rethans
On Sun, 29 Oct 2017, Jakub Zelenka wrote: > On Sat, Oct 28, 2017 at 12:59 PM, Nikita Popov wrote: > > Here are the current statistics for code in .phpt files: > > > > total: 15515 > > prefer tabs: 4273 (27.5%) > > prefer spaces: 6307 (40.7%) > > draw: 77 (0.5%) > > no

Re: [PHP-DEV] Consistent indentation for test files

2017-10-29 Thread Kalle Sommer Nielsen
2017-10-29 22:30 GMT+01:00 Anatol Belski : > Whichever way would be chosen, implementing a pre commit hook would make > sense to be done. To mention, tabs were easier for me, too, but not a big > deal anyway. I'm on the same boat as Anatol here, whatever is choosen is fine with

RE: [PHP-DEV] Consistent indentation for test files

2017-10-29 Thread Anatol Belski
Hi, > -Original Message- > From: jakub@gmail.com [mailto:jakub@gmail.com] On Behalf Of Jakub > Zelenka > Sent: Sunday, October 29, 2017 7:41 PM > To: Nikita Popov <nikita@gmail.com> > Cc: PHP internals <internals@lists.php.net> > Subject: Re:

Re: [PHP-DEV] Consistent indentation for test files

2017-10-29 Thread Jakub Zelenka
On Sat, Oct 28, 2017 at 12:59 PM, Nikita Popov wrote: > Hi internals, > > Right now we do not have a consistent standard for the indentation of PHPT > files. Some people create space-indented files, others create tab-indented > files. Over time, indentation invariably

[PHP-DEV] Consistent indentation for test files

2017-10-28 Thread Nikita Popov
Hi internals, Right now we do not have a consistent standard for the indentation of PHPT files. Some people create space-indented files, others create tab-indented files. Over time, indentation invariably starts to mix, because developers with different indentation settings work on one file.