Re: [PHP-DEV] Dead code [PATCH]

2009-08-27 Thread Patrick ALLAERT
2009/8/25 Johannes Schlüter johan...@schlueters.de: [snip] For 6 I assume one might remove it, especially as it doesn't know about IS_UNICODE. I thought I had enough karma to do it myself. Can someone make it in trunk then? Index: ext/standard/math.c

Re: [PHP-DEV] Dead code

2009-08-25 Thread Johannes Schlüter
Hi, even if no known extension uses it I won't remove it in 5.3 as it is a break of ABI compatibility. For 6 I assume one might remove it, especially as it doesn't know about IS_UNICODE. johannes On Mon, 2009-08-24 at 08:24 +0200, Patrick ALLAERT wrote: Hi list, Apparently, function

[PHP-DEV] Dead code

2009-08-24 Thread Patrick ALLAERT
Hi list, Apparently, function _php_math_basetolong at http://lxr.php.net/source/php-src/ext/standard/math.c#802 isn't used anymore since Mon Sep 3 16:26:31 2001 UTC. It was previously used by bindec, hexdec, octdec and base_convert functions but has been replaced by _php_math_basetozval(). None