Re: [PHP-DEV] FW: [PATCH] Bug #24064: Standard deviation

2004-02-10 Thread Andrey Hristov
Hi Paul, may you compile your PHP binary with --enable-debug and after that run your sample scrit for once. See if there are leaks. Andrey Quoting Paul Hudson [EMAIL PROTECTED]: Er, either the php-internals MARC archive doesn't show all attachments, or my diff file got stripped en

Re: [PHP-DEV] FW: [PATCH] Bug #24064: Standard deviation

2004-02-10 Thread Paul Hudson
Andrey, I compiled with --enable-debug already (but did it again just to make sure). It works fine, with no report of leaks. Did I miss something? Jani: You're absolutely right about the comments; sorry about that! Otherwise, is the patch OK to be committed? Paul -- Quoting

Re: [PHP-DEV] FW: [PATCH] Bug #24064: Standard deviation

2004-02-09 Thread Jani Taskinen
Quickly checked out the patch and first thing to catch my eye was the use of '//' comments. That's a big no-no. (this is not C++) Please read the CODING_STANDARDS couple of times. :) (Use of these C++ comments causes compile failure with some compilers) --Jani