Re: [PHP-DEV] Fix for bug #63437

2013-04-02 Thread Pierre Joye
hi, On Thu, Mar 14, 2013 at 4:32 PM, Anatol Belski a...@php.net wrote: One doubt I have yet after investigating on #62852 is that issuing php_error isn't recoverable, it might be much better to throw exception in __wakeup(), just like __construct() does. This question crosses both #62852

Re: [PHP-DEV] Fix for bug #63437

2013-03-14 Thread Derick Rethans
On Wed, 13 Mar 2013, Anatol Belski wrote: On Mon, 2013-03-11 at 11:42 +, Derick Rethans wrote: On Mon, 11 Mar 2013, Anatol Belski wrote: What is the way you had in the mind to achieve the string-integer conversions? atoll() (or atoq()). Please take a look at the

Re: [PHP-DEV] Fix for bug #63437

2013-03-14 Thread Anatol Belski
On Thu, March 14, 2013 12:42, Derick Rethans wrote: On Wed, 13 Mar 2013, Anatol Belski wrote: On Mon, 2013-03-11 at 11:42 +, Derick Rethans wrote: On Mon, 11 Mar 2013, Anatol Belski wrote: What is the way you had in the mind to achieve the string-integer conversions? atoll() (or

Re: [PHP-DEV] Fix for bug #63437

2013-03-14 Thread Anatol Belski
On Thu, March 14, 2013 14:14, Anatol Belski wrote: On Thu, March 14, 2013 12:42, Derick Rethans wrote: On Wed, 13 Mar 2013, Anatol Belski wrote: On Mon, 2013-03-11 at 11:42 +, Derick Rethans wrote: On Mon, 11 Mar 2013, Anatol Belski wrote: What is the way you had in the mind to

Re: [PHP-DEV] Fix for bug #63437

2013-03-13 Thread Anatol Belski
On Mon, 2013-03-11 at 11:42 +, Derick Rethans wrote: Please, no top posting! On Mon, 11 Mar 2013, Anatol Belski wrote: On Sun, March 10, 2013 23:11, Derick Rethans wrote: On Sat, 9 Mar 2013, Anatol Belski wrote: On Sat, 2013-03-09 at 21:57 +0100, Gustavo Lopes wrote: I

Re: [PHP-DEV] Fix for bug #63437

2013-03-11 Thread Anatol Belski
libgmp was just the first shot as it has functions to convert from arbitrary binary data to string and vice versa, mpz_import and mpz_export. That's what should work fine across platforms. Looking at the type definitions here http://lxr.php.net/xref/PHP_5_5/ext/date/lib/timelib_structs.h#70 i

Re: [PHP-DEV] Fix for bug #63437

2013-03-11 Thread Derick Rethans
Please, no top posting! On Mon, 11 Mar 2013, Anatol Belski wrote: On Sun, March 10, 2013 23:11, Derick Rethans wrote: On Sat, 9 Mar 2013, Anatol Belski wrote: On Sat, 2013-03-09 at 21:57 +0100, Gustavo Lopes wrote: I would agree in principle, but, as I explained before, there is a

Re: [PHP-DEV] Fix for bug #63437

2013-03-10 Thread Derick Rethans
On Sat, 9 Mar 2013, Anatol Belski wrote: On Sat, 2013-03-09 at 21:57 +0100, Gustavo Lopes wrote: On Sat, 09 Mar 2013 21:36:41 +0100, Derick Rethans der...@php.net wrote: On Tue, 5 Mar 2013, Anatol Belski wrote: I've reworked the patch from

Re: [PHP-DEV] Fix for bug #63437

2013-03-09 Thread Derick Rethans
On Tue, 5 Mar 2013, Anatol Belski wrote: I've reworked the patch from http://nebm.ist.utl.pt/~glopes/misc/date_period_interval_ser.diff (mentioned by tony2001) for bug #63437, that seems to fix the issue. That patch was ported back to 5.3 and adapted to the current 5.4+. Both variants

Re: [PHP-DEV] Fix for bug #63437

2013-03-09 Thread Gustavo Lopes
On Sat, 09 Mar 2013 21:36:41 +0100, Derick Rethans der...@php.net wrote: On Tue, 5 Mar 2013, Anatol Belski wrote: I've reworked the patch from http://nebm.ist.utl.pt/~glopes/misc/date_period_interval_ser.diff (mentioned by tony2001) for bug #63437, that seems to fix the issue. That patch was

Re: [PHP-DEV] Fix for bug #63437

2013-03-09 Thread Anatol Belski
Hi, On Sat, 2013-03-09 at 21:57 +0100, Gustavo Lopes wrote: On Sat, 09 Mar 2013 21:36:41 +0100, Derick Rethans der...@php.net wrote: On Tue, 5 Mar 2013, Anatol Belski wrote: I've reworked the patch from http://nebm.ist.utl.pt/~glopes/misc/date_period_interval_ser.diff (mentioned by

Re: [PHP-DEV] Fix for bug #63437

2013-03-09 Thread Derick Rethans
On Sat, 9 Mar 2013, Gustavo Lopes wrote: On Sat, 09 Mar 2013 21:36:41 +0100, Derick Rethans der...@php.net wrote: On Tue, 5 Mar 2013, Anatol Belski wrote: I've reworked the patch from http://nebm.ist.utl.pt/~glopes/misc/date_period_interval_ser.diff (mentioned by tony2001) for

[PHP-DEV] Fix for bug #63437

2013-03-05 Thread Anatol Belski
Hi, I've reworked the patch from http://nebm.ist.utl.pt/~glopes/misc/date_period_interval_ser.diff (mentioned by tony2001) for bug #63437, that seems to fix the issue. That patch was ported back to 5.3 and adapted to the current 5.4+. Both variants are posted to the ticket. Also the test for bug

Re: [PHP-DEV] Fix for bug #63437

2013-03-05 Thread Anatol Belski
Sorry, the correct one is bug #53437 ... On Tue, March 5, 2013 12:42, Anatol Belski wrote: Hi, I've reworked the patch from http://nebm.ist.utl.pt/~glopes/misc/date_period_interval_ser.diff (mentioned by tony2001) for bug #63437, that seems to fix the issue. That patch was ported back to