Re: [PHP-DEV] Improved logarithm of base 2|10 of standard math function

2014-08-20 Thread Marc Bennewitz
On 19.08.2014 00:41, Stas Malyshev wrote: Hi! I opted for master-only on the grounds that while it's an improvement, it's not really a bugfix, and released versions (or versions as near to release as 5.6 is) should be bug-fix only. I know there's an argument for this *being* a bug-fix,

Re: [PHP-DEV] Improved logarithm of base 2|10 of standard math function

2014-08-18 Thread Stas Malyshev
Hi! I opted for master-only on the grounds that while it's an improvement, it's not really a bugfix, and released versions (or versions as near to release as 5.6 is) should be bug-fix only. I know there's an argument for this *being* a bug-fix, but... If a consensus feels it should be

Re: [PHP-DEV] Improved logarithm of base 2|10 of standard math function

2014-08-17 Thread Marc Bennewitz
On 15.08.2014 22:39, Andrea Faulds wrote: On 15 Aug 2014, at 19:57, Marc Bennewitz php@mabe.berlin wrote: Sara, shouldn't it be merged into the branches PHP-5.4, PHP-5.5 as well as PHP-5.6 and shouldn't there an info in the NEWS file? It's currently only merged to master. Marc There

Re: [PHP-DEV] Improved logarithm of base 2|10 of standard math function

2014-08-17 Thread Sara Golemon
On Fri, Aug 15, 2014 at 11:57 AM, Marc Bennewitz php@mabe.berlin wrote: shouldn't it be merged into the branches PHP-5.4, PHP-5.5 as well as PHP-5.6 and shouldn't there an info in the NEWS file? It's currently only merged to master. I opted for master-only on the grounds that while it's an

Re: [PHP-DEV] Improved logarithm of base 2|10 of standard math function

2014-08-16 Thread Marc Bennewitz
On 15.08.2014 22:39, Andrea Faulds wrote: On 15 Aug 2014, at 19:57, Marc Bennewitz php@mabe.berlin wrote: Sara, shouldn't it be merged into the branches PHP-5.4, PHP-5.5 as well as PHP-5.6 and shouldn't there an info in the NEWS file? It's currently only merged to master. Marc There

Re: [PHP-DEV] Improved logarithm of base 2|10 of standard math function

2014-08-16 Thread Pierre Joye
On Sat, Aug 16, 2014 at 12:57 PM, Marc Bennewitz php@mabe.berlin wrote: On 15.08.2014 22:39, Andrea Faulds wrote: On 15 Aug 2014, at 19:57, Marc Bennewitz php@mabe.berlin wrote: Sara, shouldn't it be merged into the branches PHP-5.4, PHP-5.5 as well as PHP-5.6 and shouldn't there an

Re: [PHP-DEV] Improved logarithm of base 2|10 of standard math function

2014-08-15 Thread Marc Bennewitz
Sara, shouldn't it be merged into the branches PHP-5.4, PHP-5.5 as well as PHP-5.6 and shouldn't there an info in the NEWS file? It's currently only merged to master. Marc On 14.08.2014 17:29, Sara Golemon wrote: On Thu, Aug 14, 2014 at 2:44 AM, Marc Bennewitz php@mabe.berlin wrote: forgotten

Re: [PHP-DEV] Improved logarithm of base 2|10 of standard math function

2014-08-15 Thread Andrea Faulds
On 15 Aug 2014, at 19:57, Marc Bennewitz php@mabe.berlin wrote: Sara, shouldn't it be merged into the branches PHP-5.4, PHP-5.5 as well as PHP-5.6 and shouldn't there an info in the NEWS file? It's currently only merged to master. Marc There might be an argument against adding to 5.4

[PHP-DEV] Improved logarithm of base 2|10 of standard math function

2014-08-14 Thread Marc Bennewitz
Hi internals, I have created a PR to improve the base 2 and base 10 of the standard math function log to reduce rounding errors. Internally on log(x, 2) the native C function log2(x) and on log(x, 10) the native C function log10(x) will be called. The PR is open since april without any

Re: [PHP-DEV] Improved logarithm of base 2|10 of standard math function

2014-08-14 Thread Marc Bennewitz
forgotten the link: https://github.com/php/php-src/pull/658 On 14.08.2014 11:43, Marc Bennewitz wrote: Hi internals, I have created a PR to improve the base 2 and base 10 of the standard math function log to reduce rounding errors. Internally on log(x, 2) the native C function log2(x) and on

Re: [PHP-DEV] Improved logarithm of base 2|10 of standard math function

2014-08-14 Thread Sara Golemon
On Thu, Aug 14, 2014 at 2:44 AM, Marc Bennewitz php@mabe.berlin wrote: forgotten the link: https://github.com/php/php-src/pull/658 On 14.08.2014 11:43, Marc Bennewitz wrote: Hi internals, I have created a PR to improve the base 2 and base 10 of the standard math function log to reduce

Re: [PHP-DEV] Improved logarithm of base 2|10 of standard math function

2014-08-14 Thread Marc Bennewitz
On 14.08.2014 17:29, Sara Golemon wrote: On Thu, Aug 14, 2014 at 2:44 AM, Marc Bennewitz php@mabe.berlin wrote: forgotten the link: https://github.com/php/php-src/pull/658 On 14.08.2014 11:43, Marc Bennewitz wrote: Hi internals, I have created a PR to improve the base 2 and base 10 of