Re: [PHP-DEV] Proposal: Rename image functions

2017-11-06 Thread Johannes Schlüter
On So, 2017-11-05 at 20:18 -0500, Michael Morris wrote: > Then, for backward compatibility, add a php.ini setting that runs > "import PHP\Legacy" at the start of each script. We did that mistake with magic_quotes and the ze1 compatibility mode in PHP 5.0. We should learn from that and reduce

Re: [PHP-DEV] Proposal: Rename image functions

2017-11-05 Thread Michael Morris
No. Hell no. The last thing PHP needs is an ill thought out string of function name changes to further pollute the global name space. Further, merely changing the names isn't going to do anything. What would help is a massive clean and redo for PHP 8 in the same vein as Actionscript 2 to 3 had a

Re: [PHP-DEV] Proposal: Rename image functions

2017-11-05 Thread Johannes Schlüter
On So, 2017-11-05 at 14:51 +0100, Peter Kokot wrote: > Hello all, > > correct me if I'm wrong, but wouldn't be a good practice to follow > the > currently set coding standards? > https://github.com/php/php-src/blob/master/CODING_STANDARDS That is good for new code. But breaking 20 years of

Re: [PHP-DEV] Proposal: Rename image functions

2017-11-05 Thread Peter Kokot
Hello all, correct me if I'm wrong, but wouldn't be a good practice to follow the currently set coding standards? https://github.com/php/php-src/blob/master/CODING_STANDARDS Good: 'foo_select_bar' Bad: 'fooinsertbaz' And therefore making aliases for all inconsistently named functions in the

Re: [PHP-DEV] Proposal: Rename image functions

2017-11-04 Thread Stanislav Malyshev
Hi! > Step 1: > I create a patch with the new aliases. I don't see much wrong with old names - nobody remembers those names anyway, and once you use IDE or - for people that still type PHP code by banging two rocks together, like I sometimes do, the manual - it doesn't matter whether there is

Re: [PHP-DEV] Proposal: Rename image functions

2017-11-04 Thread Christoph M. Becker
On 04.11.2017 at 18:39, Rowan Collins wrote: > On 4 November 2017 16:40:56 GMT+00:00, Andreas Treichel > wrote: > >> The only >> exception is image2wbmp which is renamed to image_to_wbmp. > > What is the difference between imagewbmp and image2wbmp? If we're going to >

Re: [PHP-DEV] Proposal: Rename image functions

2017-11-04 Thread Rowan Collins
On 4 November 2017 16:40:56 GMT+00:00, Andreas Treichel wrote: > The only >exception is image2wbmp which is renamed to image_to_wbmp. What is the difference between imagewbmp and image2wbmp? If we're going to rename things, shouldn't that difference be made clearer? Or

[PHP-DEV] Proposal: Rename image functions

2017-11-04 Thread Andreas Treichel
For a better readability of the gd functions I would like to rename them so that they contain underscores to separate the words. The only exception is image2wbmp which is renamed to image_to_wbmp. The order of the parameters of all functions whould be unchanged. Due to the unchanged