Hi Sara, This patch increased the size of resulting PHP code size by 80KB. I know, it's less than 1%, but unfortunately it also affects performance on absolutely unrelated code. This patch leads to increase in iTLB-loads from 17K to 21K on each request to Wordpress home page and as result in slight slowdown. Most probably it's just because we exceeded some CPU specific limit and it may be very dependent on the build, included extensions and CPU model.
Anyway, I ask everyone who adds new features care about code size as well. Sara, if it's not a big problem to compact the code generated for ext/intl/uchar/uchar.c, please, try to do it. As I can see it's mostly because of aggressive macro expansion. Thanks. Dmitry. On Sat, Jan 17, 2015 at 1:37 AM, Sara Golemon <poll...@php.net> wrote: > Commit: ebb60ac7dd179a3bea540d50a7d595010a82a656 > Author: Sara Golemon <poll...@php.net> Mon, 15 Dec 2014 > 14:29:52 -0800 > Committer: Sara Golemon <sgole...@fb.com> Fri, 16 Jan 2015 14:37:44 > -0800 > Parents: 22bb3ce61a895f77178078da4a7e29cb39a532a7 > Branches: master > > Link: > http://git.php.net/?p=php-src.git;a=commitdiff;h=ebb60ac7dd179a3bea540d50a7d595010a82a656 > > Log: > Add IntlChar class to intl extension > > Exposes ICU's uchar functionality as a set of static methods > > Changed paths: > M ext/intl/config.m4 > M ext/intl/config.w32 > M ext/intl/php_intl.c > A ext/intl/uchar/tests/basic-functionality.phpt > A ext/intl/uchar/ublockcode-enum.h > A ext/intl/uchar/uchar.c > A ext/intl/uchar/uchar.h > A ext/intl/uchar/ucharcategory-enum.h > A ext/intl/uchar/uchardirection-enum.h > A ext/intl/uchar/uother-enum.h > A ext/intl/uchar/uproperty-enum.h > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php >
