Re: [PHP-DEV] Re: [PHP-CVS] com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c

2017-11-28 Thread Remi Collet
To summarize current situation libsodium v2.0.9 pecl extension use E_WARNING sodium extension in php-7.2.0 (tag) use E_WARNING (as in previous RCs) sodium extension in PHP-7.2 (branch) use E_WARNING (all changes have been reverted) Seems consistent. For 7.2.0, I don't think we have to change

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c

2017-11-28 Thread Kalle Sommer Nielsen
2017-11-29 0:03 GMT+01:00 Nikita Popov : > In summary, the first two commits combined were not a BC break -- they only > removed a warning and made an error message nicer. After the third commit > we now *do* have a BC break, because what was previously a SodiumException > is

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c

2017-11-28 Thread Nikita Popov
So https://github.com/php/php-src/commit/31d221f9c72f0d0322c84907c5d89a4464667244 landed just now to revert this change, per the request here. This leaves us with the worst variant... so, let's step back a bit: The main commit that landed (for 7.2.1) is

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c

2017-11-28 Thread Jakub Zelenka
On Tue, Nov 28, 2017 at 1:17 PM, Sebastian Bergmann wrote: > Am 28.11.2017 um 13:56 schrieb Frank Denis: > > Commit:c05cbd1e775fa69ed9939796a908390f2bfb4459 > > Author:Frank Denis Tue, 28 Nov 2017 > 13:56:11 +0100 > > Parents:

[PHP-DEV] Re: [PHP-CVS] com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c

2017-11-28 Thread Sebastian Bergmann
Am 28.11.2017 um 13:56 schrieb Frank Denis: > Commit:c05cbd1e775fa69ed9939796a908390f2bfb4459 > Author:Frank Denis Tue, 28 Nov 2017 > 13:56:11 +0100 > Parents: c219991c77e4c68f7d62963e18a1da778de0bbe0 > Branches: PHP-7.2 > > Link: >