[PHP-DEV] Re: [RFC]: fsync function

2021-02-03 Thread David Gebler
RFC ref: https://wiki.php.net/rfc/fsync_function PR ref: https://github.com/php/php-src/pull/6650 I think this one is pretty much good now and passing builds; when I first proposed adding fsync some time ago, there was a suggestion from a couple contributors that an RFC might be

[PHP-DEV] Re: [RFC]: fsync function

2021-02-01 Thread David Gebler
Hi internals, I have updated the GitHub PR and wiki RFC to also include an implementation of fdatasync. On another note, I note my PR builds are failing on MACOS_DEBUG_NTS with a test in ext/zend_test/tests/observer_error_05.phpt- this does not appear to be related to my changes and I'm wondering

[PHP-DEV] Re: [RFC]: fsync function

2021-01-30 Thread David Gebler
Updated the PR https://github.com/php/php-src/pull/6650 following comment from Nikita, added basic tests, would appreciate further review from contributors, have updated the RFC https://wiki.php.net/rfc/fsync_function to under discussion, cheers. David Gebler davidgeb...@gmail.com On Sat, Jan