Re: [PHP-DEV] run-tests SKIPIF caching can be problematic for third-party extensions

2022-02-11 Thread Jeremy Mikola
The reply below is from Sept 24, 2021. I just realized that I inadvertently responded to Nikita dierctly and never shared to the mailing list. Doing so now to close the loop on some open questions and provide more context for a PR I recently opened (https://github.com/php/php-src/pull/8076).

Re: [PHP-DEV] run-tests SKIPIF caching can be problematic for third-party extensions

2021-09-23 Thread Nikita Popov
On Thu, Sep 23, 2021 at 4:10 PM Nikita Popov wrote: > On Wed, Sep 15, 2021 at 7:23 PM Jeremy Mikola wrote: > >> I just discovered that run-tests.php was changed to cache SKIPIF >> evaluation >> since 8.1.0beta3[1]. I believe ext-mongodb ran into the same issue as >> mysqli[2], as we use SKIPIF

Re: [PHP-DEV] run-tests SKIPIF caching can be problematic for third-party extensions

2021-09-23 Thread Nikita Popov
On Wed, Sep 15, 2021 at 7:23 PM Jeremy Mikola wrote: > I just discovered that run-tests.php was changed to cache SKIPIF evaluation > since 8.1.0beta3[1]. I believe ext-mongodb ran into the same issue as > mysqli[2], as we use SKIPIF to check that database contents are clean going > into a test.

Re: [PHP-DEV] run-tests SKIPIF caching can be problematic for third-party extensions

2021-09-15 Thread Jeremy Mikola
On Wed, Sep 15, 2021 at 1:59 PM Sara Golemon wrote: > > If the phpt file outputs "skip nocache" then that will skip without > caching on all versions, won't it? In 8.1 because it has the explicit > 'nocache' provided, and in older versions because they don't cache anyway. > > Am I missing

Re: [PHP-DEV] run-tests SKIPIF caching can be problematic for third-party extensions

2021-09-15 Thread Sara Golemon
On Wed, Sep 15, 2021 at 12:22 PM Jeremy Mikola wrote: > I just discovered that run-tests.php was changed to cache SKIPIF evaluation > since 8.1.0beta3[1]. I believe ext-mongodb ran into the same issue as > mysqli[2], as we use SKIPIF to check that database contents are clean going > into a test.

[PHP-DEV] run-tests SKIPIF caching can be problematic for third-party extensions

2021-09-15 Thread Jeremy Mikola
I just discovered that run-tests.php was changed to cache SKIPIF evaluation since 8.1.0beta3[1]. I believe ext-mongodb ran into the same issue as mysqli[2], as we use SKIPIF to check that database contents are clean going into a test. The present solution in core is to check SKIPIF output for