Re: [PHP-DEV] [RFC] Integrating Zend Optimizer+ into the PHP distribution

2013-02-09 Thread Terry Ellison
Following the discussion at the end of last week, I prepared a draft RFC for the inclusion of Optimizer+ in PHP. In parallel we’re in the process of prepping the source code for independent public consumption, which I hope we can be done with by the end of next week, hopefully sooner.

Re: [PHP-DEV] [RFC] Integrating Zend Optimizer+ into the PHP distribution

2013-02-09 Thread Terry Ellison
On 29/01/13 08:03, Zeev Suraski wrote: Following the discussion at the end of last week, I prepared a draft RFC for the inclusion of Optimizer+ in PHP. In parallel we’re in the process of prepping the source code for independent public consumption, which I hope we can be done with by the end of

[PHP-DEV] double val to long val conversion issue

2013-02-09 Thread Remi Collet
About http://git.php.net/?p=php-src.git;a=commitdiff;h=79956330fe17cfd5f60de456497541b21a89bddf (For now, I have reverted this fix) Here some explanations. LONG_MAX is 9223372036854775807 (0x7fff) double representation of LONG_MAX is 9223372036854775808 (d LONG_MAX) is evaluated in

Re: [PHP-DEV] double val to long val conversion issue

2013-02-09 Thread Remi Collet
Le 09/02/2013 16:10, Remi Collet a écrit : http://git.php.net/?p=php-src.git;a=commitdiff;h=79956330fe17cfd5f60de456497541b21a89bddf Also see https://bugs.php.net/bug.php?id=64142 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] double val to long val conversion issue

2013-02-09 Thread Pierre Joye
hi Remi On Sat, Feb 9, 2013 at 4:10 PM, Remi Collet r...@fedoraproject.org wrote: About http://git.php.net/?p=php-src.git;a=commitdiff;h=79956330fe17cfd5f60de456497541b21a89bddf (For now, I have reverted this fix) Here some explanations. LONG_MAX is 9223372036854775807 (0x7fff)

[PHP-DEV] patch for pdo_stmt and other pdo drivers

2013-02-09 Thread marius adrian popa
I need a review for this patch , it is correct or the right way https://bugs.php.net/bug.php?id=63356 ps: i asked to break the patch in multiple patches so it can be easier to be applied and reviewed -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit:

Re: [PHP-DEV] double val to long val conversion issue

2013-02-09 Thread Terry Ellison
On 09/02/13 15:47, Pierre Joye wrote: hi Remi On Sat, Feb 9, 2013 at 4:10 PM, Remi Collet r...@fedoraproject.org wrote: About http://git.php.net/?p=php-src.git;a=commitdiff;h=79956330fe17cfd5f60de456497541b21a89bddf (For now, I have reverted this fix) Here some explanations. LONG_MAX is

[PHP-DEV] Re: [PHP] Is header() malfunction due to PHP5.3.3 - 5.4.11 transition?

2013-02-09 Thread Adam Richardson
On Sat, Feb 9, 2013 at 3:59 PM, Tedd Sperling t...@sperling.com wrote: On Feb 9, 2013, at 2:00 PM, Jonathan Eagle jeo...@attglobal.net wrote: Jonathan: No offense to your routine, but you may want to review this: http://sperling.com/php/authorization/log-on.php If anyone finds an error,

Re: [PHP-DEV] double val to long val conversion issue

2013-02-09 Thread Stas Malyshev
Hi! these onto the appropriate visualC / gcc types. As far as I can see, PHP doesn't and seems to use long and int almost interchangeably which PHP indeed does not use fixed-size types in zvals, etc. but it definitely does not use long and int almost interchangeably. In almost any place

Re: [PHP-DEV] double val to long val conversion issue

2013-02-09 Thread Stas Malyshev
Hi! About http://git.php.net/?p=php-src.git;a=commitdiff;h=79956330fe17cfd5f60de456497541b21a89bddf (For now, I have reverted this fix) Here some explanations. LONG_MAX is 9223372036854775807 (0x7fff) double representation of LONG_MAX is 9223372036854775808 I see what's

Re: [PHP-DEV] double val to long val conversion issue

2013-02-09 Thread Terry Ellison
On 10/02/13 03:25, Stas Malyshev wrote: these onto the appropriate visualC / gcc types. As far as I can see, PHP doesn't and seems to use long and int almost interchangeably which PHP indeed does not use fixed-size types in zvals, etc. but it definitely does not use long and int almost

Re: [PHP-DEV] double val to long val conversion issue

2013-02-09 Thread Stas Malyshev
Hi! Stan, you are right to correct me. Sorry. However, I still feel that the implicit assumption is that sizeof(long) == 2*sizeof(int) and this I'm not sure where this assumption exists. Could you be more specific? PHP uses long for most integer values, and int for some internal things and

Re: [PHP-DEV] double val to long val conversion issue

2013-02-09 Thread Remi Collet
Le 10/02/2013 05:54, Stas Malyshev a écrit : Hi! About http://git.php.net/?p=php-src.git;a=commitdiff;h=79956330fe17cfd5f60de456497541b21a89bddf (For now, I have reverted this fix) Here some explanations. LONG_MAX is 9223372036854775807 (0x7fff) double representation of

Re: [PHP-DEV] double val to long val conversion issue

2013-02-09 Thread Remi Collet
One more test (to get rid of compiler optimization) int main (int argc, char *argv[]) { double d; if (argc1 sscanf(argv[1], %lg, d)) { printf( double=%.20lg\n, d); printf( signed=%lx\n, (long)d);