Re: [PHP-DEV] [RFC][VOTE] Binary String Deprecation

2017-02-16 Thread Davey Shafik
I personally think there is value in marking strings as binary using the 'b' even if PHP currently doesn't differentiate, from a developer friendliness perspective. It shows intent, and informs the reader of what to expect if they inspect the value. If anything, the only change I'd make, if

[PHP-DEV] UGLY Benchmark Results for PHP Master 2017-02-15

2017-02-16 Thread lp_benchmark_robot
Results for project PHP master, build date 2017-02-15 20:29:00-08:00 commit: 0d450dd previous commit:2ed4723 revision date: 2017-02-15 16:37:15+01:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] [RFC][VOTE] Binary String Deprecation

2017-02-16 Thread Nicolas Grekas
Actually, there is a very nasty side effect to the "b" prefix: it complicates using the output from token_get_all. You have to be very experienced (i.e. have feel the pain really) to know about this rare edge case - yet it must be dealt with if you want a correct parser in userland. See e.g.

Re: [PHP-DEV] [RFC][VOTE] Binary String Deprecation

2017-02-16 Thread Nikita Popov
On Thu, Feb 16, 2017 at 11:25 PM, Nicolas Grekas < nicolas.grekas+...@gmail.com> wrote: > Actually, there is a very nasty side effect to the "b" prefix: it > complicates using the output from token_get_all. You have to be very > experienced (i.e. have feel the pain really) to know about this rare

Re: [PHP-DEV] [RFC][VOTE] Binary String Deprecation

2017-02-16 Thread Pedro Magalhães
> > > Too bad it has been rejected. > The vote is still open until the 20th. Regards, Pedro

Re: [PHP-DEV] [RFC][VOTE] Binary String Deprecation

2017-02-16 Thread Dan Ackroyd
On 16 February 2017 at 10:14, François Laupretre wrote: > > the 'binary string' flag may become useful again I prefer keeping it. Interestingly, that's why I voted yes. If we want the binary string to be re-purposed in the future it needs to be deprecated in a version

Re: [PHP-DEV] Change debug_zval_dump to return the dump unaffected by __debugInfo?

2017-02-16 Thread Wes
filed a bug https://bugs.php.net/bug.php?id=74117

Re: [PHP-DEV] Change debug_zval_dump to return the dump unaffected by __debugInfo?

2017-02-16 Thread Wes
> I'm an imbecile. It's confirmed. Sorry for the trashy emails and the bug report. Time to go to bed :P

Re: [PHP-DEV] Change debug_zval_dump to return the dump unaffected by __debugInfo?

2017-02-16 Thread Wes
Actually, scratch that, I'm an imbecile... function __debugInfo(){ return (array)$this; } ...would work just fine to access the old style dump except that it doesn't. Did you notice that (array)$object cast uses __debugInfo? https://3v4l.org/VKbPj

[PHP-DEV] PHP 7.0.16 is available

2017-02-16 Thread Anatol Belski
Hi, The PHP development team announces the immediate availability of PHP 7.0.16. Several bugs have been fixed. All PHP 7.0 users are encouraged to upgrade to this version. For source downloads of PHP 7.0.16 please visit our downloads page: http://www.php.net/downloads.php Windows binaries can

Re: [PHP-DEV] [RFC][VOTE] Binary String Deprecation

2017-02-16 Thread François Laupretre
Hi, Le 15/02/2017 à 20:02, Andrey Andreev a écrit : While that's an understandable argument, what happens if we flip it? Is there any benefit to keeping it? If it currently does nothing, and the only reason for keeping it is that it may do something in the future ... Well, there will be

[PHP-DEV] [RFC] Extended String Types For PDO

2017-02-16 Thread Adam Baratz
Hi, Based on some pain points with my team and things I've heard from others, I created an RFC to handle "national" character sets for emulated prepared statements: https://wiki.php.net/rfc/extended-string-types-for-pdo I had previously suggested this as a driver-specific change, but believe

Re: [PHP-DEV] Change debug_zval_dump to return the dump unaffected by __debugInfo?

2017-02-16 Thread Marco Pivetta
Seems invalid, see https://3v4l.org/cKaN8 On 17 Feb 2017 8:08 a.m., "Wes" wrote: > filed a bug https://bugs.php.net/bug.php?id=74117 >