Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-24 Thread Christoph M. Becker
On 24.12.2018 at 08:38, Dmitry Stogov wrote: > On 12/22/18 1:32 PM, Nikita Popov wrote: > >> My main concern here is that this is a very new extension and I think >> that apart from you barely anyone had a chance to actually implement >> something based on it and gain experience using the

Re: [PHP-DEV] [RFC][Vote] Covariant Returns and ContravariantParameters

2018-12-24 Thread Christoph M. Becker
On 24.12.2018 at 13:20, Dmitry Stogov wrote: > - The patch is incompatible with opcache (crashes on Wordpress, Drupal, and > probably any real-life app). > > - the incompatibility with opcache, doesn't allow to check the performance > implication of the patch > > - the patch has merge

Re: [PHP-DEV] [RFC][Vote] Covariant Returns and Contravariant Parameters

2018-12-24 Thread Dmitry Stogov
Hi Levi, I made just few tests, to understand that the implementation is at least incomplete. The warning message depends on class declaration order and may be emitted or not. 1. This test produces a warning (as RFC proposes) 2. But this test misses warning - The patch is

Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-24 Thread Dmitry Stogov
On 12/24/18 4:50 PM, Christoph M. Becker wrote: > On 24.12.2018 at 08:38, Dmitry Stogov wrote: > >> On 12/22/18 1:32 PM, Nikita Popov wrote: >> >>> My main concern here is that this is a very new extension and I think >>> that apart from you barely anyone had a chance to actually implement >>>

Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-24 Thread Jefferson Gonzalez
Is sad to see people voting against this feature, which would help move PHP into territories outside of the web development landscape. For those developers not interested in learning the zend engine (lack of time) but with enough knowledge about C, this extension would surely help a lot when

Re: [PHP-DEV] [RFC] [VOTE] FFI - Foreign Function Interface

2018-12-24 Thread Pierre Joye
Hi, I agree with the comments about safety here however I still vote yes. FFI and Jit integration will be a critical part of php in a near future. As I have seen in the past, it is extremely time consuming to maintain such implementation outside the core, especially if performance and tight