[PHP-DEV] [RFC] Numeric Literal Separator

2019-05-15 Thread Theodore Brown
Hi internals, As requested at the end of April [1], Bishop and I are resurrecting the Numeric Literal Separator RFC: https://wiki.php.net/rfc/numeric_literal_separator. If no serious issues come up, voting will start in two weeks (on 2019-05-29). Best regards, Theodore [1]:

[PHP-DEV] Removing mysqlnd stats from phpinfo

2019-05-15 Thread Pieter Hordijk
Hey internals, when there is support for mysqlnd the `phpinfo()` page hows the entire list of available mysqlnd stats. Do we really need to show the stats here? It makes the page unnecessary long and somewhat annoying to scroll past for no obvious (to me) reason it to be there. The stats can

Re: [PHP-DEV] PHP header files, restrict to declaring code only

2019-05-15 Thread Robert Hickman
> > That said... most polyfill files, of which there are a decent number, do some > variation on: > > > if (!function_exists('coolness')) { > function coolness(int $coolLevel) { ... } > } > ?> > I can see quite a lot that could be done with preloading by executing code once, essentially

[PHP-DEV] RFC for Sqlite3 Extended Error Codes

2019-05-15 Thread Robert Kopack
Hello, My apologies if I violate any netiquette during this e-mail. This is my first time doing something like this and I am following the guide from the CONTRIBUTING.md to the best of my ability. I would to extend the functionality of the current sqlite3 implementation (in *ext/sqlite3* and in

Re: [PHP-DEV] Re: [RFC] Allow throwing exceptions from __toString()

2019-05-15 Thread Matteo Beccati
Hi Dan, On 15/05/2019 03:15, Dan Ackroyd wrote: Immediately nothing. Eventually, when a __toString() method throws an exception, and the extension doesn't check for an exception being throw, bad things will happen. But in my opinion, if people don't understand the implications of the RFC even

Re: [PHP-DEV] Re: [RFC] Allow throwing exceptions from __toString()

2019-05-15 Thread Nikita Popov
On Wed, May 15, 2019 at 7:55 PM Matteo Beccati wrote: > Hi Dan, > > On 15/05/2019 03:15, Dan Ackroyd wrote: > > Immediately nothing. > > > > Eventually, when a __toString() method throws an exception, and the > > extension doesn't check for an exception being throw, bad things will > > happen. >

Re: [PHP-DEV] Re: [RFC] Allow throwing exceptions from __toString()

2019-05-15 Thread Matteo Beccati
On 15/05/2019 21:00, Nikita Popov wrote: While checking every single string conversion certainly puts you on the safe side, leaving out these checks will usually only result in some unneeded computation and possibly redundant warnings. The main thing you should watch out for are operations

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Prepare 7.3.6RC1: NEWS Zend/zend.hconfigure.ac main/php_version.h

2019-05-15 Thread Nikita Popov
On Wed, May 15, 2019 at 10:06 AM Christoph M. Becker wrote: > On 15.05.2019 at 07:42, Rasmus Lerdorf wrote: > > > Christoph, I think we should merge > > > http://git.php.net/?p=php-src.git;a=commitdiff;h=5c4d125d4c2976236e2ecddd1d8c6e7b113ec482 > > into 7.3.6. > > Thanks for the ping! This

[PHP-DEV] Re: [PHP-CVS] com php-src: Prepare 7.3.6RC1: NEWS Zend/zend.hconfigure.ac main/php_version.h

2019-05-15 Thread Christoph M. Becker
On 15.05.2019 at 07:42, Rasmus Lerdorf wrote: > Christoph, I think we should merge > http://git.php.net/?p=php-src.git;a=commitdiff;h=5c4d125d4c2976236e2ecddd1d8c6e7b113ec482 > into 7.3.6. Thanks for the ping! This looks like an important bug fix, and since it will be in PHP 7.2.19, it should

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Prepare 7.3.6RC1: NEWSZend/zend.hconfigure.ac main/php_version.h

2019-05-15 Thread Christoph M. Becker
On 15.05.2019 at 10:08, Nikita Popov wrote: > On Wed, May 15, 2019 at 10:06 AM Christoph M. Becker > wrote: > >> On 15.05.2019 at 07:42, Rasmus Lerdorf wrote: >> >>> Christoph, I think we should merge >>> >>

[PHP-DEV] Re: RFC for Sqlite3 Extended Error Codes

2019-05-15 Thread Christoph M. Becker
On 15.05.2019 at 19:14, Robert Kopack wrote: > I would to extend the functionality of the current sqlite3 implementation > (in *ext/sqlite3* and in *ext/pdo_sqlite*) by exposing the functions > related to extended result codes. I have already forked and made my changes > at >