Re: [PHP-DEV] Re: [RFC] Random Extension 3.0

2021-09-06 Thread Nikita Popov
On Sun, Sep 5, 2021 at 7:40 PM Ben Ramsey wrote: > Go Kudo wrote on 9/4/21 23:00: > > Indeed, it may be true that these suggestions should not be made all at > > once. If necessary, I would like to propose to organize the RNG > > implementation first. > > > > Do we still need an RFC in this

Re: [PHP-DEV] Adding a way to disable the stat cache

2021-09-06 Thread Benjamin Eberlei
On Fri, Sep 3, 2021 at 11:51 PM Hans Henrik Bergan wrote: > PS i've seen *HORRIBLE* fs performance for php-running-on-windows, > where the same filesystem operations on the same files took like 5 seconds > on linux-running-on-vmware-on-laptop-running-windows-10, versus several > minutes for the

Re: [PHP-DEV] Alias stdClass to DynamicObject?

2021-09-06 Thread Matthew Brown
> On Sep 6, 2021, at 11:29 AM, Nikita Popov wrote: > I think this would be a massive benefit to first-time PHP users one or two years from now. I remember being confused by this terminology — I am sure bugs have been caused by people who assumed stdClass was a base class for all objects.

[PHP-DEV] Re: Alias stdClass to DynamicObject?

2021-09-06 Thread Björn Larsson via internals
Den 2021-09-06 kl. 17:28, skrev Nikita Popov: Hi internals, In the thread for deprecation of dynamic properties, Rowan suggested that we alias "stdClass" to "DynamicObject" in https://externals.io/message/115800#115802. I wanted to split this discussion off into a separate thread, as this can

Re: [PHP-DEV] Re: [RFC] Random Extension 3.0

2021-09-06 Thread Go Kudo
Nikita, Thanks for the clarification. That's exactly what I intended to do. > can you update the RFC with more information about this functionality? I understand. Organize them and reconstruct the RFC text. I've also created an RFC about moving RNG-related functions from ext/standard to

Re: [PHP-DEV] Alias stdClass to DynamicObject?

2021-09-06 Thread Kamil Tekiela
Hi Nikita, I think this might be a good idea, but I would like to propose yet another variant. Replace stdClass with DynamicObject and keep stdClass as an alias. It can be deprecated in 8.3. If we only add an alias, I am afraid that it will not catch on quickly enough. What I am proposing is that

Re: [PHP-DEV] Re: [RFC] Random Extension 3.0

2021-09-06 Thread Ben Ramsey
Nikita Popov wrote on 9/6/21 03:06: > On Sun, Sep 5, 2021 at 7:40 PM Ben Ramsey wrote: > >> Go Kudo wrote on 9/4/21 23:00: >>> Indeed, it may be true that these suggestions should not be made all at >>> once. If necessary, I would like to propose to organize the RNG >>> implementation first. >>>

Re: [PHP-DEV] Alias stdClass to DynamicObject?

2021-09-06 Thread Björn Larsson via internals
Den 2021-09-06 kl. 18:22, skrev Christian Schneider: Am 06.09.2021 um 18:08 schrieb Benjamin Morel : Yes, please! A future where dynamic properties are only allowed on DynamicObject is bright. I have nothing against a DynamicObject alias for people who like to be more explicit in their

[PHP-DEV] [RFC] Move RNG functions ext/random

2021-09-06 Thread Go Kudo
Hi internals. As a result of the exchange in the following thread, it seems appropriate to separate the proposals. In line with this, we have created a proposal to first clean up the existing RNG-related functionality and move it from ext/standard to ext/random.

Re: [PHP-DEV] Alias stdClass to DynamicObject?

2021-09-06 Thread Aran Reeks
Creating a new DynamicObject class which is the preferred alias for stdClass sounds logical but I too share the consern around making it the default anytime soon. Too much code depends on an expected type of stdClass presently which would likely make future upgrades more difficult for no

Re: [PHP-DEV] Adding a way to disable the stat cache

2021-09-06 Thread Pierre Joye
On Mon, Sep 6, 2021, 6:14 PM Benjamin Eberlei wrote: > On Fri, Sep 3, 2021 at 11:51 PM Hans Henrik Bergan > wrote: > > > The stat cache does not necessarily solve this issues though, only in very > limited cases where you work with the *same* file over and over again. The > stat cache only ever

Re: [PHP-DEV] Adding a way to disable the stat cache

2021-09-06 Thread Christoph M. Becker
On 06.09.2021 at 14:00, Pierre Joye wrote: > On Mon, Sep 6, 2021, 6:14 PM Benjamin Eberlei wrote: > >> On Fri, Sep 3, 2021 at 11:51 PM Hans Henrik Bergan >> wrote: >> >> The stat cache does not necessarily solve this issues though, only in very >> limited cases where you work with the *same*

Re: [PHP-DEV] Adding a way to disable the stat cache

2021-09-06 Thread Pierre Joye
On Mon, Sep 6, 2021, 10:50 PM Christian Schneider wrote: > Am 06.09.2021 um 16:46 schrieb Pierre Joye : > > Also as someone mentioned here afterwards, instead of removing it > > straight away, I would go with the flag first, less risky :) > > Out of curiosity: Do you think disabling the stat

Re: [PHP-DEV] Adding a way to disable the stat cache

2021-09-06 Thread Christian Schneider
Am 05.09.2021 um 13:30 schrieb Kevin Lyda : > Any more thoughts on https://github.com/php/php-src/pull/5894 ? > I've resolved the merge conflict. It would be nice to close out this bug. For the record in case it was missed: If we deem the stat cache to be useless I'd rather remove it completely

Re: [PHP-DEV] Adding a way to disable the stat cache

2021-09-06 Thread Pierre Joye
On Mon, Sep 6, 2021 at 7:05 PM Christoph M. Becker wrote: > > On 06.09.2021 at 14:00, Pierre Joye wrote: > > > On Mon, Sep 6, 2021, 6:14 PM Benjamin Eberlei wrote: > > > >> On Fri, Sep 3, 2021 at 11:51 PM Hans Henrik Bergan > >> wrote: > >> > >> The stat cache does not necessarily solve this

[PHP-DEV] Alias stdClass to DynamicObject?

2021-09-06 Thread Nikita Popov
Hi internals, In the thread for deprecation of dynamic properties, Rowan suggested that we alias "stdClass" to "DynamicObject" in https://externals.io/message/115800#115802. I wanted to split this discussion off into a separate thread, as this can be decided independently. The rationale for this

Re: [PHP-DEV] Alias stdClass to DynamicObject?

2021-09-06 Thread Christian Schneider
Am 06.09.2021 um 18:08 schrieb Benjamin Morel : > Yes, please! A future where dynamic properties are only allowed on > DynamicObject is bright. I have nothing against a DynamicObject alias for people who like to be more explicit in their code... > I would even deprecate the stdClass alias

Re: [PHP-DEV] Alias stdClass to DynamicObject?

2021-09-06 Thread Benjamin Morel
Hi Nikita, Rowan, In the thread for deprecation of dynamic properties, Rowan suggested that > we alias "stdClass" to "DynamicObject" in > https://externals.io/message/115800#115802. I wanted to split this > discussion off into a separate thread, as this can be decided > independently. > > The

Re: [PHP-DEV] Adding a way to disable the stat cache

2021-09-06 Thread Christian Schneider
Am 06.09.2021 um 16:46 schrieb Pierre Joye : > Also as someone mentioned here afterwards, instead of removing it > straight away, I would go with the flag first, less risky :) Out of curiosity: Do you think disabling the stat cache could be harmful? If no, why make it an option? If yes, should we

[PHP-DEV] Re: Alias stdClass to DynamicObject?

2021-09-06 Thread Rowan Tommins
On 06/09/2021 18:36, Björn Larsson wrote: In case of deprecation of stdClass I would like to point out that the benefit of replacing "new stdClass" with "new DynamicObject" in our existing code is absolutely zero. However, using DynamicObject in new code has a benefit since the intent is

Re: [PHP-DEV] [RFC] Move RNG functions ext/random

2021-09-06 Thread Pierre Joye
Hi Go, Awesome, excellent work and will make the whole thing easier :) +1 already! best, On Tue, Sep 7, 2021 at 3:29 AM Go Kudo wrote: > > Hi internals. > > As a result of the exchange in the following thread, it seems appropriate > to separate the proposals. > > In line with this, we have

Re: [PHP-DEV] Alias stdClass to DynamicObject?

2021-09-06 Thread Hossein Baghayi
On Tue, 7 Sept 2021 at 01:12, Aran Reeks wrote: > ... Too much code depends on an expected type of stdClass > presently which would likely make future upgrades more difficult for no > functional gain, beyond some added clarify. What if we had the DynamicObject as a subclass of stdClass? It