Re: [PHP-DEV] Base_convert changes

On 11.03.2019 10:51, Nikita Popov wrote: Both changes sound reasonable to me. Could you show some examples where the output is going to change due to the zend_ulong->zend_long switch? Nikita Sure! For example var_dump(decbin(9223372036854775807)); would currently show string(64)

[PHP-DEV] Base_convert changes

Hi, I have just put a pull request together to make some changes to base_convert, the changes are as follows: 1, Allow conversion of negative numbers (fixes https://bugs.php.net/bug.php?id=55393) 2, Raise a notice when passing in invalid chars as input, currently they are just silently

Re: [PHP-DEV] PHP 7.2.19 Released

Ondrej updated on the 31st (yesterday). The official Ubuntu one (in 18.04 at least) updated on 30th. Both do update pretty quickly usually. Scott On 1 June 2019 18:56:44 BST, Larry Garfield wrote: >On Thu, May 30, 2019, at 11:17 PM, Ryan McCullagh wrote: >> Hi internals group, >> >> I

Re: [PHP-DEV] [RFC] Base convert changes

Hi all, I plan to put this to vote early next week with the two options One vote for the invalid char deprecation for php7.4 and Exception in PHP8 One vote for negative numbers PHP8 only - due to BC concerns Thanks Scott -- PHP Internals - PHP Runtime Development Mailing List To

[PHP-DEV] [RFC] [Vote] Base convert changes

Hi all I have put my RFC base convert changes to vote this morning https://wiki.php.net/rfc/base_convert_improvements Two votes, one to raise a deprecated error in PHP7.4 (raised to exception in PHP 8) when base_convert encounters something it doesnt know how to convert. Second vote is to

Re: [PHP-DEV] [RFC] [Vote] Base convert changes

res. Cheers Joe On Wed, 19 Jun 2019 at 09:24, Scott Dutton wrote: Hi all I have put my RFC base convert changes to vote this morning https://wiki.php.net/rfc/base_convert_improvements [1] Two votes, one to raise a deprecated error in PHP7.4 (raised to exception in PHP 8) when base_conv

Re: [PHP-DEV] [RFC] [Vote] Base convert changes

ting "Allow negative arguments". None of these PR's should cause tests to fail, and where new untested behaviour is introduced the PR should include tests for that. Cheers Joe On Wed, 19 Jun 2019 at 09:43, Scott Dutton wrote: Hi Joe, I will take a look at conflicts. The fail

RE: [PHP-DEV] [RFC] [Vote] Base convert changes

. e.g. base_convert('--ff', 16, 10) Thanks, CHU Zhaowei -Original Message- From: Scott Dutton Sent: Wednesday, June 19, 2019 3:24 PM To: internals@lists.php.net Subject: [PHP-DEV] [RFC] [Vote] Base convert changes Hi all I have put my RFC base convert changes to vote this morning https

Re: [PHP-DEV] [RFC] [Vote] Base convert changes

Ah thats brilliant, I will take a look at updating the tests when I split the PR tomorrow Thanks Nikita Scott On 19.06.2019 09:13, Nikita Popov wrote: On Wed, Jun 19, 2019 at 10:06 AM Scott Dutton wrote: Hi Joe, I will have a look at splitting the PR, I am not at a computer where i

[PHP-DEV] People.php.net

It seems people is down For example https://people.php.net/rasmus Not sure if people are aware Thanks Scott

Re: [PHP-DEV] Using [ci skip]

Hi Joe Is there any reason why something like the following isnt run instead ? runTests=$(git diff origin/master... --name-only --diff-filter=ACMR -- ':(exclude)docs/*' | wc -l) if [[ "${runTests}" -gt 0 ]]; then ./run-tests.sh fi ~ Which says if the diff contains files outside of

Re: [PHP-DEV] Wiki permissions

It's exussum Thanks Scott On 10 May 2019 05:26:39 BST, Scott Dutton wrote: >Hi > >Could I get Wiki permissions to create an RFC for > >https://externals.io/message/104618 > >Thanks > >-- >PHP Internals - PHP Runtime Development Mailing List >To unsub

Re: [PHP-DEV] [RFC] Base convert changes

, 2019 at 11:22 AM Scott Dutton wrote: > I have made some changes to base_convert which I feel would be more > consistent with the current PHP (warning when there are errors, and > not just returning the best value it can) > > The RFC has some examples of what will change

[PHP-DEV] [RFC] Base convert changes

Hi all I have made some changes to base_convert which I feel would be more consistent with the current PHP (warning when there are errors, and not just returning the best value it can) The RFC has some examples of what will change. Currently the code works but a lot of tests fail due to

[PHP-DEV] Wiki permissions

Hi Could I get Wiki permissions to create an RFC for https://externals.io/message/104618 Thanks -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC] Base convert changes

Not sure if I can add and example to the RFC at this point, but I came across another example of this recently. https://gist.github.com/iansltx/4820b02ab276c3306314daaa41573445#file-getlines-php-L9 // bindec() was doing weird things, hence converting through hex first // sttrev()

RE: [PHP-DEV] [RFC] [Vote] Base convert changes

Hi all I have made a PR for 7.4 for just the ignoring invalid input. I will open a similar one for PHP 8. https://github.com/php/php-src/pull/4328 All tests have been fixed for linux, there is one failure for windows which I am looking in to. Voting ends in a few days time so last chance

Re: [PHP-DEV] DKIM on messages

On 2019-07-08 15:57, Tim Düsterhus wrote: This will *still* break anything using DMARC, because neither DKIM nor SPF is valid. Anything *not* using DMARC is better off, though. Ideally the email modifications are disabled entirely. The emails can be reliably detected using the List-Id header