Re: [PHP-DEV] [RFC] Amendments to Attributes

On Mon, Jun 1, 2020 at 1:48 AM Theodore Brown wrote: > On Wed, May 20, 2020 at 12:07 PM Benjamin Eberlei > wrote: > > > the Attributes RFC was rather large already, so a few things were left > > open or discussions during the vote have made us rethink a things. > > > > https://wiki.php.net/rfc/a

Re: [PHP-DEV] [RFC] Amendments to Attributes

On Mon, 1 Jun 2020 at 00:48, Theodore Brown wrote: > > Having a distinct token for attributes would entirely avoid the issues > of having to modify multiple lines when adding/removing attributes, as > well as confusion with shift operators and comma-separated attribute > arguments. E.g. the RFC e

Re: [PHP-DEV] [RFC] Amendments to Attributes

On Wed, May 20, 2020 at 12:07 PM Benjamin Eberlei wrote: > the Attributes RFC was rather large already, so a few things were left > open or discussions during the vote have made us rethink a things. > > https://wiki.php.net/rfc/attribute_amendments > > These points are handled by the Amendments R

Re: [PHP-DEV] [RFC] Amendments to Attributes

On Thu, May 28, 2020 at 12:05 AM Benas IML wrote: > It seems that the RFC was updated to use the `Attributes` namespace. I > think this is a bad idea since we're reserving a generic namespace that we > haven't even "soft" reserved. Also, the loss of fallback to global > namespace is a turning poi

Re: [PHP-DEV] [RFC] Amendments to Attributes

It seems that the RFC was updated to use the `Attributes` namespace. I think this is a bad idea since we're reserving a generic namespace that we haven't even "soft" reserved. Also, the loss of fallback to global namespace is a turning point for me. Generally, I think we should instead do somethin

Re: [PHP-DEV] [RFC] Amendments to Attributes

That's a brilliant idea, completely agreed, Rowan! On the other note, don't want to nitpick here but I believe that it would be better to name the repeatable attribute simply as `<>`. It would match other languages (such as Java) and the naming wouldn't be that verbose. Also IMO, I think for cons

Re: [PHP-DEV] [RFC] Amendments to Attributes

On 22/05/2020 12:08, Nikita Popov wrote: As such, I would suggest to introduce a common namespace for all attributes provided by PHP. This means we'd have Attributes\Attribute, Attributes\Deprecated, Attributes\Jit, Attributes\NoJit etc. (I'm also okay with the PHP\Attributes\Deprecated variant,

Re: [PHP-DEV] [RFC] Amendments to Attributes

> Am 22.05.2020 um 13:08 schrieb Nikita Popov : > > On Wed, May 20, 2020 at 7:08 PM Benjamin Eberlei > wrote: > >> 2. Rename PhpAttribute to Attribute in global namespace (independent of the >> namespace RFC) > > As was mentioned in one of the previous discussions, we expect that PHP is > going

Re: [PHP-DEV] [RFC] Amendments to Attributes

On Fri, May 22, 2020 at 5:28 PM Nikita Popov wrote: > > I don't particularly care what namespace the attribute classes are under, > just that they should have a common namespace, because there's going to be > many of them, presumably. If it was just a matter of the Attribute class, > I'd definitel

Re: [PHP-DEV] [RFC] Amendments to Attributes

On Fri, May 22, 2020 at 5:29 PM Benjamin Eberlei wrote: > > > On Fri, May 22, 2020 at 1:08 PM Nikita Popov wrote: > >> On Wed, May 20, 2020 at 7:08 PM Benjamin Eberlei >> wrote: >> >>> Hi everyone, >>> >>> the Attributes RFC was rather large already, so a few things were left >>> open >>> or di

Re: [PHP-DEV] [RFC] Amendments to Attributes

On Fri, May 22, 2020 at 1:08 PM Nikita Popov wrote: > On Wed, May 20, 2020 at 7:08 PM Benjamin Eberlei > wrote: > >> Hi everyone, >> >> the Attributes RFC was rather large already, so a few things were left >> open >> or discussions during the vote have made us rethink a things. >> >> https://wi

Re: [PHP-DEV] [RFC] Amendments to Attributes

On Fri, May 22, 2020 at 2:19 PM Benas IML wrote: > Agreed. > > I don't think we should pollute any other than the `PHP\` namespace. If > that RFC doesn't pass though, we should keep the `Attribute` class in the > global namespace. > > Global namespace is already reserved for PHP and so, BC breaks

Re: [PHP-DEV] [RFC] Amendments to Attributes

Agreed. I don't think we should pollute any other than the `PHP\` namespace. If that RFC doesn't pass though, we should keep the `Attribute` class in the global namespace. Global namespace is already reserved for PHP and so, BC breaks aren't that severe whereas `Attributes\` namespace isn't reser

Re: [PHP-DEV] [RFC] Amendments to Attributes

On Fri, 22 May 2020 at 12:09, Nikita Popov wrote: > While I'm happy with "Attribute" living in the global > namespace, I don't really think we'd want to introduce "Jit" as a class in > the global namespace. The name is simply to generic and does not indicate > that this is part of the attribute s

Re: [PHP-DEV] [RFC] Amendments to Attributes

On Wed, May 20, 2020 at 7:08 PM Benjamin Eberlei wrote: > Hi everyone, > > the Attributes RFC was rather large already, so a few things were left open > or discussions during the vote have made us rethink a things. > > https://wiki.php.net/rfc/attribute_amendments > > These points are handled by

Re: [PHP-DEV] [RFC] Amendments to Attributes

> On May 21, 2020, at 01:06, CHU Zhaowei wrote: > > It's good to hear that `PhpCompikerAttribute` can be merged, could you > include it in the RFC as well? Thus I think people who support > `UserlandAttribute` can agree with `Attribute` now as well. I think I’m the only one who supports `User

RE: [PHP-DEV] [RFC] Amendments to Attributes

Sent: Thursday, May 21, 2020 6:13 AM To: Ben Ramsey Cc: PHP Internals Subject: Re: [PHP-DEV] [RFC] Amendments to Attributes On Wed, May 20, 2020 at 7:53 PM Ben Ramsey wrote: > > On May 20, 2020, at 12:07, Benjamin Eberlei wrote: > > > > 2. Rename PhpAttribute to Attribute in global

Re: [PHP-DEV] [RFC] Amendments to Attributes

On Wed, May 20, 2020 at 7:53 PM Ben Ramsey wrote: > > On May 20, 2020, at 12:07, Benjamin Eberlei wrote: > > > > 2. Rename PhpAttribute to Attribute in global namespace (independent of > the > > namespace RFC) > > > I suggested in a previous thread that we consider renaming `PhpAttribute` > to `

Re: [PHP-DEV] [RFC] Amendments to Attributes

Hello, Would it possible to make a separate RFC for renaming `PhpAttribute` to `Attribute` and `PhpCompilerAttribute` to `CompilerAttribute`? Since it would a huge BC break changing this in PHP 8.1. Best regards, Benas Seliuginas

Re: [PHP-DEV] [RFC] Amendments to Attributes

On Wed, May 20, 2020 at 7:37 PM Marco Pivetta wrote: > Hey Benjamin, > > > > On Wed, May 20, 2020 at 7:08 PM Benjamin Eberlei > wrote: > >> Hi everyone, >> >> the Attributes RFC was rather large already, so a few things were left >> open >> or discussions during the

Re: [PHP-DEV] [RFC] Amendments to Attributes

Hey, I personally think that `UserlandAttribute` is too verbose and a quite useless change since just using `Attribute` will make little to no BC compatibility breaks (we know that thanks to Rowan, please check out Renaming PhpAttribute thread) and would also sound more natural. This would also me

Re: [PHP-DEV] [RFC] Amendments to Attributes

> On May 20, 2020, at 12:07, Benjamin Eberlei wrote: > > 2. Rename PhpAttribute to Attribute in global namespace (independent of the > namespace RFC) I suggested in a previous thread that we consider renaming `PhpAttribute` to `UserlandAttribute`, since this is the intent of the attribute, and

Re: [PHP-DEV] [RFC] Amendments to Attributes

On Wed, May 20, 2020, at 12:07 PM, Benjamin Eberlei wrote: > Hi everyone, > > the Attributes RFC was rather large already, so a few things were left open > or discussions during the vote have made us rethink a things. > > https://wiki.php.net/rfc/attribute_amendments > > These points are handled

Re: [PHP-DEV] [RFC] Amendments to Attributes

Hey Benjamin, On Wed, May 20, 2020 at 7:08 PM Benjamin Eberlei wrote: > Hi everyone, > > the Attributes RFC was rather large already, so a few things were left open > or discussions during the vote have made us rethink a things. > > https://wiki.php.net/rfc/attribu