Re: [PHP-DEV] Re: 7.3 features in announcement

[Christoph M. Becker]

On 04.12.2018 at 20:53, Côme Chilliet wrote:

> I pushed to PHP-7.3 

Thanks!

> but could not merge into master due to a Karma problem:
> 
>> remote: Welcome mcmic.
>> remote: You have insufficient Karma!
>> remote: I'm sorry, I cannot allow you to write to
>> remote: php-src.git/
>> remote: Have a nice day.
>> To git.php.net:/php-src.git
>>  ! [remote rejected]   master -> master (pre-receive hook declined)

You should definitely have sufficient karma to push to master, if you
are allowed to push to PHP-7.3.  Not sure what went wrong there; have
you configured the mandatory Git settings[1]?

Anyhow, I've merged into master and pushed now, to avoid potential merge
issues for others.

[1] 

-- 
Christoph M. Becker

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: 7.3 features in announcement

[Côme Chilliet]

Le mardi 4 décembre 2018, 16:35:14 CET Christoph M. Becker a écrit :
> PHP-7.3 is the main branch for 7.3; please commit relevant changes to
> UPGRADING there (and merge up to master).  PHP-7.3.0 is the release
> branch, which usually is maintained by the RMs only, who cherry-pick
> important commits from PHP-7.3 into it.

I pushed to PHP-7.3 but could not merge into master due to a Karma problem:

> remote: Welcome mcmic.
> remote: You have insufficient Karma!
> remote: I'm sorry, I cannot allow you to write to
> remote: php-src.git/
> remote: Have a nice day.
> To git.php.net:/php-src.git
>  ! [remote rejected]   master -> master (pre-receive hook declined)

Côme

signature.asc
Description: This is a digitally signed message part.

Re: [PHP-DEV] Re: 7.3 features in announcement

[Christoph M. Becker]

On 04.12.2018 at 16:17, Nikita Popov wrote:

> Speaking of which, what's the state of the migration guide for 7.3? I think
> it is usually available by the time of the GA release, but I can't find it
> on deployed docs (and docs.php.net seems down...)

I'm already working on it, and will commit something useable today or
tomorrow.

-- 
Christoph M. Becker

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: 7.3 features in announcement

[Christoph M. Becker]

On 04.12.2018 at 16:09, Côme Chilliet wrote:

> Le lundi 3 décembre 2018, 12:37:45 CET Christoph M. Becker a écrit :
>> Thanks!  Indeed, PR #2640 looks like a considerable improvement.  Please
>> add a respective entry in UPGRADING (either self-explaining, or linking
>> to another document).
> 
> I started https://secure.php.net/manual/en/ldap.controls.php and adding 
> documentation for the new functions as well 

Thanks on behalf of the doc team!

> (The online version is outdated last version is in the svn).

Yeah, the PHP manual is rolled out only once a day to the mirrors.
docs.php.net is supposed to be updated every 4 or 6 hours.

> It’s not clear for me in which branch I should edit UPGRADING, it seems 
> master is now 7.4, should I edit in PHP-7.3 or PHP-7.3.0? What’s the 
> difference?

PHP-7.3 is the main branch for 7.3; please commit relevant changes to
UPGRADING there (and merge up to master).  PHP-7.3.0 is the release
branch, which usually is maintained by the RMs only, who cherry-pick
important commits from PHP-7.3 into it.

> Also what is the difference between UPGRADING and NEWS?

NEWS is for all news (including bug fixes), and usually has only very
brief notes.  Also it has sections for every PHP *revision*, and is made
available as change log[1].  UPGRADING has often more verbose
information which serves as upgrading information for a *minor* PHP
version.  UPGRADING also serves as base for the migration guide[2] in
the PHP manual.

> Regarding the online documentation, it seems http://doc.php.net/tutorial/ is 
> down as well as http://docs.php.net/

Indeed!  Guess we should wait a while, and if it's still not up again
then, someone should file a bug report.

[1] e.g. 
[2] e.g. 

-- 
Christoph M. Becker

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: 7.3 features in announcement

[Nikita Popov]

On Sun, Dec 2, 2018 at 11:51 PM Christoph M. Becker 
wrote:

> On 02.12.2018 at 21:24, Jakub Zelenka wrote:
>
> > I was wondering if we have got a final list of the top features that will
> > be listed in the announcement for the stable release.
> >
> > Not sure how it's usually selected but thought that it would be good to
> > list FPM logging changes that I have been working on and it's the main
> > improvement in FPM [1]. It's not probably that interesting for PHP devs
> but
> > it might be quite importants for DevOps who use FPM with Docker and want
> to
> > properly collect logs from containers. My current client will be updating
> > to 7.3 pretty soon just because of that.
> >
> > [1] https://github.com/php/php-src/pull/2458
>
> Thanks for bringing this up, Jakub!  To be honest, I haven't really
> thought about the release announcement before, so this is a fine reminder.
>
> Regarding the FPM logging changes: indeed, this seems to be quite an
> improvement! :)  However, it seems there is no note in UPGRADING (which
> is important for the migration guide in the manual) yet.  Could you
> please add the missing note?
>

Speaking of which, what's the state of the migration guide for 7.3? I think
it is usually available by the time of the GA release, but I can't find it
on deployed docs (and docs.php.net seems down...)

Nikita


> Regarding other prominent features, I think the “Flexible Heredoc and
> Nowdoc Syntaxes”[2] and the “PCRE2 migration”[3] should certainly be
> mentioned.  Also the MBString improvements[4], as well as the
> deprecations[5], and also the file related Windows improvements[6].
>
> I'm likely missing other important changes, and may overestimate some of
> those I've mentionened above.  I'm looking forward to suggestions!
>
> [2] 
> [3] 
> [4] 
> [5] 
> [6] 
>
>

Re: [PHP-DEV] Re: 7.3 features in announcement

[Côme Chilliet]

Le lundi 3 décembre 2018, 12:37:45 CET Christoph M. Becker a écrit :
> Thanks!  Indeed, PR #2640 looks like a considerable improvement.  Please
> add a respective entry in UPGRADING (either self-explaining, or linking
> to another document).

I started https://secure.php.net/manual/en/ldap.controls.php and adding 
documentation for the new functions as well (The online version is outdated 
last version is in the svn).
It’s not clear for me in which branch I should edit UPGRADING, it seems master 
is now 7.4, should I edit in PHP-7.3 or PHP-7.3.0? What’s the difference?

Also what is the difference between UPGRADING and NEWS?

Regarding the online documentation, it seems http://doc.php.net/tutorial/ is 
down as well as http://docs.php.net/

Côme

signature.asc
Description: This is a digitally signed message part.

Re: [PHP-DEV] Re: 7.3 features in announcement

[Christoph M. Becker]

On 03.12.2018 at 12:08, Côme Chilliet:

> Le dimanche 2 décembre 2018, 23:50:54 CET Christoph M. Becker a écrit :
>
>> I'm likely missing other important changes, and may overestimate some of
>> those I've mentionened above.  I'm looking forward to suggestions!
> 
> It would be good if LDAP controls support in php-ldap is advertised, as it 
> also shows the module is maintained again.
> 
> Sadly I do not have a good link to give for this, I’m gonna try and fill the 
> documentation about this so that it can be linked to.

Thanks!  Indeed, PR #2640 looks like a considerable improvement.  Please
add a respective entry in UPGRADING (either self-explaining, or linking
to another document).

-- 
Christoph M. Becker

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: 7.3 features in announcement

[Côme Chilliet]

Le dimanche 2 décembre 2018, 23:50:54 CET Christoph M. Becker a écrit :
> I'm likely missing other important changes, and may overestimate some of
> those I've mentionened above.  I'm looking forward to suggestions!

It would be good if LDAP controls support in php-ldap is advertised, as it also 
shows the module is maintained again.

Sadly I do not have a good link to give for this, I’m gonna try and fill the 
documentation about this so that it can be linked to.

Côme

signature.asc
Description: This is a digitally signed message part.