Re: [PHP-DEV] Reflection API and Nullable Types

2016-10-11 Thread Sebastian Bergmann

On 10/11/2016 07:27 AM, Stanislav Malyshev wrote:

I hope it's string(3) otherwise we have a bug on our
hands


That was a copy/pasta/no-adapt mistake, my bad.

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Reflection API and Nullable Types

2016-10-10 Thread Stanislav Malyshev
Hi!

> printed
> 
>   string(4) "?int"
>   string(3) "int"
> 
> and now it prints
> 
>   string(4) "int"

I hope it's string(3) otherwise we have a bug on our
hands

-- 
Stas Malyshev
smalys...@gmail.com

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Reflection API and Nullable Types

2016-10-09 Thread Niklas Keller
Sebastian Bergmann  schrieb am So., 9. Okt. 2016, 08:56:

> At some point in time during the development of PHP 7.1 this code
>
>   function f(?int $x)
>   {
>   }
>
>   $f = new ReflectionFunction('f');
>
>   var_dump((string) $f->getParameters()[0]->getType());
>   var_dump($f->getParameters()[0]->getType()->getName());
>
> printed
>
>   string(4) "?int"
>   string(3) "int"
>
> and now it prints
>
>   string(4) "int"
>   string(3) "int"
>
> I know that this issue (or a similar one) was recently discussed but after
> reading through that thread I am not 100% sure whether the current
> behavior is indeed the intended one.
>

See http://externals.io/thread/321

The change has been made to provide backwards compatibility. __toString is
now deprecated and getName should be used.

Regards, Niklas

Thanks!
> Sebastian
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>