RE: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-30 Thread Marek Szyprowski
Hello, On Friday, March 30, 2012 4:24 AM Krishna Reddy wrote: Hi, I have found a bug in arm_iommu_map_sg(). +int arm_iommu_map_sg(struct device *dev, struct scatterlist *sg, int nents, +enum dma_data_direction dir, struct dma_attrs *attrs) { + struct scatterlist *s =

Re: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-30 Thread Subash Patel
Hi KyongHo, On 03/22/2012 07:29 PM, Subash Patel wrote: Hi KyongHo, On 03/21/2012 05:26 AM, KyongHo Cho wrote: On Tue, Mar 20, 2012 at 10:50 PM, Subash Patelsubas...@gmail.com wrote: Sorry for digging this very late. But as part of integrating dma_map v7 sysmmu v12 on 3.3-rc5, I am facing

[PATCH] iommu: OMAP: device detach on domain destroy

2012-03-30 Thread Omar Ramirez Luna
'domain_destroy with devices attached' case isn't yet handled, instead code assumes that the device was already detached. If the domain is destroyed the hardware still has access to invalid pointers to its page table and internal iommu object. In order to detach the users we need to track devices

[PATCH 00/10] vt-d irq_remap_ops patchset

2012-03-30 Thread Suresh Siddha
Ingo, Here is the Joerg's irq_remap_ops patchset updated for the latest -tip. Simplified some of the naming conventions to follow the irq_remapping terminology. There are still some if (irq_remapping_enabled) checks in io_apic.c that I would like to roll into the new io_apic_ops. I will look into

[PATCH 01/10] iommu: Rename intr_remapping files to intel_intr_remapping

2012-03-30 Thread Suresh Siddha
From: Joerg Roedel joerg.roe...@amd.com The files contain code mostly relevant for the Intel implementation of interrupt remapping. Make that visible in the file names. Also inline intr_remapping.h into intr_remapping.c because it is only included there and the content is very small. So there is

[PATCH 02/10] iommu/vt-d: Make intr-remapping initialization generic

2012-03-30 Thread Suresh Siddha
From: Joerg Roedel joerg.roe...@amd.com This patch introduces irq_remap_ops to hold implementation specific function pointer to handle interrupt remapping. As the first part the initialization functions for VT-d are converted to these ops. Signed-off-by: Joerg Roedel joerg.roe...@amd.com

[PATCH 03/10] iommu/vt-d: Convert missing apic.c intr-remapping call to remap_ops

2012-03-30 Thread Suresh Siddha
From: Joerg Roedel joerg.roe...@amd.com Convert these calls too: * Disable of remapping hardware * Reenable of remapping hardware * Enable fault handling With that all of arch/x86/kernel/apic/apic.c is converted to use the generic intr-remapping interface.

[PATCH 05/10] iommu/vt-d: Convert IR set_affinity function to remap_ops

2012-03-30 Thread Suresh Siddha
From: Joerg Roedel joerg.roe...@amd.com The function to set interrupt affinity with interrupt remapping enabled is Intel specific too. So move it to the irq_remap_ops too. Signed-off-by: Joerg Roedel joerg.roe...@amd.com Acked-by: Yinghai Lu ying...@kernel.org Cc: David Woodhouse

[PATCH 06/10] iommu/vt-d: Convert free_irte into a remap_ops callback

2012-03-30 Thread Suresh Siddha
From: Joerg Roedel joerg.roe...@amd.com The operation for releasing a remapping entry is iommu specific too. Signed-off-by: Joerg Roedel joerg.roe...@amd.com Acked-by: Yinghai Lu ying...@kernel.org Cc: David Woodhouse dw...@infradead.org Cc: Alex Williamson alex.william...@redhat.com

[PATCH 08/10] x86, iommu/vt-d: Clean up interfaces for interrupt remapping

2012-03-30 Thread Suresh Siddha
From: Joerg Roedel joerg.roe...@amd.com Remove the Intel specific interfaces from dmar.h and remove asm/irq_remapping.h which is only used for io_apic.c anyway. Signed-off-by: Joerg Roedel joerg.roe...@amd.com Acked-by: Yinghai Lu ying...@kernel.org Cc: David Woodhouse dw...@infradead.org Cc: