Re: [RFC PATCH 1/5] amd_iommu: Split IOMMU group initialization

2012-10-09 Thread Shuah Khan
Alex, couple of comments in-lined: On Mon, Oct 8, 2012 at 10:49 PM, Alex Williamson alex.william...@redhat.com wrote: This needs to be broken apart, start with pulling all the IOMMU group init code into a new function. Signed-off-by: Alex Williamson alex.william...@redhat.com ---

Re: [RFC PATCH 0/5] amd_iommu: Refactor IOMMU group and support virtual aliases

2012-10-09 Thread Florian Dazinger
Am Mon, 08 Oct 2012 22:49:28 -0600 schrieb Alex Williamson alex.william...@redhat.com: This series is meant to refactor IOMMU group support in amd_iommu to properly support virtual aliases. If multiple devices alias to the same virtual alias, they should be grouped together. This code also

Re: [RFC PATCH 0/5] amd_iommu: Refactor IOMMU group and support virtual aliases

2012-10-09 Thread Alex Williamson
On Tue, 2012-10-09 at 20:27 +0200, Florian Dazinger wrote: Am Mon, 08 Oct 2012 22:49:28 -0600 schrieb Alex Williamson alex.william...@redhat.com: This series is meant to refactor IOMMU group support in amd_iommu to properly support virtual aliases. If multiple devices alias to the same

Re: [RFC PATCH 0/5] amd_iommu: Refactor IOMMU group and support virtual aliases

2012-10-09 Thread Florian Dazinger
Am Tue, 09 Oct 2012 12:35:39 -0600 schrieb Alex Williamson alex.william...@redhat.com: On Tue, 2012-10-09 at 20:27 +0200, Florian Dazinger wrote: Am Mon, 08 Oct 2012 22:49:28 -0600 schrieb Alex Williamson alex.william...@redhat.com: This series is meant to refactor IOMMU group support

Re: [RFC PATCH 0/5] amd_iommu: Refactor IOMMU group and support virtual aliases

2012-10-09 Thread Alex Williamson
On Tue, 2012-10-09 at 20:57 +0200, Florian Dazinger wrote: Am Tue, 09 Oct 2012 12:35:39 -0600 schrieb Alex Williamson alex.william...@redhat.com: On Tue, 2012-10-09 at 20:27 +0200, Florian Dazinger wrote: Am Mon, 08 Oct 2012 22:49:28 -0600 schrieb Alex Williamson