Re: [PATCH v3] iommu: Add driver for Renesas VMSA-compatible IPMMU

2014-06-03 Thread Laurent Pinchart
Hi, On Tuesday 03 June 2014 13:57:38 Khiem Nguyen wrote: Hi Laurent, Thanks for the patch. + if (!iommu_present(platform_bus_type)) + bus_set_iommu(platform_bus_type, ipmmu_ops); With this code, if error occurs, it's hidden. I think it should be like below, + ret

Re: [PATCH v2 1/4] dma-mapping: Add devm_ interface for dma_map_single()

2014-06-03 Thread Shuah Khan
On 06/01/2014 01:01 AM, Eli Billauer wrote: dmam_map_single() and dmam_unmap_single() are the managed counterparts for the respective dma_* functions. Note that dmam_map_single() returns a status value rather than the DMA handle. The DMA handle is passed to the caller through a pointer in the

Re: [PATCH v2 1/4] dma-mapping: Add devm_ interface for dma_map_single()

2014-06-03 Thread Joerg Roedel
On Tue, Jun 03, 2014 at 03:24:20PM -0600, Shuah Khan wrote: On 06/01/2014 01:01 AM, Eli Billauer wrote: I see the value of this interface in unmap case, this type of wrapper can release dma buffers, drivers neglected to release leaving dangling buffers. However, driver writers should give