Re: [PATCH v2 0/3] iommu: Remove OMAP IOVMM driver

2014-07-23 Thread Joerg Roedel
On Mon, Jul 21, 2014 at 11:19:29PM -0700, Tony Lindgren wrote: Tony, is there still time to get this (and especially patch 2/3, which touches arch/ code) in v3.17 ? Yes as long as Joerg is OK to merge that branch in :) Fine with me, I can take only patch 1 or all 3 into my arm/omap

Re: [PATCH v2 0/3] iommu: Remove OMAP IOVMM driver

2014-07-23 Thread Laurent Pinchart
Hi Joerg, On Wednesday 23 July 2014 15:52:17 Joerg Roedel wrote: On Mon, Jul 21, 2014 at 11:19:29PM -0700, Tony Lindgren wrote: Tony, is there still time to get this (and especially patch 2/3, which touches arch/ code) in v3.17 ? Yes as long as Joerg is OK to merge that branch in :)

Re: [PATCH] iommu/vt-d: fix race between free_irte() and get_irte()

2014-07-23 Thread Greg Edwards
On Wed, Jul 23, 2014 at 04:40:24PM +0200, Joerg Roedel wrote: On Tue, Jul 22, 2014 at 08:27:19AM -0600, Greg Edwards wrote: get_irte() can race with free_irte() and dereference a NULL iommu pointer. Have you seen any real occurance of this race? Get_irte is called in the set_affinity path,

Re: [PATCH] iommu/vt-d: fix race between free_irte() and get_irte()

2014-07-23 Thread Joerg Roedel
On Wed, Jul 23, 2014 at 08:49:17AM -0600, Greg Edwards wrote: On Wed, Jul 23, 2014 at 04:40:24PM +0200, Joerg Roedel wrote: On Tue, Jul 22, 2014 at 08:27:19AM -0600, Greg Edwards wrote: get_irte() can race with free_irte() and dereference a NULL iommu pointer. Have you seen any real

Re: [Patch Part3 V4 16/21] iommu/vt-d: Implement DMAR unit hotplug framework

2014-07-23 Thread Joerg Roedel
On Fri, Jul 11, 2014 at 02:19:40PM +0800, Jiang Liu wrote: On Intel platforms, an IO Hub (PCI/PCIe host bridge) may contain DMAR units, so we need to support DMAR hotplug when supporting PCI host bridge hotplug on Intel platforms. According to Section 8.8 Remapping Hardware Unit Hot Plug in

[PATCH v2] iommu/vt-d: race setting IRQ CPU affinity while freeing IRQ

2014-07-23 Thread Greg Edwards
A user process setting the CPU affinity of an IRQ for a KVM direct-assigned device via /proc/irq/IRQ#/smp_affinity can race with the IRQ being released by QEMU, resulting in a NULL iommu pointer dereference in get_irte(). Signed-off-by: Greg Edwards gedwa...@ddn.com --- Dropped the Cc: for

Re: [PATCH v2 1/1] iommu-api: Add map_range/unmap_range functions

2014-07-23 Thread Olav Haugan
On 7/22/2014 12:45 AM, Thierry Reding wrote: On Mon, Jul 21, 2014 at 05:59:22PM -0700, Olav Haugan wrote: On 7/17/2014 1:21 AM, Thierry Reding wrote: On Wed, Jul 16, 2014 at 06:01:57PM -0700, Olav Haugan wrote: [...] Additionally, the mapping operation would be faster in general since

iommu/vt-d: Fix build error caused by unknown definition of acpi_handle

2014-07-23 Thread Jiang Liu
When both CONFIG_ACPI and CONFIG_DMAR_TABLE are disabled, commit Implement DMAR unit hotplug framework causes build failure as below: CC arch/x86/kernel/pci-dma.o In file included from arch/x86/kernel/pci-dma.c:3:0: include/linux/dmar.h:168:35: error: unknown type name ‘acpi_handle’ static