Re: [RFC PATCH v2 07/20] x86: Provide general kernel support for memory encryption

2016-09-07 Thread Borislav Petkov
On Wed, Sep 07, 2016 at 09:30:54AM -0500, Tom Lendacky wrote: > _PAGE_ENC is #defined as sme_me_mask and sme_me_mask has already been > set (or not set) at this point - so it will be the mask if SME is > active or 0 if SME is not active. Yeah, I remember :-) > sme_early_init() is merely

Re: [RFC PATCH v2 01/20] x86: Documentation for AMD Secure Memory Encryption (SME)

2016-09-07 Thread Borislav Petkov
On Wed, Sep 07, 2016 at 09:02:38AM -0500, Tom Lendacky wrote: > Ugh.. I thought I caught all of these. Obviously not. I'll go through > all the patches on this. What you could do is run all patches through scripts/checkpatch.pl and fix those issues which make sense to you. What I'm saying is,

Re: [RFC PATCH v2 07/20] x86: Provide general kernel support for memory encryption

2016-09-07 Thread Tom Lendacky
On 09/06/2016 04:31 AM, Borislav Petkov wrote: > On Mon, Aug 22, 2016 at 05:36:46PM -0500, Tom Lendacky wrote: >> Adding general kernel support for memory encryption includes: >> - Modify and create some page table macros to include the Secure Memory >> Encryption (SME) memory encryption mask >>

Re: [RFC PATCH v2 07/20] x86: Provide general kernel support for memory encryption

2016-09-07 Thread Tom Lendacky
On 09/05/2016 10:22 AM, Borislav Petkov wrote: > On Mon, Aug 22, 2016 at 05:36:46PM -0500, Tom Lendacky wrote: >> Adding general kernel support for memory encryption includes: >> - Modify and create some page table macros to include the Secure Memory >> Encryption (SME) memory encryption mask >>

Re: [RFC PATCH v2 07/20] x86: Provide general kernel support for memory encryption

2016-09-07 Thread Tom Lendacky
On 09/05/2016 03:48 AM, Borislav Petkov wrote: > On Mon, Aug 22, 2016 at 05:36:46PM -0500, Tom Lendacky wrote: >> Adding general kernel support for memory encryption includes: >> - Modify and create some page table macros to include the Secure Memory >> Encryption (SME) memory encryption mask >>

Re: [RFC PATCH v2 07/20] x86: Provide general kernel support for memory encryption

2016-09-07 Thread Tom Lendacky
On 09/02/2016 01:14 PM, Borislav Petkov wrote: > On Mon, Aug 22, 2016 at 05:36:46PM -0500, Tom Lendacky wrote: >> Adding general kernel support for memory encryption includes: >> - Modify and create some page table macros to include the Secure Memory >> Encryption (SME) memory encryption mask >>

Re: [RFC PATCH v2 05/20] x86: Add the Secure Memory Encryption cpu feature

2016-09-07 Thread Tom Lendacky
On 09/02/2016 09:09 AM, Borislav Petkov wrote: > On Mon, Aug 22, 2016 at 05:36:22PM -0500, Tom Lendacky wrote: >> Update the cpu features to include identifying and reporting on the >> Secure Memory Encryption feature. >> >> Signed-off-by: Tom Lendacky >> --- >>

Re: [RFC PATCH v2 03/20] x86: Secure Memory Encryption (SME) build enablement

2016-09-07 Thread Tom Lendacky
On 09/02/2016 06:03 AM, Borislav Petkov wrote: > On Mon, Aug 22, 2016 at 05:35:59PM -0500, Tom Lendacky wrote: >> Provide the Kconfig support to build the SME support in the kernel. >> >> Signed-off-by: Tom Lendacky >> --- >> arch/x86/Kconfig |9 + >> 1 file

Re: [RFC PATCH v2 01/20] x86: Documentation for AMD Secure Memory Encryption (SME)

2016-09-07 Thread Tom Lendacky
On 09/02/2016 03:50 AM, Borislav Petkov wrote: > On Mon, Aug 22, 2016 at 05:35:39PM -0500, Tom Lendacky wrote: >> This patch adds a Documenation entry to decribe the AMD Secure Memory >> Encryption (SME) feature. >> >> Signed-off-by: Tom Lendacky >> --- >>

[PATCH v6.1] iommu/dma: Add support for mapping MSIs

2016-09-07 Thread Robin Murphy
When an MSI doorbell is located downstream of an IOMMU, attaching devices to a DMA ops domain and switching on translation leads to a rude shock when their attempt to write to the physical address returned by the irqchip driver faults (or worse, writes into some already-mapped buffer) and no

RE: [PATCH 7/8] iommu: of: Handle IOMMU lookup failure with deferred probing or error

2016-09-07 Thread Sricharan
Hi Marek, >Hi Sricharan, > >On 2016-08-09 00:49, Sricharan R wrote: > > From: Laurent Pinchart > > > > Failures to look up an IOMMU when parsing the DT iommus property need to > > be handled separately from the .of_xlate() failures to support deferred >

RE: [PATCH 1/8] arm: dma-mapping: Don't override dma_ops in arch_setup_dma_ops()

2016-09-07 Thread Sricharan
Hi Marek, >Hi Sricharan and Laurent, > > >On 2016-08-09 00:49, Sricharan R wrote: >> From: Laurent Pinchart >> >> The arch_setup_dma_ops() function is in charge of setting dma_ops with a >> call to set_dma_ops(). set_dma_ops() is also called from >> >>

RE: [PATCH 7/8] iommu: of: Handle IOMMU lookup failure with deferred probing or error

2016-09-07 Thread Sricharan
Hi Marek, >Hi Sricharan, > > >On 2016-08-12 17:40, Sricharan wrote: >> Hi Tomaz, >> + if (ops->add_device) + ops = ops->add_device(dev) ? ops : NULL; >>> Patch description fails to mention anything about this change. Also it >>> looks slightly