Re: [PATCH V4 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2017-07-12 Thread Sricharan R
Hi Vivek, On 7/13/2017 10:43 AM, Vivek Gautam wrote: > Hi Stephen, > > > On 07/13/2017 04:24 AM, Stephen Boyd wrote: >> On 07/06, Vivek Gautam wrote: >>> @@ -1231,12 +1237,18 @@ static int arm_smmu_map(struct iommu_domain >>> *domain, unsigned long iova, >>> static size_t

Re: [PATCH V4 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2017-07-12 Thread Vivek Gautam
Hi Stephen, On 07/13/2017 04:24 AM, Stephen Boyd wrote: On 07/06, Vivek Gautam wrote: @@ -1231,12 +1237,18 @@ static int arm_smmu_map(struct iommu_domain *domain, unsigned long iova, static size_t arm_smmu_unmap(struct iommu_domain *domain, unsigned long iova,

Re: [PATCH V4 4/6] iommu/arm-smmu: Add the device_link between masters and smmu

2017-07-12 Thread Vivek Gautam
On 07/13/2017 04:25 AM, Stephen Boyd wrote: On 07/06, Vivek Gautam wrote: diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index ddbfa8ab69e6..75567d9698ab 100644 --- a/drivers/iommu/arm-smmu.c +++ b/drivers/iommu/arm-smmu.c @@ -1348,6 +1348,7 @@ static int

Re: [PATCH V4 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops

2017-07-12 Thread Vivek Gautam
On 07/13/2017 04:31 AM, Stephen Boyd wrote: On 07/12, Stephen Boyd wrote: On 07/06, Vivek Gautam wrote: From: Sricharan R The smmu needs to be functional only when the respective master's using it are active. The device_link feature helps to track such functional

Re: [PATCH V4 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops

2017-07-12 Thread Stephen Boyd
On 07/12, Stephen Boyd wrote: > On 07/06, Vivek Gautam wrote: > > From: Sricharan R > > > > The smmu needs to be functional only when the respective > > master's using it are active. The device_link feature > > helps to track such functional dependencies, so that the >

Re: [PATCH V4 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops

2017-07-12 Thread Stephen Boyd
On 07/06, Vivek Gautam wrote: > From: Sricharan R > > The smmu needs to be functional only when the respective > master's using it are active. The device_link feature > helps to track such functional dependencies, so that the > iommu gets powered when the master device

Re: [PATCH V4 4/6] iommu/arm-smmu: Add the device_link between masters and smmu

2017-07-12 Thread Stephen Boyd
On 07/06, Vivek Gautam wrote: > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index ddbfa8ab69e6..75567d9698ab 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -1348,6 +1348,7 @@ static int arm_smmu_add_device(struct device *dev) > struct

Re: [PATCH V4 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2017-07-12 Thread Stephen Boyd
On 07/06, Vivek Gautam wrote: > @@ -1231,12 +1237,18 @@ static int arm_smmu_map(struct iommu_domain *domain, > unsigned long iova, > static size_t arm_smmu_unmap(struct iommu_domain *domain, unsigned long iova, >size_t size) > { > - struct io_pgtable_ops *ops =

Re: [RFC 0/2] arm-smmu-v3 tlbi-on-map option

2017-07-12 Thread Michael S. Tsirkin
On Wed, Jul 12, 2017 at 06:54:56PM +0100, Will Deacon wrote: > Hi Eric, > > On Sun, Jul 09, 2017 at 05:15:01PM +0200, Eric Auger wrote: > > This series adds a new tlbi-on-map option to the smmuv3 driver. > > When set, the IO_PGTABLE_QUIRK_TLBI_ON_MAP quirk is applied for > > LPAE tables and the

Re: IOMMU - DMA debugging

2017-07-12 Thread Robin Murphy
On 12/07/17 18:20, Federico Vaga wrote: > On Wednesday, July 12, 2017 2:15:34 PM CEST Federico Vaga wrote: >> Thank you Robin >> >> (inline comments) >> >> On Wednesday, July 12, 2017 1:10:51 PM CEST Robin Murphy wrote: >>> On 12/07/17 08:11, Federico Vaga wrote: Hello, kernel

Re: [RFC 0/2] arm-smmu-v3 tlbi-on-map option

2017-07-12 Thread Will Deacon
Hi Eric, On Sun, Jul 09, 2017 at 05:15:01PM +0200, Eric Auger wrote: > This series adds a new tlbi-on-map option to the smmuv3 driver. > When set, the IO_PGTABLE_QUIRK_TLBI_ON_MAP quirk is applied for > LPAE tables and the smmuv3 driver sends TLB invalidations on map. > > This mode is useful

Re: IOMMU - DMA debugging

2017-07-12 Thread Federico Vaga
On Wednesday, July 12, 2017 2:15:34 PM CEST Federico Vaga wrote: > Thank you Robin > > (inline comments) > > On Wednesday, July 12, 2017 1:10:51 PM CEST Robin Murphy wrote: > > On 12/07/17 08:11, Federico Vaga wrote: > > > Hello, > > > > > > kernel version 4.4.x > > > > > > I'm facing an issue

Re: [git pull] IOMMU Updates for Linux v4.13

2017-07-12 Thread Linus Torvalds
On Wed, Jul 12, 2017 at 4:42 AM, Joerg Roedel wrote: > > Doing the pull-request against v4.12 blows up the diffstat, so I decided > to do the request against the last merge-base. Please let me know if I > should merge against v4.12 and re-send the request. No, this is the right

Re: Support SVM without PASID

2017-07-12 Thread Jean-Philippe Brucker
On 12/07/17 17:27, valmiki wrote: > On 7/11/2017 4:26 PM, Jean-Philippe Brucker wrote: >> Hi Valmiki, >> >> On 09/07/17 04:15, valmiki wrote: > Hi, > > In SMMUv3 architecture document i see "PASIDs are optional, > configurable, and of a size determined by the minimum > of the

Re: Support SVM without PASID

2017-07-12 Thread valmiki
On 7/11/2017 4:26 PM, Jean-Philippe Brucker wrote: Hi Valmiki, On 09/07/17 04:15, valmiki wrote: Hi, In SMMUv3 architecture document i see "PASIDs are optional, configurable, and of a size determined by the minimum of the endpoint". So if PASID's are optional and not supported by PCIe end

Re: Support SVM without PASID

2017-07-12 Thread valmiki
On 7/11/2017 1:01 AM, Jerome Glisse wrote: On Sun, Jul 09, 2017 at 08:45:57AM +0530, valmiki wrote: Hi, In SMMUv3 architecture document i see "PASIDs are optional, configurable, and of a size determined by the minimum of the endpoint". So if PASID's are optional and not supported by PCIe end

Re: IOMMU - DMA debugging

2017-07-12 Thread Federico Vaga
Thank you Robin (inline comments) On Wednesday, July 12, 2017 1:10:51 PM CEST Robin Murphy wrote: > On 12/07/17 08:11, Federico Vaga wrote: > > Hello, > > > > kernel version 4.4.x > > > > I'm facing an issue with the INTEL IOMMU driver and DMA mapping. I have an > > Ethernet driver that uses

[git pull] IOMMU Updates for Linux v4.13

2017-07-12 Thread Joerg Roedel
Hi Linus, Just a note before the request: This pull-request is against v4.12-rc7, as I didn't rebase my next branch against the final v4.12. This means that the two fixes that went into v4.12 already are also listed in the shortlog and diffstat below. Doing the pull-request against v4.12 blows

Re: IOMMU - DMA debugging

2017-07-12 Thread Robin Murphy
On 12/07/17 08:11, Federico Vaga wrote: > Hello, > > kernel version 4.4.x > > I'm facing an issue with the INTEL IOMMU driver and DMA mapping. I have an > Ethernet driver that uses `dma_alloc_coherent()` to allocate and map some > memory for DMA transfers. Assuming 02:00.0 is your actual

IOMMU - DMA debugging

2017-07-12 Thread Federico Vaga
Hello, kernel version 4.4.x I'm facing an issue with the INTEL IOMMU driver and DMA mapping. I have an Ethernet driver that uses `dma_alloc_coherent()` to allocate and map some memory for DMA transfers. The driver uses the DMA API as described in the documentation and I was expecting the