Re: [PATCH 1/2] lib/test: Delete five error messages for a failed memory allocation

2017-10-08 Thread Michal Hocko
On Sat 07-10-17 19:48:37, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 7 Oct 2017 17:34:23 +0200 > > Omit extra messages for a memory allocation failure in these functions. > > This issue was detected by using the Coccinelle software. Yes this makes sense. None of those really e

[PATCH] iommu/vt-d: Delete unnecessary check

2017-10-08 Thread Christos Gkekas
Variable did_old is unsigned so checking whether it is greater or equal to zero is not necessary. Signed-off-by: Christos Gkekas --- drivers/iommu/intel-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c index ebb

Re: [PATCH v8 2/2] IB/core: use MAP_DIRECT to fix / enable RDMA to DAX mappings

2017-10-08 Thread Dan Williams
p-level-sg_num_pages-from-amd-iommu/20171008-133505 > base: https://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdma.git > master > config: i386-randconfig-n0-201741 (attached as .config) > compiler: gcc-4.8 (Debian 4.8.4-1) 4.8.4 > reproduce: > # save the attached

Re: [PATCH 0/2] lib: Adjustments for 11 function implementations

2017-10-08 Thread Andy Shevchenko
On Sun, 2017-10-08 at 10:42 +0200, Christoph Hellwig wrote: > Please stop sending this crap. It's a move from one preference to > another slightly different one. You are free to apply your preference > if you do a major overhaul of some code (subject to maintainer > approval), > but without that

Re: [PATCH 2/2] lib: Improve a size determination in seven functions

2017-10-08 Thread Geert Uytterhoeven
On Sat, Oct 7, 2017 at 7:50 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 7 Oct 2017 19:19:45 +0200 > > Replace the specification of data structures by pointer dereferences > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer a

Re: [PATCH 0/2] lib: Adjustments for 11 function implementations

2017-10-08 Thread Christoph Hellwig
Please stop sending this crap. It's a move from one preference to another slightly different one. You are free to apply your preference if you do a major overhaul of some code (subject to maintainer approval), but without that they simply are churn. NAK for both patches.

Re: [PATCH 2/2] iommu/amd: Enforce alignment for MSI IRQs

2017-10-08 Thread Thomas Gleixner
On Fri, 6 Oct 2017, Joerg Roedel wrote: > From: Joerg Roedel > > Make use of the new alignment capability of > alloc_irq_index() to enforce IRQ index alignment > for MSI. > > Reported-by: Thomas Gleixner > Fixes: 2b324506341cb ('iommu/amd: Add routines to manage irq remapping > tables') > Sig

Re: [PATCH 1/2] iommu/amd: Add align parameter to alloc_irq_index()

2017-10-08 Thread Thomas Gleixner
On Fri, 6 Oct 2017, Joerg Roedel wrote: > From: Joerg Roedel > > For multi-MSI IRQ ranges the IRQ index needs to be aligned > to the power-of-two of the requested IRQ count. Extend the > alloc_irq_index() function to allow such an allocation. > > Reported-by: Thomas Gleixner > Fixes: 2b3245063