Re: [RFCv2 PATCH 14/36] iommu/arm-smmu-v3: Add support for Substream IDs

Hi Jean, On 2017/11/3 1:02, Shameerali Kolothum Thodi wrote: > > >> -Original Message- >> From: Jean-Philippe Brucker [mailto:jean-philippe.bruc...@arm.com] >> Sent: Thursday, November 02, 2017 3:52 PM >> To: Shameerali Kolothum Thodi >> Cc:

Re: [PATCH v2] iommu/iova: Use raw_cpu_ptr() instead of get_cpu_ptr() for ->fq

On 2017-09-21 17:21:40 [+0200], Sebastian Andrzej Siewior wrote: > get_cpu_ptr() disabled preemption and returns the ->fq object of the > current CPU. raw_cpu_ptr() does the same except that it not disable > preemption which means the scheduler can move it to another CPU after it > obtained the

RE: [RFCv2 PATCH 14/36] iommu/arm-smmu-v3: Add support for Substream IDs

> -Original Message- > From: Jean-Philippe Brucker [mailto:jean-philippe.bruc...@arm.com] > Sent: Thursday, November 02, 2017 3:52 PM > To: Shameerali Kolothum Thodi > Cc: linux-arm-ker...@lists.infradead.org; linux-...@vger.kernel.org; linux- >

Re: [RFCv2 PATCH 05/36] iommu/process: Bind and unbind process to and from devices

On 21/10/17 16:47, Sinan Kaya wrote: > Just some improvement suggestions. > > On 10/6/2017 9:31 AM, Jean-Philippe Brucker wrote: >> +spin_lock(_process_lock); >> +idr_for_each_entry(_process_idr, process, i) { >> +if (process->pid != pid) >> +continue; > if

Re: [RFCv2 PATCH 01/36] iommu: Keep track of processes and PASIDs

Hi Sinan, Sorry for the delay, thanks for reviewing this! On 21/10/17 00:32, Sinan Kaya wrote: > few nits below. > >> +/* >> + * Allocate a iommu_process structure for the given task. >> + * >> + * Ideally we shouldn't need the domain parameter, since iommu_process is >> + * system-wide, but we

Re: [RFCv2 PATCH 14/36] iommu/arm-smmu-v3: Add support for Substream IDs

Hi Shameer, On Thu, Nov 02, 2017 at 12:49:32PM +, Shameerali Kolothum Thodi wrote: > We had a go with this series on HiSIlicon D05 platform which doesn't have > support for ssids/ATS/PRI, to make sure it generally works. > > But observed the below crash on boot, > > [ 16.009084] WARNING:

RE: [RFCv2 PATCH 14/36] iommu/arm-smmu-v3: Add support for Substream IDs

Hi Jean, > -Original Message- > From: linux-arm-kernel [mailto:linux-arm-kernel-boun...@lists.infradead.org] > On Behalf Of Jean-Philippe Brucker > Sent: Friday, October 06, 2017 2:32 PM > To: linux-arm-ker...@lists.infradead.org; linux-...@vger.kernel.org; linux- > a...@vger.kernel.org;