Re: [PATCH v4 04/22] iommu/vt-d: add bind_pasid_table function

2018-06-06 Thread Jacob Pan
On Wed, 6 Jun 2018 12:20:51 +0100 Jean-Philippe Brucker wrote: > On 05/06/18 18:32, Jacob Pan wrote: > >> "bytes" could be passed by VFIO as argument to bind_pasid_table, > >> since it can deduce it from argsz > >> > > Are you suggesting we wrap this struct in a vfio struct with argsz? > > or w

[PATCH 2/2] iommu/vt-d: fix dev iotlb pfsid use

2018-06-06 Thread Jacob Pan
PFSID should be used in the invalidation descriptor for flushing device IOTLBs on SRIOV VFs. Signed-off-by: Jacob Pan --- drivers/iommu/dmar.c| 6 +++--- drivers/iommu/intel-iommu.c | 16 +++- include/linux/intel-iommu.h | 5 ++--- 3 files changed, 20 insertions(+), 7 delet

[PATCH 0/2] iommu/vt-d: pfsid fix

2018-06-06 Thread Jacob Pan
When device invalidation throttling(DIT) is supported by an IOMMU, device TLB invalidation should include physical function source ID(PFSID). Jacob Pan (2): iommu/vt-d: add definitions for PFSID iommu/vt-d: fix dev iotlb pfsid use drivers/iommu/dmar.c| 6 +++--- drivers/iommu/intel-

[PATCH 1/2] iommu/vt-d: add definitions for PFSID

2018-06-06 Thread Jacob Pan
When SRIOV VF device IOTLB is invalidated, we need to provide the PF source ID such that IOMMU hardware can gauge the depth of invalidation queue which is shared among VFs. This is needed when device invalidation throttle (DIT) capability is supported. This patch adds bit definitions for checking

Re: usb HC busted?

2018-06-06 Thread Sudip Mukherjee
Hi Andy, And we meet again. :) On Wed, Jun 06, 2018 at 06:36:35PM +0300, Andy Shevchenko wrote: > On Wed, 2018-06-06 at 17:12 +0300, Mathias Nyman wrote: > > On 04.06.2018 18:28, Sudip Mukherjee wrote: > > > On Thu, May 24, 2018 at 04:35:34PM +0300, Mathias Nyman wrote: > > > > > > > Odd and un

Re: usb HC busted?

2018-06-06 Thread Sudip Mukherjee
On Wed, Jun 06, 2018 at 05:12:21PM +0300, Mathias Nyman wrote: > On 04.06.2018 18:28, Sudip Mukherjee wrote: > > On Thu, May 24, 2018 at 04:35:34PM +0300, Mathias Nyman wrote: > > > > > > > Will request you to have a look at it. > > > > Odd and unlikely, but to me this looks like some issue in

Re: usb HC busted?

2018-06-06 Thread Andy Shevchenko
On Wed, 2018-06-06 at 17:12 +0300, Mathias Nyman wrote: > On 04.06.2018 18:28, Sudip Mukherjee wrote: > > On Thu, May 24, 2018 at 04:35:34PM +0300, Mathias Nyman wrote: > > > > Odd and unlikely, but to me this looks like some issue in allocating > dma memory > from pool using dma_pool_zalloc() >

Re: usb HC busted?

2018-06-06 Thread Mathias Nyman
On 04.06.2018 18:28, Sudip Mukherjee wrote: On Thu, May 24, 2018 at 04:35:34PM +0300, Mathias Nyman wrote: Log show two rings having the same TRB segment dma address, this will completely mess up the transfer: While allocating rigs the enque pointers for the two rings are the same: 461.85931

Re: [PATCH v4 04/22] iommu/vt-d: add bind_pasid_table function

2018-06-06 Thread Jean-Philippe Brucker
On 05/06/18 18:32, Jacob Pan wrote: >> "bytes" could be passed by VFIO as argument to bind_pasid_table, since >> it can deduce it from argsz >> > Are you suggesting we wrap this struct in a vfio struct with argsz? or > we directly use this struct? > > I need to clarify how vfio will use this. Rig

Re: [PATCH] iommu/ipmmu-vmsa: Document R-Car V3H and E3 IPMMU DT bindings

2018-06-06 Thread Geert Uytterhoeven
On Mon, May 21, 2018 at 4:41 PM, Magnus Damm wrote: > From: Magnus Damm > > Update the IPMMU DT binding documentation to include the compat strings > for the IPMMU devices included in the R-Car V3H and E3 SoCs. > > Signed-off-by: Magnus Damm Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,